Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210816011948.1118959-1-jay.xu@rock-chips.com>
In-Reply-To: <20210816011948.1118959-1-jay.xu@rock-chips.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Mon, 16 Aug 2021 21:13:56 +0200
Message-ID: <CAMpxmJWQ1pDoPZHjg1vvZYhPrY+3BZi3Zuv2P7xKYRDW0dyw8Q@mail.gmail.com>
Subject: Re: [PATCH v8 0/9] gpio-rockchip driver
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     =?UTF-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>,
        Jianqun Xu <jay.xu@rock-chips.com>,
        Rob Herring <robh+dt@kernel.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        linux-devicetree <devicetree@vger.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Aug 16, 2021 at 3:19 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
>
> Separate gpio driver from pinctrl driver, and support gpio v2 controller.
>
> Jianqun Xu (9):
>   pinctrl/rockchip: always enable clock for gpio controller
>   pinctrl/rockchip: separate struct rockchip_pin_bank to a head file
>   pinctrl/rockchip: add pinctrl device to gpio bank struct
>   dt-bindings: gpio: change items restriction of clock for
>     rockchip,gpio-bank
>   gpio/rockchip: add driver for rockchip gpio
>   gpio/rockchip: use struct rockchip_gpio_regs for gpio controller
>   gpio/rockchip: support next version gpio controller
>   gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type
>   pinctrl/rockchip: drop the gpio related codes
>
>  .../bindings/gpio/rockchip,gpio-bank.yaml     |   5 +-
>  drivers/gpio/Kconfig                          |   8 +
>  drivers/gpio/Makefile                         |   1 +
>  drivers/gpio/gpio-rockchip.c                  | 771 +++++++++++++++
>  drivers/pinctrl/pinctrl-rockchip.c            | 909 +-----------------
>  drivers/pinctrl/pinctrl-rockchip.h            | 287 ++++++
>  6 files changed, 1089 insertions(+), 892 deletions(-)
>  create mode 100644 drivers/gpio/gpio-rockchip.c
>  create mode 100644 drivers/pinctrl/pinctrl-rockchip.h
>
> --
> v8:
>  - fix rockchip,gpio-bank.yaml about clocks and clock-names
>  - fix commit author of rockchip,gpio-bank.yaml patch to me
>
> v7:
>  - include <linux/gpio/driver.h> instead of <linux/gpio.h>
>  - use gpio align id instead of gpio-name
>
> v6:
>  - new gpio-driver first and then drop gpio from pinctrl
>  - reorder patches
>  - cherry-pick gpio dt-binding from chenliang
>
> v5:
>  - change to devel branch
>
> 2.25.1
>
>
>

Linus,

are you going to take the entire series through the pinctrl tree or
should we split the patches?

Bart