Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp599922pxb; Mon, 16 Aug 2021 12:40:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAWAa66Rs4vQQCwFBXGy5ILNki5IZbPXrdCAOfwMbZt3k0/ogOawXq8mCPkhaLpRF3Kt5H X-Received: by 2002:a05:6638:3382:: with SMTP id h2mr237047jav.77.1629142818127; Mon, 16 Aug 2021 12:40:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629142818; cv=none; d=google.com; s=arc-20160816; b=tWaDqJ7/TqFU9yjAoNvoR9+OS57Zn9q6tI77wpjpmOg91ao8c6E5P7Mb5B8Kfw2Q8j 8Y1py/hCjw7+tTlM5XIY6oaBrhTUguTyDhcauPHFPfcU11yE5H7Fie1lEN1UDk3bdXxd 6RU9RKMRZ0Yrs0OMpOIsRJdSruTZhQGeWEl3p6Ast8GCSc7IVOIK0Bi4OyOiA3JJvliz Z4OLJlmN7xySlKWopEMvemtZng1L4Hgz08lvMHSbSn2v1NDGyEa9BGTZGZVEStoyljsJ DjGNKoXa7OB2c6soVVErC1kNrKbwQ2CwyEXLJuc5QLzxJa1Oke1vPSl/002rRDFy0S84 FxPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HK2ZFnceD4MGP7RS84uFdlWNKcf4FPa/uPZZD88rUwE=; b=Go9WjjAq0Y0pVSpPMLnKwcC74tRlS8h2rE1EhyeX/zR6KnZn9HbA7FokaNa3wsDP1P JN13DQhgkGmVrhmLebvNxDbWxOC3Vmrwd042GPdjE8tkm7uzUrOB8fVFpJFodHCWGc31 envsJBxHAg7YDeuxiPP8q8t1i+gQdSphD/aBWCh5t4nuA3VHx6DGKb5uSRo/++6cQNyw YLG52rnUHGKHgcIRJ+52u+nJJzv7qhpNqoXRhl9IyQ0Q6D8fT1C5V4oRR4lgKiMvJEov NJEDsyfYPqbuLXwJcFqyz3xIHTzsFZ1drG26zNZnPCMvrqFL2MtBCbHpiVoahjXEBZ/2 S+AA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="i/cQTEec"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i11si93536ilm.28.2021.08.16.12.40.06; Mon, 16 Aug 2021 12:40:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="i/cQTEec"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229790AbhHPTjf (ORCPT + 99 others); Mon, 16 Aug 2021 15:39:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbhHPTje (ORCPT ); Mon, 16 Aug 2021 15:39:34 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27098C061764 for ; Mon, 16 Aug 2021 12:39:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HK2ZFnceD4MGP7RS84uFdlWNKcf4FPa/uPZZD88rUwE=; b=i/cQTEecxY0aNKFZ/qiSS1T0SJ q4fsdo7Fk3fjAY0WPvrRjEjAigTJiDVUVSZAd8ycyK7H0i/Ks+Gdhl+cLtlG8nhR93oH9lFe3xo6o K+SQrcL1uyHD6V4ouKsDorVrwt8Mk3rge5QaMfoMLpD7hNjhJSaTdW+/MfrCRmy+zP7lDVs6f9QWK /aeY1Pp3OSL4fBgy5mSJlpX6g3uNaPyjh8w4J1pT9jk86HjZu0dVJMGg6YOnDRF53FH/RYhDWARTq q1SAUj8Q9Wbx5weGKfJfvm73ARBiY0pKTIPaz72oyheJU8puBrUbBS+Cnap0UWrj/iH+sZQruMvkQ ZNKWHFJA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFiQi-001jqC-SS; Mon, 16 Aug 2021 19:37:57 +0000 Date: Mon, 16 Aug 2021 20:37:52 +0100 From: Matthew Wilcox To: Yang Shi Cc: naoya.horiguchi@nec.com, osalvador@suse.de, tdmackey@twitter.com, akpm@linux-foundation.org, corbet@lwn.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: hwpoison: don't drop slab caches for offlining non-LRU page Message-ID: References: <20210816180909.3603-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210816180909.3603-1-shy828301@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2021 at 11:09:08AM -0700, Yang Shi wrote: > But the most disappointing thing is all the effort doesn't make the page > offline, it just returns: > > soft_offline: 0x1469f2: unknown non LRU page type 5ffff0000000000 () It's a shame it doesn't call dump_page(). There might be more interesting information somewhere in struct page that would help us figure out what kind of page it was in your environment. For example, it might be a page table page or a page allocated for vmalloc(), and in both those cases, there are things we might be able to do (we'd certainly be able to figure out that it isn't worth shrinking slab!)