Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     Leon Romanovsky <leon@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
CC:     Leon Romanovsky <leonro@nvidia.com>,
        Guangbin Huang <huangguangbin2@huawei.com>,
        Jiri Pirko <jiri@nvidia.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Salil Mehta <salil.mehta@huawei.com>,
        Shannon Nelson <snelson@pensando.io>,
        Yisen Zhuang <yisen.zhuang@huawei.com>,
        Yufeng Mo <moyufeng@huawei.com>
Subject: RE: [PATCH net-next 5/6] devlink: Clear whole devlink_flash_notify
 struct
Thread-Topic: [PATCH net-next 5/6] devlink: Clear whole devlink_flash_notify
 struct
Thread-Index: AQHXkPLcujmXdlFgmkiF0D7fqGlHUat2qVXw
Date:   Mon, 16 Aug 2021 21:29:39 +0000
Message-ID: <CO1PR11MB50896CC64EB40DE3B2D1775AD6FD9@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <cover.1628933864.git.leonro@nvidia.com>
 <d66bfd66eb8744663b7a299db0df7203bc6640cd.1628933864.git.leonro@nvidia.com>
In-Reply-To: <d66bfd66eb8744663b7a299db0df7203bc6640cd.1628933864.git.leonro@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RvVkATjJ9JmFCNN4f3YKDde10I9onbAU894FbwwKBIJvUBfRA3r0cN9HstF5?=
 =?us-ascii?Q?V9l/LfocOuOr3g2dnxbZxWbR1IWqD0I0Tfa/bAuUFPFtFlZwir46p5TXm0xD?=
 =?us-ascii?Q?Ar0EoJcg+qhbleBhLHBJFIXq3SHXjt30niJzWeYK2k5i7679xtN8SHMWnCn3?=
 =?us-ascii?Q?FpuspBZ8ifUktxViktHpcU3u5+Z7ss9Em5G1NfqGFiI29AKYGWL0h4fgTzM5?=
 =?us-ascii?Q?FCt8r3ZsnwzXj0x0jrgWqLr+rqy4d5EjFy+pQVm05Os361SuTZqRel65f4ap?=
 =?us-ascii?Q?O5vXYmgWKhq3J7c8YNbw5V4ufGiKRCocynfPjQMyb4NIM4zY7I6kjTCdj3pQ?=
 =?us-ascii?Q?vLgnv5j3T0aecWf6iWulr/NQ6oqhbzqxvf9eBm5xT0o/rKM8UelEcsOU6cqZ?=
 =?us-ascii?Q?m79llIVYVK25o2DgkQxc7MsVL4OZ1uvdPSZ+vFsEgBV6RdYjffzfWK1HkVH5?=
 =?us-ascii?Q?WfBkJ+v64chkHUDUwFcYYatAHKuv2Tv3boSnQH/4bTbDeIFjE0Ik8+w0H5dz?=
 =?us-ascii?Q?Ybm9G+jTidDzdw2/jeEIFxo4mU613IVzVPlB5PZRhPK0cveQc05HzL98COAS?=
 =?us-ascii?Q?vcDTzFu7Joryu892WO3IDqxBVwcLHZSJmyXdnTkRydfLMkIgxGtSlLOzx2Ld?=
 =?us-ascii?Q?q/HoP9mUa/L1bbdajYKFJHBeHFpO/tRVkvPNAMvDT2bo6IsdPAHz7nBcfCb1?=
 =?us-ascii?Q?mUHRS7vOYSikVlmPm9m1rXTHzYnmJ2kG5E3OUDGj/tf4hkR/tO5PXFSXFBxS?=
 =?us-ascii?Q?9hu496gpo4rQJMpLh1U0al4sVf85QKe7NhXp5u15WLtAlu57IUJc8Nnon3QS?=
 =?us-ascii?Q?vnHh4SIxLI2xgP1brb/Dha5265xmmVRAvdeRlXXD4Gq+rnguxWKyNMFzlvrT?=
 =?us-ascii?Q?BP92zjWy1LF1O1u2/H3wM52YztdJXF+WZVX0LiM6obh3RxOznDex4dNTdg8W?=
 =?us-ascii?Q?3MMlHC/3/O6OlgqjZFy8hot7fG6xgo/2a8upqimecmZ/Vmz3XycZCy+yp8hx?=
 =?us-ascii?Q?q6N2HBsig036X+gySu7NRBoBwe5mHlQra1qXvY4L+c8vdb+zr1/dSrxAVvRw?=
 =?us-ascii?Q?Vk0y72cYZ3jNJrjSYE+s1ebK/k84nuWWjjLg27bnyo1aUGbT3Idkh25ShQF5?=
 =?us-ascii?Q?g8U3cMZ2NQHhZsLIu/YiBuDhplF6RPrW9Boa5XqKJt+Ht1F0q16WYp8zG3gl?=
 =?us-ascii?Q?GBx5EaCNqMf15HtfI6Qr5qEqVvlVS52FPwn175fAYouJnxkoCFHxlGqXaTIU?=
 =?us-ascii?Q?poBCf2qMORvassNub1HWOLgLLnvIHaoWYx0YetRIede9gd6LVW20gALvQRzv?=
 =?us-ascii?Q?FIY=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20219bf8-eb66-4016-6c8b-08d960fcf43e
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2021 21:29:39.4197
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8CjW+ckA7+kb2nTzMTbIm2xnwtmKivH+qMMbbGpXyKnAmzc6+kc0Pf0ncPSXpM8wYSxT5fuO3K4mM7QsSz3+t6bXDe6IEIXPzeVE9VGxxAQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5154
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Leon Romanovsky <leon@kernel.org>
> Sent: Saturday, August 14, 2021 2:58 AM
> To: David S . Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.o=
rg>
> Cc: Leon Romanovsky <leonro@nvidia.com>; Guangbin Huang
> <huangguangbin2@huawei.com>; Keller, Jacob E <jacob.e.keller@intel.com>; =
Jiri
> Pirko <jiri@nvidia.com>; linux-kernel@vger.kernel.org; netdev@vger.kernel=
.org;
> Salil Mehta <salil.mehta@huawei.com>; Shannon Nelson
> <snelson@pensando.io>; Yisen Zhuang <yisen.zhuang@huawei.com>; Yufeng
> Mo <moyufeng@huawei.com>
> Subject: [PATCH net-next 5/6] devlink: Clear whole devlink_flash_notify s=
truct
>=20
> From: Leon Romanovsky <leonro@nvidia.com>
>=20
> The { 0 } doesn't clear all fields in the struct, but tells to the
> compiler to set all fields to zero and doesn't touch any sub-fields
> if they exists.
>=20
> The {} is an empty initialiser that instructs to fully initialize whole
> struct including sub-fields, which is error-prone for future
> devlink_flash_notify extensions.
>=20
> Fixes: 6700acc5f1fe ("devlink: collect flash notify params into a struct"=
)
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>

Yep, we should have used {} before. Are there any other misses where I used=
 { 0 }.... Nope, I just double checked. Ok great!

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> ---
>  net/core/devlink.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index d218f57ad8cf..a856ae401ea5 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -4169,7 +4169,7 @@ static void __devlink_flash_update_notify(struct
> devlink *devlink,
>=20
>  static void devlink_flash_update_begin_notify(struct devlink *devlink)
>  {
> -	struct devlink_flash_notify params =3D { 0 };
> +	struct devlink_flash_notify params =3D {};
>=20
>  	__devlink_flash_update_notify(devlink,
>  				      DEVLINK_CMD_FLASH_UPDATE,
> @@ -4178,7 +4178,7 @@ static void devlink_flash_update_begin_notify(struc=
t
> devlink *devlink)
>=20
>  static void devlink_flash_update_end_notify(struct devlink *devlink)
>  {
> -	struct devlink_flash_notify params =3D { 0 };
> +	struct devlink_flash_notify params =3D {};
>=20
>  	__devlink_flash_update_notify(devlink,
>  				      DEVLINK_CMD_FLASH_UPDATE_END,
> --
> 2.31.1