Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster()
 stub
To:     Jaegeuk Kim <jaegeuk@kernel.org>
Cc:     Chao Yu <chao@kernel.org>, linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
References: <20210816234247.139528-1-nathan@kernel.org>
 <YRsD6P4x9v38oDWl@google.com>
From:   Nathan Chancellor <nathan@kernel.org>
Message-ID: <1f2eff07-f003-03c8-b3c8-0e06f9bf9684@kernel.org>
Date:   Mon, 16 Aug 2021 17:34:28 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <YRsD6P4x9v38oDWl@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/16/2021 5:33 PM, Jaegeuk Kim wrote:
> Hi Nathan,
> 
> On 08/16, Nathan Chancellor wrote:
>> Without this, there is a warning in nearly every fs/f2fs/ file when
>> F2FS_FS_COMPRESSION is not set:
>>
>> In file included from fs/f2fs/super.c:31:
>> fs/f2fs/f2fs.h:4251:13: warning: unused function 'f2fs_sanity_check_cluster' [-Wunused-function]
>> static bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
>>              ^
>> 1 warning generated.
>>
>> Fixes: 1495870233e7 ("f2fs: compress: do sanity check on cluster")
> 
> This has not been merged yet, so if you don't mind, can I integrate your fix in
> the original patch?

Sure thing!

Cheers,
Nathan