Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   ChiaWei Wang <chiawei_wang@aspeedtech.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        "kbuild@lists.01.org" <kbuild@lists.01.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "joel@jms.id.au" <joel@jms.id.au>,
        "andrew@aj.id.au" <andrew@aj.id.au>,
        "cyrilbur@gmail.com" <cyrilbur@gmail.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
CC:     "lkp@intel.com" <lkp@intel.com>,
        "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>
Subject: RE: [PATCH 1/2] soc: aspeed: Add LPC mailbox support
Thread-Topic: [PATCH 1/2] soc: aspeed: Add LPC mailbox support
Thread-Index: AQHXkAbuYQV5hUkRrk6mm7VMl+/1kat15ZCAgAEbqYA=
Date:   Tue, 17 Aug 2021 02:37:13 +0000
Message-ID: <HK0PR06MB3779008AC59C277899C95D1291FE9@HK0PR06MB3779.apcprd06.prod.outlook.com>
References: <20210813054758.13189-2-chiawei_wang@aspeedtech.com>
 <202108160813.GOZ1P4Y8-lkp@intel.com>
In-Reply-To: <202108160813.GOZ1P4Y8-lkp@intel.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Rvv1fx+rxSjSdeoV0RKEn0CvbXcis8B7l2HDxsgUgc9Z0IlSdcACoEM//xVb?=
 =?us-ascii?Q?2HUDn5Wj7m2wTn5y29aEnkb+iTGPQk/9x9WXKo2NQztBZuvau4JCczfx4+aP?=
 =?us-ascii?Q?CYmyOn5rD/RT657hMzo2tXXDLRf7rNZ824VRW9BXfmnbpyKmKrqpKpIUbtkE?=
 =?us-ascii?Q?X9Hk/jZfJzOTvxjFV8vTWdbRd47RpENu/CbgkYBrsBBPXSBzlgBPxFDE7C0R?=
 =?us-ascii?Q?5BDwU0bI4F+bqSuROh9PwFRBB9S/ttM168vn0qZG8uwTXN9gOJS7EGrbMh0k?=
 =?us-ascii?Q?XwSs0+/HMAQaFn93Xrxx7UIHNlzIYcxH3o5sENSJ4X41mVAijGhr5c1E8rMi?=
 =?us-ascii?Q?d7EBfSFQIy0edmT9wupt+IcyjCbRC8UDSDrC3pxZ0nr/+jX5g+3oG08ZlBf9?=
 =?us-ascii?Q?a+XnkozhPAJHfK2OCmNHbkUO6VpvVHpOvXLdIyZLwh3pT8FUn7zx6K7LzYn0?=
 =?us-ascii?Q?mixnB++YQMQRTuTEJSTNokqtKktCZja/iuo1mZNwPCHzn5eDlZGySW+0WrPI?=
 =?us-ascii?Q?6e7MDq9TsyuW/j7zoIaYxwI0DUgTscobcdIGUHScDLGdmvPf/OX5s7a01AY7?=
 =?us-ascii?Q?dlr6wV0dInk0hW72e3thc7G8UBPasolOC35CBvIv7XZtrompP983CajfWYAr?=
 =?us-ascii?Q?KVw5rQFriMQvOXw5qv6VfuORxZgVS3W3/kmJYnCbsWqFD5U7pPZMztlIpRKZ?=
 =?us-ascii?Q?EJjIm/pRay5KuHkUB8m4S/rVOLRZy/VAfsgBqE2uiiqKzzziEpHgytyChoIc?=
 =?us-ascii?Q?olVj99gnU2WqmJGBEM73dL0eXtCAw0FeTN3XmQGRFMhTybleWjQQ6dwAcf/E?=
 =?us-ascii?Q?lChHX1+vDbRDN3jhGTF0vO5E6GL6E95QDfZLKBLhKxIHjzorEQkL+1rBY4oM?=
 =?us-ascii?Q?TtD4UONgXOfZkiPt8h2/ZdKcKqrbMrn5zA+5+nBLhPFE/geXUtg1K9A+wp+S?=
 =?us-ascii?Q?UTPwkHZpoO6/IzkYVfczTj2xUaFzSEeSK+dzqQINvmcIc6lnrJoi6pPHkR/y?=
 =?us-ascii?Q?fcIJb5Q9LInQ++84epHn8ll2uM15yvXGyLpdQ1HmY+9V5HaIx8UN7xXo922u?=
 =?us-ascii?Q?R+Fj+F5gBlM8nvDUZrjrtLSCcIfQs1TNwRTXul6zH/ljUNBgz59WGc9Y0Y+t?=
 =?us-ascii?Q?rpkhNG11yFgj3pJhnXACgL3QlvrwoI3Nfc0AL+Y0QhbohvBXO04zry8oXT4g?=
 =?us-ascii?Q?NNOt5egc0NdmeATfhpK1DqU539cfHOFoo8nnckfeZDCXDOTzT7/8t4QlrMPB?=
 =?us-ascii?Q?P5+Kp0FX0J+7f+P5RbfXwpldVHq8cHz5ihVldLurNU2enyMwZicjlR4h9DzT?=
 =?us-ascii?Q?kNWyIeteEmBvT+bOplG1V52C?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3779.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e0fd7d7-b289-450b-ea81-08d96127ebc6
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2021 02:37:13.5457
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zdfIDiJoMDRf3KTnNslhpIcpJKfmMILUK/xmLR/QeAqzsOroXwI5x9PmS0oCMfB4MNVycESbj7XhYQPQk/Oe4ojIZvtKTE1NaEbXT93XROE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2609
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dan,

> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Sent: Monday, August 16, 2021 5:41 PM
>=20
> Hi Chia-Wei,
>=20
> url:
> https://github.com/0day-ci/linux/commits/Chia-Wei-Wang/aspeed-Add-LPC-m
> ailbox-support/20210813-134908
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git
> for-next
> config: openrisc-randconfig-m031-20210816 (attached as .config)
> compiler: or1k-linux-gcc (GCC) 11.2.0
>=20
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>=20
> smatch warnings:
> drivers/soc/aspeed/aspeed-lpc-mbox.c:230 aspeed_mbox_ioctl() warn: maybe
> return -EFAULT instead of the bytes remaining?
>=20
> vim +230 drivers/soc/aspeed/aspeed-lpc-mbox.c
>=20
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  214  static long
> aspeed_mbox_ioctl(struct file *file, unsigned int cmd,
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  215
> unsigned long param)
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  216  {
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  217  	struct aspeed_mbox
> *mbox =3D file_mbox(file);
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  218  	const struct
> aspeed_mbox_model *model =3D mbox->model;
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  219  	struct
> aspeed_mbox_ioctl_data data;
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  220  	long ret;
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  221
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  222  	switch (cmd) {
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  223  	case
> ASPEED_MBOX_IOCTL_GET_SIZE:
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  224  		data.data =3D
> model->dr_num;
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  225  		ret =3D
> copy_to_user((void __user *)param, &data, sizeof(data));
>=20
> This should be:
>=20
> 	if (copy_to_user((void __user *)param, &data, sizeof(data)))
> 		return -EFAULT;

Will be fixed in v2 patch. Thanks for the review.

Regards,
Chiawei

>=20
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  226  		break;
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  227  	default:
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  228  		ret =3D -ENOTTY;
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  229  	}
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13 @230  	return ret;
> 72c5a69dc779f5 Chia-Wei Wang 2021-08-13  231  }
>=20
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org