Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp899267pxb; Mon, 16 Aug 2021 21:56:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzSLHGhtRAtxlzQsDe06NYh2zUSnKsGCMjj+LA3XJ8kfpBcWSUwXQQgOAaGofcfQghWYfU X-Received: by 2002:a50:99cc:: with SMTP id n12mr1099871edb.53.1629176195719; Mon, 16 Aug 2021 21:56:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629176195; cv=none; d=google.com; s=arc-20160816; b=fz/PhOrm/qMNrNvhz3jzzgCnAJj7MHRAyeqRgPM+a/R+p3pFIcYGVWXrWMz4A9sSID PUXt+Vu8LFxs9+22LwjqGHTvhYYRizjJgcYoopxspy04zrtn/Vz+8l6INTqZey5L5jD3 8NmtScynn9nA30b8vJAqZmiP4I1Gd2NoWh9DGyeC7ollXecJXWiWTN2uFE1zmKqzchKD 2Aw5JSMxHdfNjxEhwsFaAukTKUK97YnPIW8ep71IRGmflWf5eaxkwJwVdNVLGGP7L+Ip nJMD4FQWsKxB5+XK1gmtCzKp9xpM0MTCuAUrFaTMwn0cmkNN4VT487tnK2VBavSqdYag DVsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=4HZ7SiBIY+vOExvEgGOadqeLCgVsplR9xI6/4IDID4Y=; b=PAp3VWdjVt3PgTDamSrxuTTXTSildxe6Y4PAjv0WAt4ijr54pBlupCTfvZV53Axv5x nYDE/2dukMqbEbWGSqzV/HCHStd6lKXB6rTyP5Hrs+I3B6B4gJJGr5mflOmcApvYksda vWhiPebN1tEq6bHXg1/GQXlvG0gMpmL9qt0XDr87fSpCSq4nyrUWkmGDMGCi923CY/7O PrTa4XLQI34kCQl8kmzo/NkZ3dL+D/UbyG6n9RqFO8ONSWIVOOce2HPmwI7zQXkNLV7P gii8QUaGdCrTobWyrWt5xcczveXFZAVlbaaH4APnv1lHCIk8wWk3OJJVR9FckJF+cRO9 4kdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p4si1358910eju.502.2021.08.16.21.56.13; Mon, 16 Aug 2021 21:56:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234103AbhHQEwy (ORCPT + 99 others); Tue, 17 Aug 2021 00:52:54 -0400 Received: from verein.lst.de ([213.95.11.211]:57018 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230272AbhHQEwx (ORCPT ); Tue, 17 Aug 2021 00:52:53 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id AEC7F6736F; Tue, 17 Aug 2021 06:52:18 +0200 (CEST) Date: Tue, 17 Aug 2021 06:52:18 +0200 From: Christoph Hellwig To: Ming Lei Cc: kernel test robot , Thomas Gleixner , Jens Axboe , clang-built-linux@googlegroups.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 5/7] genirq/affinity: move group_cpus_evenly() into lib/ Message-ID: <20210817045218.GE3874@lst.de> References: <20210814123532.229494-6-ming.lei@redhat.com> <202108150001.EBuNGcQ8-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2021 at 09:04:21AM +0800, Ming Lei wrote: > But the above symbol is exported via EXPORT_SYMBOL_GPL(), in current > kernel tree, we usually keep such exported symbol as global, or is there > some change in kernel coding style recently? This is about prototypes. You need to include group_cpus.h in group_cpus.c so that the prototype is visible at the implementation site.