Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Felipe Balbi <balbi@kernel.org>,
        Chunfeng Yun <chunfeng.yun@mediatek.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Al Cooper <alcooperx@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Rikard Falkeborn <rikard.falkeborn@gmail.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bcm-kernel-feedback-list@broadcom.com" 
        <bcm-kernel-feedback-list@broadcom.com>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        Eddie Hung <eddie.hung@mediatek.com>
Subject: RE: [PATCH 3/6] usb: cdnsp: fix the wrong mult value for HS isoc or
 intr
Thread-Topic: [PATCH 3/6] usb: cdnsp: fix the wrong mult value for HS isoc or
 intr
Thread-Index: AQHXjyrfpZtBA2WHu0CYToBU7vJUratvbn+AgAe9KXA=
Date:   Tue, 17 Aug 2021 05:05:26 +0000
Message-ID: <BYAPR07MB53815317736C694887D51BE8DDFE9@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <1628739182-30089-1-git-send-email-chunfeng.yun@mediatek.com>
 <1628739182-30089-3-git-send-email-chunfeng.yun@mediatek.com>
 <87mtpnyx3g.fsf@kernel.org>
In-Reply-To: <87mtpnyx3g.fsf@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R2oxc52uZghqRo8ltVqCIHqBjmO1fkBXI/M76SgWUBImqB+4eAsgR1w+zQK9?=
 =?us-ascii?Q?6BMQzEbakIJgGNyeOwmn/GotLIGQQBA4dJMg7R0SF9/dIBSPhbiy75y2CNry?=
 =?us-ascii?Q?VfH9CO9jWXCOWZlgAWA+XO9/BvMT5715sgq9rl0rjAjVQl44qDygM0uqjZLW?=
 =?us-ascii?Q?Bk7pAzZumSenHm8/jFtibA7u32SK5Z4QK76wulFoGa5OpdhKd47kEdN8Kf0+?=
 =?us-ascii?Q?U/ILi2N6PrCNH5PZYZSN0QNhD5+Kj6Cx6nkndGOlIm0kb0The/7/UjRlVPte?=
 =?us-ascii?Q?tHRDHo7J2in9I+R5yc5LRiScQSDf0KRjclY4YNrQ5PPOQQHFA+DDuY+TvTGN?=
 =?us-ascii?Q?uk3aln7uZUCGNeI2OcUga1Qj1BxqNMNrjSNgx+0i4PJB6xXu3WSKzbDcrvBI?=
 =?us-ascii?Q?PcGRw9IUCY4IgWFdSsGSo7NeAlyMZCQF3WkomI4W2oJkYAY/te7/VknZYnUG?=
 =?us-ascii?Q?DMjpb44X2iT+wCRNU/emnyBTbOHkISUAW864+XuoBzPfIaSpibCOQlng49/7?=
 =?us-ascii?Q?I+4toIF93kg/T5HsfjAO+Qq3Oq8VoY5cmoWETSB9b1JmQ5N3TbOfrtideoP9?=
 =?us-ascii?Q?sLbryEi7XUlrZqfdWyP3tZ4mx6Zcjo5EyPM7X3nWHOjqgpuqcXXN5P6N4e05?=
 =?us-ascii?Q?mTa9dma0x6gGxzyHzLKXUNfElYZq2h7K/iIYDK2wmA4lgBnVbyiAv6Eqbb9b?=
 =?us-ascii?Q?ntzUlhYfaZrPQX9rb6YHi1YbHHZE/GX5zOFPsxdTSufBPTctCXseXKuZZoDb?=
 =?us-ascii?Q?QlUYZwZ1FZQ2d2vVmeoWgNozpjlrtelhGdIbXFzdeQ4/HsLOzTDRzzfdi1lN?=
 =?us-ascii?Q?47nUjMqKRf08bb8ByGDgaBOi5qciafJn3FAAb+h+e61XuCLVvngc+Goq8HWk?=
 =?us-ascii?Q?xVFwC4s2f33Ux/HsTetkpFxeknYSU+uVE8/Xfxe0opPnwtxG4ee4sPNiaUsi?=
 =?us-ascii?Q?tY1Tu8imjJ/bdaSD6vp9d57bu21F3u8PpNPsAYLJIdDuICo0Sob9k9PpwkC1?=
 =?us-ascii?Q?s5ehM3fRmGGBOEYlQxByGsYoGt8nD9LJWLGpmqfYWWPbAQUuqH3PKKPC3Pvq?=
 =?us-ascii?Q?7O/34t24LrSY3vAEnhE5zjk16/XWElLLu4ElPXOc14cxi2/3oFoVKd2k4VXZ?=
 =?us-ascii?Q?4Wo5kCjbkNByYRvtG6HcOH7QayVg74Vibi8eMoXCzpGrdMFyMsP9GWCf8YN/?=
 =?us-ascii?Q?G2wvKHy8vGu6b7PNnx8Mt1D6ol4/zvy9LIfql1AOqN+/VpN0hVeuwM8B2+0W?=
 =?us-ascii?Q?YbICdaHXXGVdiHMUwLkwb/WWRgePkR+D2F6qGo4pO2K963sCA1b8GQwc9YWJ?=
 =?us-ascii?Q?kKXE+DZfru83Lu97bifZgB5a?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR07MB5381.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 611e0ef9-b99c-4988-5459-08d9613ca028
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2021 05:05:26.1586
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: s0ewYtzLpin7p+DxO4F+yv4BDVorPnsHXZzC1+88UdCRzDKQXaLbuxZhYkDBWKLwem3th44t/obuxIFVWf3wqOIkuR/wlWDaeMzVrlELmts=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4662
X-Proofpoint-ORIG-GUID: VBkvKkaK0pwR11ItLl7f9K5hQCmugEcl
X-Proofpoint-GUID: VBkvKkaK0pwR11ItLl7f9K5hQCmugEcl
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-08-17_01,2021-08-16_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 clxscore=1011
 mlxscore=0 impostorscore=0 spamscore=0 mlxlogscore=999 priorityscore=1501
 bulkscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 adultscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2108170031
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>
>Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
>
>> usb_endpoint_maxp() only returns the bit[10:0] of wMaxPacketSize
>> of endpoint descriptor, not include bit[12:11] anymore, so use
>> usb_endpoint_maxp_mult() instead.
>>
>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>> ---
>>  drivers/usb/cdns3/cdnsp-mem.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/cdns3/cdnsp-mem.c b/drivers/usb/cdns3/cdnsp-mem=
.c
>> index a47948a1623f..ad9aee3f1e39 100644
>> --- a/drivers/usb/cdns3/cdnsp-mem.c
>> +++ b/drivers/usb/cdns3/cdnsp-mem.c
>> @@ -882,7 +882,7 @@ static u32 cdnsp_get_endpoint_max_burst(struct usb_g=
adget *g,
>>  	if (g->speed =3D=3D USB_SPEED_HIGH &&
>>  	    (usb_endpoint_xfer_isoc(pep->endpoint.desc) ||
>>  	     usb_endpoint_xfer_int(pep->endpoint.desc)))
>> -		return (usb_endpoint_maxp(pep->endpoint.desc) & 0x1800) >> 11;
>> +		return usb_endpoint_maxp_mult(pep->endpoint.desc) - 1;
>
>this looks like a bugfix. Do we need to Cc stable here?
>
>In any case:
>
>Acked-by: Felipe Balbi <balbi@kernel.org>
>

It's not a bugfix. The result is the same.

Acked-by: Pawel Laszczak <pawell@cadence.com>

--

Thanks=20
Pawel Laszczak