Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1222909pxb; Tue, 17 Aug 2021 06:47:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2sDCnyfM7nwMuXgtVynG2jIkRDHV5/Ul9Ezl+vofT8GY/b1T+H7ICJ93Kkzjj3LbnhC6G X-Received: by 2002:a17:906:9c84:: with SMTP id fj4mr4060928ejc.180.1629208031798; Tue, 17 Aug 2021 06:47:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629208031; cv=none; d=google.com; s=arc-20160816; b=SNrkZ2FBtUlNEk+TjwNA7SmMPn97UBWLT116XTXe5rNmrjo9PJUPLwWWFz99HvvZ53 g9/h2BTSHCgFD0pHTetgeCtNrxDNOQU5gylwkGPByexlOTYRW3dCdYPu/F4bFSPC2gym yT7fTK1FPqf9WXrTGlFiYXwJ2DJXj6ULoG6jZDBX9WSY8NxEG72iqlqvHIwTkf1uMx6x kgb5GXWcuXJ8+V67uRYTt5Nc/czQitKL20XveF40jfa77VD8TeB62EfxtX73PueCX5Dv oAAVNgci+XlEyqUGz+jYeT/vWG+c6EL6MEwWTtuEJ+49pW3DReLYvuPSY3hTgyb+ubzJ XkrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Zais18+ugxHihVBWa0fy7odBWQr2jMmEWUc1A3FeH2E=; b=sNp13RmVnHSrtMFjxypKiQZuddbwHUbws2bhVxMkAuyqRn356hh7Qy7xCgOSfs1kYz lfOnEp95ZAEYS8bAVImfaZsTKcwBejv+THjPTupaY/PIasZc38V5Nu+hfZwu4zSQsPnH YZjWGHu4RBGcD9HebItbJ5shZ0/bZ4vbd6tAIJiEgOGCf5i7yHvGmYzzYPnRyoTfT52q WFa69bC9D6vOSRVREJcvrxZemaYce8lfBUx71hyFToXedshR/or90bQbBohQxkSBA5/U MINhKSW5xudZcBc1HW8k7+ACiTlS5LnO5oxkyEoAzrX0+cxapzgYEoLIO4vPJwrH3+RL wM4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=heM0AeTn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e22si2518066edu.306.2021.08.17.06.46.47; Tue, 17 Aug 2021 06:47:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=heM0AeTn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240008AbhHQNpQ (ORCPT + 99 others); Tue, 17 Aug 2021 09:45:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:59796 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237090AbhHQNpP (ORCPT ); Tue, 17 Aug 2021 09:45:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 248F760EE0; Tue, 17 Aug 2021 13:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629207882; bh=Zg5d4qyDM5hnQQs3cqRGKAQdN63bOdqnEl33KOcoO18=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=heM0AeTnqC3y1Zn43MFukVCEDZwhWvMXAHSmRSGF7PqFS+OZctARMG8Bp1DlpWUiI sfa8UqDuZns0Pb1uoFD4qvdmH58xAnAHKLuAgTb5GwkbpYtd37tKXu8uWnlyLP2sob 4870uF1ypYyvG5W9bpPJt1FN3vaeQj2M07Ck9rF/bCOLHC/LmnnW6+c9fROt2kWyof 20EPf5+0MBj6zTuhygzVscc8rDgc71hIcpDEYHL4635cuE9qPm0zuUi11otMsRfAyp 12bT+Ano4QKeb6Q0IpawG3jErzy6U6O/83NcaAltr8rPbAzUHus9KQ2z86CwJowN4v vCRvEPkYPkKcg== Date: Tue, 17 Aug 2021 06:44:41 -0700 From: Jakub Kicinski To: Yajun Deng Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: net_namespace: Optimize the code Message-ID: <20210817064441.61133532@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210817102001.1125-1-yajun.deng@linux.dev> References: <20210817102001.1125-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Aug 2021 18:20:01 +0800 Yajun Deng wrote: > Inline ops_free(), becase there is only one caller. > Separate net_drop_ns() and net_free(), so the net_free() can be > called directly. > Add free_exit_list() helper function for free net_exit_list. > > Signed-off-by: Yajun Deng This patch does not apply, please rebase.