Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1226760pxb; Tue, 17 Aug 2021 06:52:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQEDp9we9UE1QK1jJlitogINfBZ9jiRSmMYtptZ07swAcCcru196hKCNVTi1U35aZh7rMS X-Received: by 2002:a5d:8784:: with SMTP id f4mr2981382ion.48.1629208337284; Tue, 17 Aug 2021 06:52:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629208337; cv=none; d=google.com; s=arc-20160816; b=0bmYKX1P1EQxJB6NTDAaMGXdhftrgS+bkoYIWa/YtZY//yzUGdgYt3oV1JD1kHwIuL YrzywY3JC4qSGhXgKI33R5brVC109OPnqGAujcqlk2V0R/15Ly7kbqG2cASL+SbRntui FrSVw7XLscDpva2IkxJ6DYNCKXRMnbZcRmBTSOZulVxEgpNLh89cRMiLNnXakE7Wuhiy fAw+dHJl6OSZZLD6JI9UKdmbLecoSDnqYYvpXZetXxLC299j+UwTqeMRmeRnEM8D5WYo QTgO9e3iSQ+0xVU+vQkvcok6odH4Zv2e+jJaPXEjirF/pbjA901jfOhxmYad3/5C8dnT Sbmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=cM5qYg9jHEHinqQQzo6rjtHIxDOHbda5DMWvY1YIHMg=; b=WUOcINfj1nuy+swRpY3M3pUVNCinN0wdSF1yMGkf0nPdL1NwenQ+cuaXI9Aiq96zq+ FvVReyuHETv00QnWpMDrBmDfwOxKkOjWCe5Zu3qzmWmblXgfiSHkwyAaaMN97kURL4Bc cW9XC77RpORRJ2tbo5AV0x+b9J2hjyMCcOESgg6MVJ7mIei70Xn19iFN8Gps6BBeimt2 BZ63ReGIhsE9QJ74kmIHLJZVhleqO+5GZsWtHtQeVupJHofuRUIuuFKEMbZ3tvVSPaXX GNoWrjWrvS/Oo/FG9OXQugrRfvfj/uO0E33IEXj+h+SRVukxdAuFqP1Ne46v6ASFCD4y 1NsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r25si2366903ioh.63.2021.08.17.06.52.05; Tue, 17 Aug 2021 06:52:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233731AbhHQNum (ORCPT + 99 others); Tue, 17 Aug 2021 09:50:42 -0400 Received: from mga17.intel.com ([192.55.52.151]:34571 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233288AbhHQNul (ORCPT ); Tue, 17 Aug 2021 09:50:41 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10079"; a="196354485" X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="196354485" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 06:50:08 -0700 X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="510479079" Received: from favalosr-mobl1.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.209.164.120]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 06:50:08 -0700 Subject: Re: [PATCH v5 01/12] x86/paravirt: Move halt paravirt calls under CONFIG_PARAVIRT To: Juergen Gross , Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Andy Lutomirski , Peter H Anvin , Dave Hansen , Tony Luck , Dan Williams , Andi Kleen , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , x86@kernel.org, linux-kernel@vger.kernel.org, Deep Shah , "VMware, Inc." References: <20210804181329.2899708-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210804181329.2899708-2-sathyanarayanan.kuppuswamy@linux.intel.com> <057170db-9382-eb40-7bcb-4ec1de4aae62@suse.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: Date: Tue, 17 Aug 2021 06:50:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/17/21 6:47 AM, Juergen Gross wrote: > I don't see a reason to have two "#include " lines in > one file. Why don't you use: > > #ifdef CONFIG_PARAVIRT > #include > #else > #ifndef __ASSEMBLY___ > ... > #endif > #endif > > #ifndef CONFIG_PARAVIRT_XXL > ... > #endif Ok. I will use your format. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer