Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1234419pxb; Tue, 17 Aug 2021 07:02:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbTFmGLqKK+RANIOjN5kNI1L+EEGo0nMNs89JGMQlNX60h4wSA1yPaCeH2bwgSPe2N20L8 X-Received: by 2002:a5d:96d2:: with SMTP id r18mr2939194iol.0.1629208950037; Tue, 17 Aug 2021 07:02:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629208950; cv=none; d=google.com; s=arc-20160816; b=I/URM13VWBkbf97Xlt0KqRbeZxrlQuw9Cz96bad1gOYHgNls3UTo8d2wA8jzSk3pek hu/tGcLIcvIqs85vFxpNX5xPuU0jokmHF9NtuJ9tYXIuF17rn7t6J1IqcW1nMPulzgwQ yCDLQattWolKvN5jXfBgAl/6wHpNBBdIanYb4e4pyAwlYOFFCg6Yj1rShb76dyH4e1oy F0A/e9FH6Xeh+Xg3xFs/C1MoTgr4hLmabN/kf8HLuc+TxOSjrjvYrR1igWtnHgj0OXbL vrDyePgZlxcNBcgQEMCZg1HwvA6lYhRqHkwK9QZCgenZcgcmtqtgg+IX6PP9J3yaaldw pCaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=NPnaF+LTrSceBVs95bD/wzeY7/SMGJn0KwU05EjRT1Q=; b=gnlMCcvLJc1ihuDo0ZU1G6sjCGue6GLZW2xspyOHDfqZrgLWC7EHuYqPA2+19zQP6P YLDtziufnbiNV+XwU1+l1PezHkl1oRlzF8aRFzAa4fxQVCa7WFfY96n9RVu/hknymACZ zg9sYs/niGmB+EVOvU3hD6dkw/9uGkWiiTMnPWsBeYEn9ICxPluQG7z+lnbD74q8tKHm RpLPZmpTWdyL3zy4Uy6eeYkL8glGNIaTYZcI6MAEk4ACGddqGEXLs44cEhY3xf2c9lh0 UgaL/Q7SGnWCWOY8PgkY85DMYjbLmS4RgnKTJQj7/U2IutLmXDvRw3e/0pVDA6CPpBx3 ihhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r4si2616262ilb.59.2021.08.17.07.02.17; Tue, 17 Aug 2021 07:02:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230360AbhHQOBq (ORCPT + 99 others); Tue, 17 Aug 2021 10:01:46 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:53788 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230208AbhHQOBp (ORCPT ); Tue, 17 Aug 2021 10:01:45 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: sre) with ESMTPSA id 6364F1F4320F Received: by earth.universe (Postfix, from userid 1000) id 1A2403C08DB; Tue, 17 Aug 2021 16:01:09 +0200 (CEST) Date: Tue, 17 Aug 2021 16:01:09 +0200 From: Sebastian Reichel To: Sebastian Krzyszkowiak Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@puri.sm Subject: Re: [PATCH 1/4] power: supply: max17042_battery: clean up MAX17055_V_empty Message-ID: <20210817140109.sp4sk7cqkxjrcmyf@earth.universe> References: <20210816165016.3153776-1-sebastian.krzyszkowiak@puri.sm> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="z6mpwaxoo7zhi7lb" Content-Disposition: inline In-Reply-To: <20210816165016.3153776-1-sebastian.krzyszkowiak@puri.sm> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --z6mpwaxoo7zhi7lb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Aug 16, 2021 at 06:50:13PM +0200, Sebastian Krzyszkowiak wrote: > This register is same as in MAX17047 and MAX17050, so there's no need > for custom casing it. >=20 > Signed-off-by: Sebastian Krzyszkowiak > --- Thanks, series queued. -- Sebastian > drivers/power/supply/max17042_battery.c | 4 ---- > include/linux/power/max17042_battery.h | 1 - > 2 files changed, 5 deletions(-) >=20 > diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supp= ly/max17042_battery.c > index c6078f179fb3..01e6728a9e2b 100644 > --- a/drivers/power/supply/max17042_battery.c > +++ b/drivers/power/supply/max17042_battery.c > @@ -283,8 +283,6 @@ static int max17042_get_property(struct power_supply = *psy, > case POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN: > if (chip->chip_type =3D=3D MAXIM_DEVICE_TYPE_MAX17042) > ret =3D regmap_read(map, MAX17042_V_empty, &data); > - else if (chip->chip_type =3D=3D MAXIM_DEVICE_TYPE_MAX17055) > - ret =3D regmap_read(map, MAX17055_V_empty, &data); > else > ret =3D regmap_read(map, MAX17047_V_empty, &data); > if (ret < 0) > @@ -778,8 +776,6 @@ static inline void max17042_override_por_values(struc= t max17042_chip *chip) > =20 > if (chip->chip_type =3D=3D MAXIM_DEVICE_TYPE_MAX17042) > max17042_override_por(map, MAX17042_V_empty, config->vempty); > - if (chip->chip_type =3D=3D MAXIM_DEVICE_TYPE_MAX17055) > - max17042_override_por(map, MAX17055_V_empty, config->vempty); > else > max17042_override_por(map, MAX17047_V_empty, config->vempty); > max17042_override_por(map, MAX17042_TempNom, config->temp_nom); > diff --git a/include/linux/power/max17042_battery.h b/include/linux/power= /max17042_battery.h > index d55c746ac56e..7e5da60cbea3 100644 > --- a/include/linux/power/max17042_battery.h > +++ b/include/linux/power/max17042_battery.h > @@ -113,7 +113,6 @@ enum max17042_register { > enum max17055_register { > MAX17055_QRes =3D 0x0C, > MAX17055_TTF =3D 0x20, > - MAX17055_V_empty =3D 0x3A, > MAX17055_TIMER =3D 0x3E, > MAX17055_USER_MEM =3D 0x40, > MAX17055_RGAIN =3D 0x42, > --=20 > 2.32.0 >=20 --z6mpwaxoo7zhi7lb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmEbwR4ACgkQ2O7X88g7 +ppD0g/+N5t8Og3doAgkCzV4Y+a6PfrLQCISpaT6ONuEUEaX/ugB6m6EhIlZfPYw +3rqKhc1Krl8YY5kE5KvQdsQusZ/CT07WwweJYVtdV7xd8iLX0DufNoVPI1E+2Cd fbkavXryxKLVsFXx8yDFaj5nkdU5E/zCfyTqHRlJT25H0WNWFWbfd6v7ppunpzRC kOQ3VBqz467M499lFcpyJIDPSaWhSEICJAuMgcRkK97Pey6DA1AjiconiLpWQxkR NujXXgiBpSBDSgXF87OmVBlS/qA3hMXB91kcdYd2yMaKSccBa84pbwOdt24oDhE4 ekSYPBOshRxIsH+VK4sJBkxRgburVUlYPjnK3vCNq6ZBQtX3BZT1vINP2MdkuMXz G2DWioREPp6W0IolC8Bk9zUQSJ8VFk9qd+7mzii2AShsFg9LL2T5rX9xgMLidkZB gJO35edtvxOTihaiSy/1X6yj/0gWBrNUpxkBaZ8lki92aRcTbLw5H7VqcxcZ5JJM Mhl3mx7IZ3Q+7CiXKNkN/DbAthUoxV7aGVZnBR+ptt7DS8/VunGhGbtLJ6ucGSoq jhevOMsDqr8PBz/9B7/gRWpEuhUnQjlvw1AAIFW+UWk8yUNpU2Dzcc5mP97Fsqpl ToT/OGJn+jEQhD5QmH+zV194cO4471P0XVNwCuBbtyoZU1hmAo4= =gfuG -----END PGP SIGNATURE----- --z6mpwaxoo7zhi7lb--