Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 17 Aug 2021 15:36:12 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Jianqun Xu <jay.xu@rock-chips.com>
Cc:     lgirdwood@gmail.com, ulf.hansson@linaro.org, lee.jones@linaro.org,
        zhangchangzhong@huawei.com, heiko@sntech.de,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] soc: rockchip: io-domain: do more thing about
 regulator notify
Message-ID: <20210817143612.GB4290@sirena.org.uk>
References: <20210817033848.1396749-1-jay.xu@rock-chips.com>
 <20210817033848.1396749-4-jay.xu@rock-chips.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cvVnyQ+4j833TQvp"
Content-Disposition: inline
In-Reply-To: <20210817033848.1396749-4-jay.xu@rock-chips.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--cvVnyQ+4j833TQvp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 17, 2021 at 11:38:48AM +0800, Jianqun Xu wrote:

> +	} else if (event & REGULATOR_EVENT_ENABLE) {
> +		uV = regulator_get_voltage(supply->reg);
>  	} else {

I am very surprised this doesn't cause locking issues given that we
might call notifiers with the regulator API's locks held.  Have you
tested this with lockdep on?

--cvVnyQ+4j833TQvp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmEbyVsACgkQJNaLcl1U
h9C7kQf/WvUxRsG7vyHPDAemRhQZrWNrsF6EfO3vzSfm14zPt8akTymLyEqjX0V2
qFvaGqTQRB9yM4M2akgoYNipieBTfBlqYaDsvFupJ5XmQ61T733R+LI34DytIsp1
RKkT6ZDZNG8FZkgbMZGhWUwFhjnVrvjAt7Q5eUkj9/BtoQLek4w7CUVOc03dFCmf
qUzxxrFz0OZGOweq5KjkCNBuQMcSXMAHKQGK3BKTzHv8KCNFFXO4dssFUM0CEAw1
hSekoRR6HnIyP9mMAGRtu3tp7VWQng4NWjrFOUJj2fy3b733uzsdmsNiCgC1ekKB
sMTfNZFkUWCFaW4+Bh6QPZ2CFApTdA==
=PMmT
-----END PGP SIGNATURE-----

--cvVnyQ+4j833TQvp--