Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210817080617.14503-1-krzysztof.kozlowski@canonical.com>
In-Reply-To: <20210817080617.14503-1-krzysztof.kozlowski@canonical.com>
From:   Markus Mayer <mmayer@broadcom.com>
Date:   Tue, 17 Aug 2021 07:59:08 -0700
Message-ID: <CAGt4E5t8oGcjw=q1UeKZcGk=XuYyw-=8LCMjxHDKgKLedd31hw@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: memory: convert Broadcom DPFE to dtschema
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Device Tree <devicetree@vger.kernel.org>,
        Linux ARM Kernel <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Thanks for updating this.

> +++ b/Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/memory-controllers/brcm,dpfe-cpu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: DDR PHY Front End (DPFE) for Broadcom STB
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> +  - Markus Mayer <mmayer@broadcom.com>
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - brcm,bcm7271-dpfe-cpu
> +          - brcm,bcm7268-dpfe-cpu
> +      - const: brcm,dpfe-cpu
> +
> +  reg:
> +    items:
> +      - description: DCPU register space
> +      - description: DCPU data memory space
> +      - description: DCPU instruction memory space
> +
> +  reg-names:
> +    items:
> +      - const: dpfe-cpu
> +      - const: dpfe-dmem
> +      - const: dpfe-imem
> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    dpfe-cpu@f1132000 {
> +        compatible = "brcm,bcm7271-dpfe-cpu", "brcm,dpfe-cpu";
> +        reg = <0xf1132000 0x180>,
> +              <0xf1134000 0x1000>,
> +              <0xf1138000 0x4000>;
> +        reg-names = "dpfe-cpu", "dpfe-dmem", "dpfe-imem";
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 36aee8517ab0..be8e4af8ed64 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3855,7 +3855,7 @@ M:        Markus Mayer <mmayer@broadcom.com>
>  M:     bcm-kernel-feedback-list@broadcom.com
>  L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>  S:     Maintained
> -F:     Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.txt
> +F:     Documentation/devicetree/bindings/memory-controllers/brcm,dpfe-cpu.yaml
>  F:     drivers/memory/brcmstb_dpfe.c
>
>  BROADCOM STB NAND FLASH DRIVER
> --
> 2.30.2
>

Acked-by: Markus Mayer <mmayer@broadcom.com>

Regards,
-Markus