Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>
Cc:     linux-nvme@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
Subject: SK hynix BC511: warning: nvme nvme0: missing or invalid SUBNQN field.
Message-ID: <67f74c8e-9d5e-22a1-f1c2-a4284b07ba56@molgen.mpg.de>
Date:   Tue, 17 Aug 2021 17:10:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Dear Linux folks,


On a Dell OptiPlex 7780 AIO/04G47W (BIOS 1.6.3 03/08/2021) Linux 5.10.47 
shows the warning below:

     $ dmesg | grep nvme
     [    3.015392] nvme 0000:02:00.0: platform quirk: setting simple 
suspend
     [    3.021861] nvme nvme0: pci function 0000:02:00.0
     [    3.026593] ahci 0000:00:17.0: version 3.0
     [    3.026922] ahci 0000:00:17.0: AHCI 0001.0301 32 slots 1 ports 6 
Gbps 0x1 impl SATA mode
     [    3.035020] ahci 0000:00:17.0: flags: 64bit ncq sntf pm clo only 
pio slum part ems deso sadm sds apst
     [    3.035219] nvme nvme0: missing or invalid SUBNQN field.
     [    3.044518] scsi host0: ahci
     [    3.051632] nvme nvme0: 12/0/0 default/read/poll queues
     [    3.052590] ata1: SATA max UDMA/133 abar m2048@0xd1339000 port 
0xd1339100 irq 125
     [    3.058538]  nvme0n1: p1 p2 p3

The disk model is:

     $ sudo ./nvme list
     Node                  SN                   Model 
                 Namespace Usage                      Format 
FW Rev
     --------------------- -------------------- 
---------------------------------------- --------- 
-------------------------- ---------------- --------
     nvme0n1               NY11N03531080183V    BC511 NVMe SK hynix 
512GB                1         512.11  GB / 512.11  GB    512   B +  0 B 
   11004101
     $ lspci -nn -s 2:00
     02:00.0 Non-Volatile memory controller [0108]: SK hynix Device 
[1c5c:1339]

Should it be added to the quirk list in `drivers/nvme/host/pci.c` or is 
it a real issues, the manufacturer should fix? If so, do you have SK 
Hynix contacts?


Kind regards,

Paul