Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1312768pxb; Tue, 17 Aug 2021 08:43:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1UAThb+xzI2MUF6/4lMM01IdKnub5rbemumz1p6cHxb0KMyhD9MY/c/hDEa4ZUPF7E0Ts X-Received: by 2002:a92:c90a:: with SMTP id t10mr2995707ilp.188.1629215035594; Tue, 17 Aug 2021 08:43:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629215035; cv=none; d=google.com; s=arc-20160816; b=bPs7WBwp0MLBtlWPhjp1YfsrFZyu/0aGodYTQ1NNNpMDwPWLsZ1zb+iI3x42Un9f3S h9f8Q23OdByDltgzZ3+uZ/MVvhpJCVgIvReDBm0LWPNuYpkCGRs9jnftIY/sPiZYXmds Mv4kAp2U570ZKKJm69cgHbtr/i3KdnPfb2BXBKS+i3MvixHsqeBbdBuUZIYtfvBTFhuR 4UhqK0BvwBqdrbTVMtK31tfH5ih59upqKDXtok7+zKlY/x8OtmAmGf5Ug4qNgU9MnYhO nVTKSB8J7OUW9/I5qIYe6RQBw6mfiZiFhn48KYokVV1YCnC5iPHl9IhKN4zb8lq9ysPF 3wNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-signature; bh=A9YvSBvAdkQ5Or8dySpWifyuVuQlz4bDIY5JTd0kN3s=; b=rb60YEmwwdehs0FHCiE5mVPKWROsaDlL6O4ZHNImc0J5H3ReQE7UQHpwDZ2Z1YUweO frmTNb3iRLgBeVT6G5fAi02vb3QoaCGbXynhxclIgtxDD8WH4lC6T0Yg/JDBSI1RYY4j l0Kl5teN+wuoIQymmzlulbXUujxek4NsqtQomE612Fn0OQI5rGSrQxVMwTUj+qK2p8BS M1VHnYK98fes+PkzUhDewqJeT4GfCjI63P9bXBnJLIy3c8zd0osf0rr7V/ycsupHNDkm k6ZOoCSZzhsVc5lr4BSkz4GqU7jeLqpKgtWlSwfWRyBp9bEbA4DurHXscbxD8shr1eTA Aa7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=k8mG3aJA; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b1si2505110ilj.117.2021.08.17.08.43.41; Tue, 17 Aug 2021 08:43:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=k8mG3aJA; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233372AbhHQPnK (ORCPT + 99 others); Tue, 17 Aug 2021 11:43:10 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:58642 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230369AbhHQPnK (ORCPT ); Tue, 17 Aug 2021 11:43:10 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 223A521E5D; Tue, 17 Aug 2021 15:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1629214956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A9YvSBvAdkQ5Or8dySpWifyuVuQlz4bDIY5JTd0kN3s=; b=k8mG3aJANSRlhBJBMZ05SXTGsPAcT2Xs6NxqQdGO/rvT3MCKRSCT+YLCdLgroQayBBu6Zp zC0nYmwhy+wzP4cS8arHwa636oTw7qLufsftmgK+LuCRjssLX6ud/5cIux+opKkkkWB2/2 xqDqKRB9MkoXa+VzRqB7m0k50XyEiRk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1629214956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A9YvSBvAdkQ5Or8dySpWifyuVuQlz4bDIY5JTd0kN3s=; b=HbQQcq7uS4IMaUCxFYfKzb1a2hlHvJbjBi/2dNjDbORF4XQRS+ksNBlcWgDB5vvzYoc6sU y+PPsbzrMyVu31Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 68A6E13E05; Tue, 17 Aug 2021 15:42:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Vvn9FevYG2HCTgAAMHmgww (envelope-from ); Tue, 17 Aug 2021 15:42:35 +0000 Subject: Re: [PATCH v4 35/35] mm, slub: convert kmem_cpu_slab protection to local_lock To: Sebastian Andrzej Siewior Cc: Andrew Morton , Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Galbraith , Thomas Gleixner , Mel Gorman , Jesper Dangaard Brouer , Jann Horn References: <20210805152000.12817-1-vbabka@suse.cz> <20210805152000.12817-36-vbabka@suse.cz> <20210817153937.hxnuh7mqp6vuiyws@linutronix.de> From: Vlastimil Babka Message-ID: <0120f82e-9251-9597-442f-8c582134a0d1@suse.cz> Date: Tue, 17 Aug 2021 17:41:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210817153937.hxnuh7mqp6vuiyws@linutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/17/21 5:39 PM, Sebastian Andrzej Siewior wrote: > On 2021-08-05 17:20:00 [+0200], Vlastimil Babka wrote: >> @@ -2849,7 +2891,11 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, >> >> load_freelist: >> >> - lockdep_assert_irqs_disabled(); >> +#ifdef CONFIG_PREEMPT_RT >> + lockdep_assert_held(this_cpu_ptr(&s->cpu_slab->lock.lock)); >> +#else >> + lockdep_assert_held(this_cpu_ptr(&s->cpu_slab->lock)); >> +#endif > > Could you please make this hunk only > > lockdep_assert_held(this_cpu_ptr(&s->cpu_slab->lock)); > > i.e. the non-RT version? Does it mean that version works fine on RT now? >> /* >> * freelist is pointing to the list of objects to be used. > > > Sebastian >