Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Yavuz, Tuba" <tuba@ece.ufl.edu>
To:     Salvatore Bonaccorso <carnil@debian.org>,
        Greg KH <gregkh@linuxfoundation.org>
CC:     David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "oneukum@suse.com" <oneukum@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v2] net: hso: do not call unregister if not registered
Thread-Topic: [PATCH v2] net: hso: do not call unregister if not registered
Thread-Index: AQHWmLFJUXxOb9bp30CoMp3KZfB8UamGkWoAgAB5N4CB8JquAIACH8ms
Date:   Tue, 17 Aug 2021 15:19:57 +0000
Message-ID: <BN6PR2201MB173238B760C0E5B72428E2CF90FE9@BN6PR2201MB1732.namprd22.prod.outlook.com>
References: <20201002114323.GA3296553@kroah.com>
 <20201003.170042.489590204097552946.davem@davemloft.net>
 <20201004071433.GA212114@kroah.com> <YRoLSvowhZsyKbOk@eldamar.lan>
In-Reply-To: <YRoLSvowhZsyKbOk@eldamar.lan>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o0QbKzFF6Yl/aaGBUmQgypAM+VgoCvZoxnMKS3IrMNV6ZC5waqAklzPtRdB0?=
 =?us-ascii?Q?ag4u0PK//1nb2XNFegYegY5pq7zTfB3c8iej87hwtBdCpEeGJRw6KXr2NpEQ?=
 =?us-ascii?Q?yfQF/PJhVqGQcUHT/9HXviKPfDh5DEXKD69wAbb0j4pHZejl6Cx8oEmvFpeL?=
 =?us-ascii?Q?XZbLHWWvSrZZ9elz1XvPLjyhP/fkcz4L0udpyWJk3Nf0nDNlADnichlYInEy?=
 =?us-ascii?Q?PZ0J+w5wdplCyuFMLZYpggGVAi5LFZctA0avG0ookG9xtqLdvV3q6ZSiO50E?=
 =?us-ascii?Q?UpUbNydaDVbnhheE9We37HKyq3Yvymygkqc0IVVxtyJ4D28Z0lgrEBeUWzi2?=
 =?us-ascii?Q?mu66iCZMTMjwktFReeWHVHI58fKWQrx+XD6w83ZmkpKURMO3un4SMSIXuuKf?=
 =?us-ascii?Q?GSu75ORM0qe0uZVjHUHNvXDLhnmPv7pniAxVpxLubK3CS0TFbEg8PqOVFbpm?=
 =?us-ascii?Q?nLPCnb80MA/sWYCPriUtz6mLMPp/koaRH2Q5gLEQB8FKwwH9QZ83oijWY9Z7?=
 =?us-ascii?Q?NJ/Zh+OxSxRP6EE/rZVyopnNPDZuGjyBCgGEEsIKYXwkXsrL+vCLm6tPu8de?=
 =?us-ascii?Q?7aA4WsclOlLYTBZmwoFCPO22Qz0bQuGj3h/Y9Sk9umBaDdkGh1MUOGDltBtC?=
 =?us-ascii?Q?ZyufJJhCTCfdXICCKr5OySt47hHl4QbRjViiFWLlPyRoKmwCd85IXtFiYZjW?=
 =?us-ascii?Q?O9K8CbyxtbjsSLWmdI6gRMkycUMygdkd7K4McdxcjphFaCYdGBOcssLrvCyo?=
 =?us-ascii?Q?OF2ABL/I6U5ZgNWPAqroQJx8x5/3oTjmYL8tclKZgE4Ol4VUuCyRGIR5umK5?=
 =?us-ascii?Q?77Cx+2JOdJzcGibMY/XS6tiqy0gdRVdo3Go///oEB9BEXktFeMZFPXNq7j6f?=
 =?us-ascii?Q?kZTpx1yhGtBxLB6GsrpZp7b0P7EXraALD+5wZV2blz6+/fmJjb2ZxNjDU0wt?=
 =?us-ascii?Q?AzmS9Wz4LQw/rmKVK2qYjEfZgb84z4xMnHO5uab688X2ACyannfRfrEuJxm8?=
 =?us-ascii?Q?yOxGOBdvSKrE1lusiP6i8VVaKBsGjCOCzaFuG/Ktoy316AipNFQYrousIEM+?=
 =?us-ascii?Q?cxkE2IS/Zr88QLixrIBwfXjzahAGgAJw4Wtr27XHleiXmgN62GSF0pLr9Ni7?=
 =?us-ascii?Q?2gKRtJL8s1k+37CmjLo00TlycP6g0rbMLQ4KT3rwUF7hkv2Wg89PpA6uzKq/?=
 =?us-ascii?Q?bDkemqGcYEcy3LWJws1S1rEsd+fLzMPrOpclk+EMEXgFUajIZEleWpn/aLQ7?=
 =?us-ascii?Q?rgMWZWHD+WlzxLZxVVNJ+wt68AaDzjaPJWZLh8jCB4IS6YFomW9bs3Lao3JH?=
 =?us-ascii?Q?RNY=3D?=
x-ms-exchange-transport-forked: True
arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FrEFPh++bz7oGoLb83vruzwY1zgho2Mt2BBi0TmcFLV6j/TWpABPehNaNSxJXcIzsvHPFOdp6YAIsyFBataYOzI4wdrrKlFrfRZqOqd8L9xAE0ynbQyAHHAN9rwqYIq409Xwfd8smutD0OO+iQk8ZUKyRd7ClbZlF2k2Cef3/ADqGWgUN8xcYWzNewZb+/4576Vvnb6w7zG2vjUeMi+HxSs3Q+Qgogihka9uHDgaKljeDostL0MKvlpG+D9XyOG5E2eiSRZxS8L745nlRG7T1TbKSJl4niLB/xXV/PlVDKwYBX5z9Ln91O7JzSjJfnbYGbb0CdB1RgVdyBTPuuDkRw==
arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8Yyrcuez/HhEhxtbT5WrlnITeKRUtz5TWe3syI3ERE4=;
 b=DmyJ3cF5vPS86xeDqDnD/nXniGrnphThK8WEHOZEfcZJ+TG396CtEqb9Kyk38Xe7y6qUB9Tkp4T7CmQqJhD1nm7RrflfIXOiOwfEWEhpUa6q8IMuPSQf+cGRk18veFivIPO0n8em+1xv4U6G1Dyv5/t9wXp2rYF6a9/ejBpiGmWMVkWHlz8tLF/yOyXo9fs9u2czAasAIJWXDpdx+vYcr8Erlm0JNkqSRwejxiFLqkhnQyQvBdlr7KaN17rIya0vTDw8dtwsXAsnG52m4xD1DJYIPwvDwJqjHzAZa4WLdVRHID4EIuGnvIZj97HLLp9SpwHoAzlJbikgv+0MiWEdTw==
arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=ece.ufl.edu; dmarc=pass action=none header.from=ece.ufl.edu;
 dkim=pass header.d=ece.ufl.edu; arc=none
x-ms-exchange-crosstenant-authas: Internal
x-ms-exchange-crosstenant-authsource: BN6PR2201MB1732.namprd22.prod.outlook.com
x-ms-exchange-crosstenant-network-message-id: d12a8c02-8ace-447b-6f5f-08d961927997
x-ms-exchange-crosstenant-originalarrivaltime: 17 Aug 2021 15:19:58.0444 (UTC)
x-ms-exchange-crosstenant-fromentityheader: Hosted
x-ms-exchange-crosstenant-id: 0d4da0f8-4a31-4d76-ace6-0a62331e1b84
x-ms-exchange-crosstenant-mailboxtype: HOSTED
x-ms-exchange-crosstenant-userprincipalname: m9aCYVoNt6ZDLai5xDec8pNhiRErtDQCo/mBtt6ShzuxickN4v6YMb+lRe5RhiuZ
x-ms-exchange-transport-crosstenantheadersstamped: BN6PR2201MB1266
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-OriginatorOrg: ece.ufl.edu
X-Proofpoint-ORIG-GUID: lXqRPhaojZffiZKC4xR59Jt_jFTitYt7
X-Proofpoint-GUID: lXqRPhaojZffiZKC4xR59Jt_jFTitYt7
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-08-17_05:2021-08-17,2021-08-17 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=999
 lowpriorityscore=0 adultscore=0 spamscore=0 phishscore=0
 priorityscore=1501 suspectscore=0 malwarescore=0 bulkscore=0
 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2108170094
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Salvatore,

I think it would be best if one of the developers of the hso driver could develop a patch along the lines of David Miller's earlier suggestion.

Best,

Tuba

________________________________________
From: Salvatore Bonaccorso <salvatore.bonaccorso@gmail.com> on behalf of Salvatore Bonaccorso <carnil@debian.org>
Sent: Monday, August 16, 2021 2:52 AM
To: Greg KH
Cc: David Miller; Yavuz, Tuba; netdev@vger.kernel.org; kuba@kernel.org; oneukum@suse.com; linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] net: hso: do not call unregister if not registered

[External Email]

Hi Greg, Tuba,

On Sun, Oct 04, 2020 at 09:14:33AM +0200, Greg KH wrote:
> On Sat, Oct 03, 2020 at 05:00:42PM -0700, David Miller wrote:
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Date: Fri, 2 Oct 2020 13:43:23 +0200
> >
> > > @@ -2366,7 +2366,8 @@ static void hso_free_net_device(struct hso_device *hso_dev, bool bailout)
> > >
> > >   remove_net_device(hso_net->parent);
> > >
> > > - if (hso_net->net)
> > > + if (hso_net->net &&
> > > +     hso_net->net->reg_state == NETREG_REGISTERED)
> > >           unregister_netdev(hso_net->net);
> > >
> > >   /* start freeing */
> >
> > I really want to get out of the habit of drivers testing the internal
> > netdev registration state to make decisions.
> >
> > Instead, please track this internally.  You know if you registered the
> > device or not, therefore use that to control whether you try to
> > unregister it or not.
>
> Fair enough.  Tuba, do you want to fix this up in this way, or do you
> recommend that someone else do it?

Do I miss something, or did that possibly fall through the cracks?

I was checking some open issues on a downstream distro side and found
htat this thread did not got a follow-up.

Regards,
Salvatore