Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 17 Aug 2021 20:38:44 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Utkarsh Verma <utkarshverma294@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Valmer Huhn <valmer.huhn@concurrent-rt.com>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] serial: 8250_exar: Add missing call to
 pci_free_irq_vectors()
Message-ID: <YRv0JO64HRHrl7Gb@smile.fi.intel.com>
References: <20210817170057.16783-1-utkarshverma294@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210817170057.16783-1-utkarshverma294@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Aug 17, 2021 at 10:30:57PM +0530, Utkarsh Verma wrote:
> Free the pci irq vectors if the call to pci_alloc_irq_vectors() fails
> or if the device is removed.

...

>  	rc = pci_alloc_irq_vectors(pcidev, 1, 1, PCI_IRQ_ALL_TYPES);
> -	if (rc < 0)
> +	if (rc < 0) {

> +		pci_free_irq_vectors(pcidev);

Why?

-- 
With Best Regards,
Andy Shevchenko