Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp1398678pxb; Tue, 17 Aug 2021 10:41:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzXzK1j/IVgOFGKePNnS8SNA5Yl7lOtuMPGSpIdwa7lMIKOMY5lCndcjYKR49vyO6eyYIu X-Received: by 2002:a17:906:49d5:: with SMTP id w21mr5220981ejv.30.1629222070414; Tue, 17 Aug 2021 10:41:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629222070; cv=none; d=google.com; s=arc-20160816; b=AGIJhRuJPMKH0w8X2a1Z3P7kDzy8Gc5HMhMT+v1qf9c2+YgGZN/2t3DzmTh1r/xf4e X4ZcPX7tvxcK3SUvYmIMoPujoWQcNEGhNspvjXMRa9Zrcbw8+dJvGy1bVG7ULSPtoo+8 vKMWNtRU/k1MZFrl7USkjrH1yywtrSLwUnnlsE6G6zuuLUDIOXITqJiChiXvzqk3kwbo U6R5Xz3mO3R+ahBbPIg2T+U/rfWM6Nyv3A7ssDrOM+xpaZwZGsQWhmw+b4V9QSP5YtDa cc0FtzCx9/wCWXC/G84r5+btUh0Qx2oOL6RG7zwGeeIC8bN3D9+r9AaD/zQDiYqn9L5a nk3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=NRgmL1aiA/eVecFqEiiqUPwEzDbhFJV+XZygKn5sbvM=; b=w1Ah0OxTE/t9NK/BmSGhvpye96AGHvIbDzwi13BrqPAQivl5XXgo20Gont7kNEBbGR UZMRgJNrUC1q5G8t7xY8Yx4DDS+HAJJ6eqm4csVx6lx6tDC/uKUDB04SoXV4shtLubzf zjogK0hixDZiNqFUBDes8nheE1dOHxj2vqrv6r3MhBhxtPbUiR+f3092m/FN1BWWE7Vs orrmruSSOKUPyz8wBjgM7fM1ajMT70oSd3bV8Y1Xic8e6/S33gmm09b0YLWBf2FeU5vJ he27lRFj6B/qIF4DJqlLFW5f53RPz9bfkGsddN6OX/PhIxuoITucgkIksnp1BOdrBN+k XrYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m24si2968351ejd.38.2021.08.17.10.40.47; Tue, 17 Aug 2021 10:41:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229969AbhHQRjd (ORCPT + 99 others); Tue, 17 Aug 2021 13:39:33 -0400 Received: from mga04.intel.com ([192.55.52.120]:2277 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232256AbhHQRj1 (ORCPT ); Tue, 17 Aug 2021 13:39:27 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10079"; a="214307359" X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="214307359" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 10:38:53 -0700 X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="676598040" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 10:38:51 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mG32y-00ApCu-WF; Tue, 17 Aug 2021 20:38:45 +0300 Date: Tue, 17 Aug 2021 20:38:44 +0300 From: Andy Shevchenko To: Utkarsh Verma Cc: Greg Kroah-Hartman , Jiri Slaby , Heikki Krogerus , Valmer Huhn , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH] serial: 8250_exar: Add missing call to pci_free_irq_vectors() Message-ID: References: <20210817170057.16783-1-utkarshverma294@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210817170057.16783-1-utkarshverma294@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 17, 2021 at 10:30:57PM +0530, Utkarsh Verma wrote: > Free the pci irq vectors if the call to pci_alloc_irq_vectors() fails > or if the device is removed. ... > rc = pci_alloc_irq_vectors(pcidev, 1, 1, PCI_IRQ_ALL_TYPES); > - if (rc < 0) > + if (rc < 0) { > + pci_free_irq_vectors(pcidev); Why? -- With Best Regards, Andy Shevchenko