Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 5.10 12/19] vboxsf: Make vboxsf_dir_create() return the
 handle for the created file
To:     Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc:     Pavel Machek <pavel@ucw.cz>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Stable <stable@vger.kernel.org>
References: <20210813150522.623322501@linuxfoundation.org>
 <20210813150523.032839314@linuxfoundation.org>
 <20210813193158.GA21328@duo.ucw.cz>
 <26feedff-0fb4-01db-c809-81c932336b47@redhat.com>
 <CADVatmNm83ZdwJzMzZSEF-SPjSV4OmjByLpnYAubZSkY7f9uMw@mail.gmail.com>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <758b95b1-382a-4831-d562-e46837b61534@redhat.com>
Date:   Tue, 17 Aug 2021 20:21:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <CADVatmNm83ZdwJzMzZSEF-SPjSV4OmjByLpnYAubZSkY7f9uMw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 8/17/21 5:52 PM, Sudip Mukherjee wrote:
> On Sun, Aug 15, 2021 at 2:57 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Hi,
>>
>> On 8/13/21 9:31 PM, Pavel Machek wrote:
>>> Hi!
>>>
>>>> commit ab0c29687bc7a890d1a86ac376b0b0fd78b2d9b6 upstream
>>>>
>>>> Make vboxsf_dir_create() optionally return the vboxsf-handle for
>>>> the created file. This is a preparation patch for adding atomic_open
>>>> support.
>>>
>>> Follow up commits using this functionality are in 5.13 but not in
>>> 5.10, so I believe we don't need this in 5.10, either?
>>>
>>> (Plus someone familiar with the code should check if we need "vboxsf:
>>> Honor excl flag to the dir-inode create op" in 5.10; it may have same
>>> problem).
>>
>> Actually those follow up commits fix an actual bug, so I was expecting
>> the person who did the backport to also submit the rest of the set.
> 
> I only track Greg's failed messages when I find time for stable and
> this one was one of those. So, no idea who has originally requested
> this and why were the other two not requested.

I understand, thank you for backporting the 2 failing commits.

Regards,

Hans