Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 17 Aug 2021 21:55:51 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc:     linux-can@vger.kernel.org,
        Stefan =?utf-8?B?TcOkdGpl?= <Stefan.Maetje@esd.eu>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 5/7] can: netlink: add interface for CAN-FD
 Transmitter Delay Compensation (TDC)
Message-ID: <20210817195551.wwgu7dnhb6qyvo7n@pengutronix.de>
References: <20210815033248.98111-1-mailhol.vincent@wanadoo.fr>
 <20210815033248.98111-6-mailhol.vincent@wanadoo.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="femi54sv3tzgjgry"
Content-Disposition: inline
In-Reply-To: <20210815033248.98111-6-mailhol.vincent@wanadoo.fr>
Precedence: bulk


--femi54sv3tzgjgry
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 15.08.2021 12:32:46, Vincent Mailhol wrote:
> +static int can_tdc_changelink(struct net_device *dev, const struct nlatt=
r *nla,
> +			      struct netlink_ext_ack *extack)
> +{
> +	struct nlattr *tb_tdc[IFLA_CAN_TDC_MAX + 1];
> +	struct can_priv *priv =3D netdev_priv(dev);
> +	struct can_tdc *tdc =3D &priv->tdc;
> +	const struct can_tdc_const *tdc_const =3D priv->tdc_const;
> +	int err;
> +
> +	if (!tdc_const || !can_tdc_is_enabled(priv))
> +		return -EOPNOTSUPP;
> +
> +	if (dev->flags & IFF_UP)
> +		return -EBUSY;
> +
> +	err =3D nla_parse_nested(tb_tdc, IFLA_CAN_TDC_MAX, nla,
> +			       can_tdc_policy, extack);
> +	if (err)
> +		return err;
> +
> +	if (tb_tdc[IFLA_CAN_TDC_TDCV]) {
> +		u32 tdcv =3D nla_get_u32(tb_tdc[IFLA_CAN_TDC_TDCV]);
> +
> +		if (tdcv < tdc_const->tdcv_min || tdcv > tdc_const->tdcv_max)
> +			return -EINVAL;
> +
> +		tdc->tdcv =3D tdcv;

You have to assign to a temporary struct first, and set the priv->tdc
after complete validation, otherwise you end up with inconsistent
values.

> +	}
> +
> +	if (tb_tdc[IFLA_CAN_TDC_TDCO]) {
> +		u32 tdco =3D nla_get_u32(tb_tdc[IFLA_CAN_TDC_TDCO]);
> +
> +		if (tdco < tdc_const->tdco_min || tdco > tdc_const->tdco_max)
> +			return -EINVAL;
> +
> +		tdc->tdco =3D tdco;
> +	}
> +
> +	if (tb_tdc[IFLA_CAN_TDC_TDCF]) {
> +		u32 tdcf =3D nla_get_u32(tb_tdc[IFLA_CAN_TDC_TDCF]);
> +
> +		if (tdcf < tdc_const->tdcf_min || tdcf > tdc_const->tdcf_max)
> +			return -EINVAL;
> +
> +		tdc->tdcf =3D tdcf;
> +	}
> +
> +	return 0;
> +}

To reproduce (ip pseudo-code only :D ):

ip down
ip up tdc-mode manual tdco 111 tdcv 33  # 111 is out of range, 33 is valid
ip down
ip up                                   # results in tdco=3D0 tdcv=3D33 mod=
e=3Dmanual

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--femi54sv3tzgjgry
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmEcFEUACgkQqclaivrt
76nN1ggAr4yOd2SysaDbW1q1G/J0QK6Q8Seymr9AqJ4CpYspWe/iEEipRUQIDmBz
5iiSt/NnFqMh9wyxL2gmawzZQA9gwv82r+dfFI+3zW4OdEoO+Qw6Z1PNwGB/EDTa
9FOWJvb+8aE5cdiF47Yl7l4geUWqq2mxeAJ1ULEFqkmNBkmr4WuYIIQWroycl4z6
O8wG1H//MuoMnCUr7TzKl4jiuwSIamcUhGfmsAzJ8LVPNhoVmg1VQ7acghUhEf8c
Iet9QLefSIcsuJ2Nfx5FUYlJ4SL5h65ZYZdAYcgRCip2d/J50gS7wEMznqO32LVp
vh36Inpa5enOTjJvOPo/HXTCtlpAxw==
=zn8F
-----END PGP SIGNATURE-----

--femi54sv3tzgjgry--