Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp4275pxb; Tue, 17 Aug 2021 17:33:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxw5LlCnPHOUtOVSlaRLpf6wLNzAwcb2t0YGCBqK3xMCaNybmDwWGqcde54B8ZeB2S0iEtm X-Received: by 2002:a02:cbb0:: with SMTP id v16mr5424505jap.114.1629246807931; Tue, 17 Aug 2021 17:33:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629246807; cv=none; d=google.com; s=arc-20160816; b=InMSLqsOEeJklNzepsmzbbTOtTvPEQrGjWy7wsEz5FOYwajrxKKEj/2oqnW7jnd9LQ xDxAt4oJZmEmuqooI5LskcRiPH2iy5wHzMtPylTw8rOq7lJJDBtZAqlR5lGUSC1SZ7IE 9O5pEchEI0j95MOImBsehZLxpw1b6HspYVH2YxqhwWVR4BgX/OdoPGOObv4rjM7zaZZy u+Nwpt20vWfOnEgv5HeZecr5Ga5dRJKznuHqBTxNuznQzzGns/tglDUAoKmRVy4fakF3 Xw/gTDQsbpwk2qR1g2juh9/fEOAHqG/oJtEzufLdnyklx6OGHE/q8UWYtl5eWqdWh2s6 6tlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=OwKoMpKsJfYGuAd5+UrIcHs7Dv7p+8pKzbl1xu55fyE=; b=FOMyJt/OPx3uKM/PN4aGMa04mUcStDHTQNMCDDfP2qAz9GZIiGi0zj6RycuhYoZwcY GG75UziwNuLJmgs393JEnH1oMGPvWfuoIRdbFMosFxohEnfhbL4hVjtIOZ7dKxr/ld/l 5QjSIT400T3b1aVIS+RuNr2nqJ0QBAJHCTyD7jx2zX5F28CrPS9vsBMsTyFLDd46DW1p OhlFEkTqMC/5buH8FVROuwbyEVaJrv62QMhWUIXysyegS7lQ6l65rLAFwZwBYnYa4Vnh +l5Go7kccBCD6GYmShSEUDKc1N5VjCisd6HW2B3YwRg+PnAMY4J9iZo1q1FrsNP61FqQ CxYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cjr.nz header.s=dkim header.b=nbJ9B3FX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=cjr.nz Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q17si3930039ilj.42.2021.08.17.17.33.16; Tue, 17 Aug 2021 17:33:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cjr.nz header.s=dkim header.b=nbJ9B3FX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=cjr.nz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237268AbhHRAbA (ORCPT + 99 others); Tue, 17 Aug 2021 20:31:00 -0400 Received: from mx.cjr.nz ([51.158.111.142]:21628 "EHLO mx.cjr.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234870AbhHRAa7 (ORCPT ); Tue, 17 Aug 2021 20:30:59 -0400 Received: from authenticated-user (mx.cjr.nz [51.158.111.142]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pc) by mx.cjr.nz (Postfix) with ESMTPSA id 3D024818D6; Wed, 18 Aug 2021 00:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjr.nz; s=dkim; t=1629246623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OwKoMpKsJfYGuAd5+UrIcHs7Dv7p+8pKzbl1xu55fyE=; b=nbJ9B3FXUUeED1pR2AuA+whx4RTm4MTvkBkk3TZRcgqwiSWtTlq5FuettUxXJN2b01es56 2PPUYEJ6pZtdSdA9dWjpKm6nvrMcYmZfH8LXq1X+OiPeoTfbilWfKyMsb8WhbFqPFJJ9f/ YJ/GBiVrJ8abARaqd5IAtuT0+zkDwK+Z2Jv8OOBM6l3GJA++rNNaxBseyGiCou9m5sBu1o MTq/vgJfDT1h8uAX67xwLvMBSyN6LSyQzUE1xqbUKzndceHAQe60CZYRYGHKRINFN7y/GP VNJpSB7Ryg+87uup72keukwqsQD7ENhF5GQFAoifNJzCFV+mKkqEaYVR5YY2UA== From: Paulo Alcantara To: Ding Hui , sfrench@samba.org Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, Ding Hui Subject: Re: [PATCH] cifs: fix wrong release in sess_alloc_buffer() failed path In-Reply-To: <20210817145510.639-1-dinghui@sangfor.com.cn> References: <20210817145510.639-1-dinghui@sangfor.com.cn> Date: Tue, 17 Aug 2021 21:30:17 -0300 Message-ID: <87fsv7h9wm.fsf@cjr.nz> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ding Hui writes: > smb_buf is allocated by small_smb_init_no_tc(), and buf type is > CIFS_SMALL_BUFFER, so we should use cifs_small_buf_release() to > release it in failed path. > > Signed-off-by: Ding Hui > --- > fs/cifs/sess.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Paulo Alcantara (SUSE)