Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 17 Aug 2021 20:18:54 -0500
From:   Rob Herring <robh@kernel.org>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Wolfgang Grandegger <wg@grandegger.com>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de,
        David Jander <david@protonic.nl>
Subject: Re: [PATCH v2 1/3] dt-bindings: can-controller: add support for
 termination-gpios
Message-ID: <YRxf/gKvS3o+hq1/@robh.at.kernel.org>
References: <20210817041306.25185-1-o.rempel@pengutronix.de>
 <20210817041306.25185-2-o.rempel@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210817041306.25185-2-o.rempel@pengutronix.de>
Precedence: bulk

On Tue, Aug 17, 2021 at 06:13:04AM +0200, Oleksij Rempel wrote:
> Some boards provide GPIO controllable termination resistor. Provide
> binding to make use of it.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  .../devicetree/bindings/net/can/can-controller.yaml      | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/can-controller.yaml b/Documentation/devicetree/bindings/net/can/can-controller.yaml
> index 9cf2ae097156..298ce69a8208 100644
> --- a/Documentation/devicetree/bindings/net/can/can-controller.yaml
> +++ b/Documentation/devicetree/bindings/net/can/can-controller.yaml
> @@ -13,6 +13,15 @@ properties:
>    $nodename:
>      pattern: "^can(@.*)?$"
>  
> +  termination-gpios:
> +    description: GPIO pin to enable CAN bus termination.

maxItems: 1

> +
> +  termination-ohms:
> +    description: The resistance value of the CAN bus termination resistor.
> +    $ref: /schemas/types.yaml#/definitions/uint16-array

Standard unit properties already have a type and are uint32.

> +    minimum: 1
> +    maximum: 65535
> +
>  additionalProperties: true
>  
>  ...
> -- 
> 2.30.2
> 
>