Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210817145510.639-1-dinghui@sangfor.com.cn> <87fsv7h9wm.fsf@cjr.nz>
In-Reply-To: <87fsv7h9wm.fsf@cjr.nz>
From:   Steve French <smfrench@gmail.com>
Date:   Tue, 17 Aug 2021 21:46:12 -0500
Message-ID: <CAH2r5mvT115ikGHAtpoLmHSn9yJ16iJDexgdUCv32ZAL4+HNKA@mail.gmail.com>
Subject: Re: [PATCH] cifs: fix wrong release in sess_alloc_buffer() failed path
To:     Paulo Alcantara <pc@cjr.nz>
Cc:     Ding Hui <dinghui@sangfor.com.cn>,
        Steve French <sfrench@samba.org>,
        CIFS <linux-cifs@vger.kernel.org>,
        samba-technical <samba-technical@lists.samba.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

tentatively merged into cifs-2.6.git for-next pending more testing

On Tue, Aug 17, 2021 at 7:33 PM Paulo Alcantara <pc@cjr.nz> wrote:
>
> Ding Hui <dinghui@sangfor.com.cn> writes:
>
> > smb_buf is allocated by small_smb_init_no_tc(), and buf type is
> > CIFS_SMALL_BUFFER, so we should use cifs_small_buf_release() to
> > release it in failed path.
> >
> > Signed-off-by: Ding Hui <dinghui@sangfor.com.cn>
> > ---
> >  fs/cifs/sess.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>


-- 
Thanks,

Steve