Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 17 Aug 2021 20:18:01 -0700
From:   Roman Gushchin <guro@fb.com>
To:     Muchun Song <songmuchun@bytedance.com>
CC:     <hannes@cmpxchg.org>, <mhocko@kernel.org>,
        <akpm@linux-foundation.org>, <shakeelb@google.com>,
        <vdavydov.dev@gmail.com>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>, <duanxiongchun@bytedance.com>,
        <fam.zheng@bytedance.com>, <bsingharora@gmail.com>,
        <shy828301@gmail.com>, <alexs@kernel.org>, <smuchun@gmail.com>,
        <zhengqi.arch@bytedance.com>
Subject: Re: [PATCH v1 03/12] mm: memcontrol: make lruvec lock safe when LRU
 pages are reparented
Message-ID: <YRx76SlTkTT8a1BI@carbon.dhcp.thefacebook.com>
References: <20210814052519.86679-1-songmuchun@bytedance.com>
 <20210814052519.86679-4-songmuchun@bytedance.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20210814052519.86679-4-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.dhcp.thefacebook.com (2620:10d:c090:400::5:20bf) by MWHPR17CA0091.namprd17.prod.outlook.com (2603:10b6:300:c2::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Wed, 18 Aug 2021 03:18:04 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bc0011ef-d572-4b42-14a3-08d961f6cbaa
X-MS-TrafficTypeDiagnostic: BYAPR15MB3078:
X-Microsoft-Antispam-PRVS: <BYAPR15MB3078C52E7DC478E5479490CCBEFF9@BYAPR15MB3078.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +Lamfn8jKQT8bPA5ejQvVC4tH09jFbi0UvZB0chkSkKFhXq5iGwLxLCqG+A3ZnifyTYjvDslpQ9BlIIJNa3CxOuGJrIqj6NwwS7DGF0W3ZmZ7gOeL8xJFohLAWeoBVP5Pb/Uf1NF2ezcnaVbujxYdpNh7wJ0nYYlDZoofR93E8jv3wJsGL2zD3LwFGVgKaGiCkVKpu5mFOkXiOq0eNSMD4HXw2y2ljbUKm7Xg34yC2vSKvhB3UDFPSm495fOIpJP6z/S8T2wTmjll44tdK2eGBXfc8G+Eg8wgqcUB2hAJWS+fb7ygeakc0xfffFWxvpiklvIQ/0C3577ml11Oeu8BIFbYjUKznZbYHozFgXsZraYrfj1ClEx+KY4u3A0kQgKD6nDRdOqRgwY2TAMSJDRtK+yMXMx21xNnloPArL3vNz4egeHz55D0rCSxE/zqLwavk4P9WKdi6DHdloIYbcbvjOcT3tLrgvqCTG5wOUb/EenCI1TU1KjlwVBNTSOxAgdKJdQvXTUZsANk4nqe3FChOclN6eBpKnP3rjjK2gFYQTenNiecA/rBi6IY+4wjpCTfkMG3JI6fUnjzR+2c5ThpxILQ8NMKdJW+gs5OBT8qM3uA7DmLrnLOM5cy8EGvqXDn4duYXBQy7NnhPB7yCTaXA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(366004)(346002)(39860400002)(136003)(52116002)(8676002)(316002)(4326008)(6506007)(9686003)(7696005)(5660300002)(55016002)(6916009)(8936002)(478600001)(38100700002)(7416002)(2906002)(66946007)(86362001)(66476007)(66556008)(6666004)(83380400001)(186003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rJxcZ1AlRnlQdIppo6mNJkA/YP5cWxS+tCzlWlE3Tn1D2tyIwAvGpHGOazir?=
 =?us-ascii?Q?ztn7VHzL2CuBhm6Ya+xnPB97F7qlAUuMsAHho5GkzuA9KO5pP5P6qN+Mi0N/?=
 =?us-ascii?Q?KL1uSPNZQiX4CpQ0CQGx6ixDbT1E9powVCaOf3Iw4UdpwgQ1GMoPQKhy1N83?=
 =?us-ascii?Q?2U0qWXb1CmDFC+/9MYxAsHIZFLV1ca3qzCopebo/6IH/SCYeUS+2CjScjYpK?=
 =?us-ascii?Q?GC3LcyHOXUkLJATaM/+/SokFVajgNEheeDlYjK8NKMAke5wtIopmj8gvDehk?=
 =?us-ascii?Q?3mad4oojQ4SvOA1hzBDeGyuw3H1kKgzyvb5YkUQdGYKerDjtFyjEVW6OQZJu?=
 =?us-ascii?Q?QBVx/QZBzBSvX+COGlSCXF+2+MfsSFf//YB/R3qC+i5Tbgda+OW3y9iiVdqp?=
 =?us-ascii?Q?/nWBnSWvw5prtzTDOR7nc0o3Wvw1xiYoFSEeKuIWDNlCDq5a1QlEldvL+W/b?=
 =?us-ascii?Q?/2DD+tLNYn+aF04qjFcDTYi62C43LcadFeaGAZW7xTXwXCpMFn+z5wX/pkEE?=
 =?us-ascii?Q?+g/IpUOk916/T5srxqmzNDubo17DGahprW/7kDx18mKB3/b+wCYX/FJT+uQj?=
 =?us-ascii?Q?f+ZOekLX2F6w3qb2ToQTIVYzCIVuvHr8rBRrOrkGU66FY/kat4Y0UcFKyfz/?=
 =?us-ascii?Q?XvV/u/69IpwHFj/RPbWxKWumWdIP5VbXZZSn/DArFcVZ+ckw0gNRGrywNFJA?=
 =?us-ascii?Q?Fhg7dQteyXt6g1VJw3drY/zJXNnRpEIpzVv6bFfmdAk36Ps8Trd85tCBlO8e?=
 =?us-ascii?Q?IEd4nta4piv1QB5fS6aXWyE6DV4hSNig6FU8NgRuxDYiiCJ1Q/67Ccr55M3n?=
 =?us-ascii?Q?Va+lzaPHica9b6LERangn1FAWP4iZ27GKkHoRsSi8lK33NeS0R3arzlvamQR?=
 =?us-ascii?Q?rOUowbCwHvfl9hbR0WnZ4RKEYgCHndOnv9vr55/53bSwRCHWFz6jCtt6rBmH?=
 =?us-ascii?Q?CO4DMaekaWR+JQn0SB5vKHc6JeiZ7IAMLaIDHb3m4QFjOWqD1f7w2vw2H37t?=
 =?us-ascii?Q?QgvdImm6DEQXHDJOPr1jMbz93M0dBS/HFBmdL7oCGEGXexVQDDH1EXUSaKOK?=
 =?us-ascii?Q?ouD1rJRaqwBEIg2/fAojEb2tfs0c1tUFdk6Vc2d16z1Imiv7woUA+LzB7wZO?=
 =?us-ascii?Q?noHJOspLngol+xBIBnHbc/L2WLiC2G2DcC8U/WY24cWYtFY9ASa2W+uEOp3r?=
 =?us-ascii?Q?lMpEVfLjE8uLd3nIsVjLNMaWpQIaTgCDs9nFd3XqnUwdLIlQWcH6Y/kCYyRV?=
 =?us-ascii?Q?I+M/s7vxE32EgplG9XOJdk7YLr75dMPwMgUWT6FaYolHXvy3crhKsw1i9/IM?=
 =?us-ascii?Q?sraaSqDpJHcjYE3Oe15oXmvY91bzNN2R+0JBmT4luL8pNg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bc0011ef-d572-4b42-14a3-08d961f6cbaa
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2021 03:18:05.8205
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VyXCfByQiXU33UfqZWom+B0Rxux4kVKvbZ23Eg9tnOeGhCXAPK57UEnwoieifw6O
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3078
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: krbrWwEe7Khvy5U3Dj4HTQD8z6GyNU33
X-Proofpoint-ORIG-GUID: krbrWwEe7Khvy5U3Dj4HTQD8z6GyNU33
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-08-18_01:2021-08-17,2021-08-18 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 bulkscore=0 adultscore=0
 clxscore=1015 impostorscore=0 mlxlogscore=935 priorityscore=1501
 spamscore=0 mlxscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2108180019
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Aug 14, 2021 at 01:25:10PM +0800, Muchun Song wrote:
> The diagram below shows how to make the folio lruvec lock safe when LRU
> pages are reparented.
> 
> folio_lruvec_lock(folio)
>     retry:
> 	lruvec = folio_lruvec(folio);
> 
>         // The folio is reparented at this time.
>         spin_lock(&lruvec->lru_lock);
> 
>         if (unlikely(lruvec_memcg(lruvec) != folio_memcg(folio)))
>             // Acquired the wrong lruvec lock and need to retry.
>             // Because this folio is on the parent memcg lruvec list.
>             goto retry;
> 
>         // If we reach here, it means that folio_memcg(folio) is stable.
> 
> memcg_reparent_objcgs(memcg)
>     // lruvec belongs to memcg and lruvec_parent belongs to parent memcg.
>     spin_lock(&lruvec->lru_lock);
>     spin_lock(&lruvec_parent->lru_lock);
> 
>     // Move all the pages from the lruvec list to the parent lruvec list.
> 
>     spin_unlock(&lruvec_parent->lru_lock);
>     spin_unlock(&lruvec->lru_lock);
> 
> After we acquire the lruvec lock, we need to check whether the folio is
> reparented. If so, we need to reacquire the new lruvec lock. On the
> routine of the LRU pages reparenting, we will also acquire the lruvec
> lock (will be implemented in the later patch). So folio_memcg() cannot
> be changed when we hold the lruvec lock.
> 
> Since lruvec_memcg(lruvec) is always equal to folio_memcg(folio) after
> we hold the lruvec lock, lruvec_memcg_debug() check is pointless. So
> remove it.
> 
> This is a preparation for reparenting the LRU pages.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> Acked-by: Roman Gushchin <guro@fb.com>

Maybe it's mostly s/page/folio, but the patch looks quite differently
in comparison to the version I did ack. In general, please, drop acks
when there are significant changes between versions.

Thanks!