Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp161910pxb; Tue, 17 Aug 2021 22:25:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzitqGn/jMyJYFpzfuXwlxJMSrAk6o7t9tKqUUVzYQUtB1EnxCSvq1ptHSGJJdfany7YkEz X-Received: by 2002:a17:906:8493:: with SMTP id m19mr7907488ejx.103.1629264357363; Tue, 17 Aug 2021 22:25:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629264357; cv=none; d=google.com; s=arc-20160816; b=ecvpe1fx244LBj6SbY1MO3zleQe7+e5vYBu01+2nKrrsdpj1c+EIXY8VcK41Ht+MN+ NRHGH6MYF1+bX1s3jsTWYtFKV/mNaNj0rfZzCqLQ5ETNsMQASuctIhfMnd8xIKsvsg8I JQ6OtiEX4sMC49EOUvrgKxHn8IYngDx+fONkagXQfdygb6/bp6YHFa1DC6PdvHDD21XA wQqACil76ds77LZZYoIrl2OSjZ8nvCPdvw3wKgg7VBs+do+4afs6hjEt+neK3vP2J+b/ WQ/Grurm686hDei56Z2AGkOe47tWOfco0r2bbDV68fkKZWy0siBEHsM5ReJhAUTN1pm6 Usgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=t4ZWSR5zWk1YxYDaaixbEZrAIZkYnBThdZXpSsPbam8=; b=KkV5gPrlMODLjLcbgzTF7pLYdeo810BJ2cQGUKAjmaptvDaIObZmkLSVWcogL/PCM4 yKimIGKQ5V3Wb1+N+Y9JQ7qr+dOsiTSwg6JjG8niYhmMFvmNf2eN1r63VE5p1PlYgyFy m27LSqBpC+TmkjUukTA61E791Cu2SiB/E8TJkUrKe/4k2iKygAm9ArsabRXaHFVE1gKl 8a5SY/HfrhTsAfm2B/XqzVm2UwUk1IYKmFlpEB1LTjxFblLSncMrinQ0R9prUu58tjgQ wqGbimvlY6Cp3jtPuZJbCt6f7m3j/7gZJyt8aMvlc9hThOdNxgCLsLELJmQrSD4B8HoC pqLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w18si4512818ejv.669.2021.08.17.22.25.34; Tue, 17 Aug 2021 22:25:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237482AbhHRFYR (ORCPT + 99 others); Wed, 18 Aug 2021 01:24:17 -0400 Received: from verein.lst.de ([213.95.11.211]:60631 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229768AbhHRFYR (ORCPT ); Wed, 18 Aug 2021 01:24:17 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 819C267357; Wed, 18 Aug 2021 07:23:40 +0200 (CEST) Date: Wed, 18 Aug 2021 07:23:40 +0200 From: Christoph Hellwig To: Kari Argillander Cc: Konstantin Komarov , ntfs3@lists.linux.dev, Christoph Hellwig , linux-kernel@vger.kernel.org, Joe Perches Subject: Re: [PATCH v3 0/3] fs/ntfs3: Use kernel alloc wrappers and fix warnings Message-ID: <20210818052340.GA9053@lst.de> References: <20210818010649.412912-1-kari.argillander@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210818010649.412912-1-kari.argillander@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 18, 2021 at 04:06:46AM +0300, Kari Argillander wrote: > In ntfs3 driver there is allocation made like this ntfs_malloc(). > Patch 2/3 will converter these to kernel ones like kmalloc(). After I > did this then checkpatch raise warnings about array allocations so I > fix these in patch 3/3. > > I also notice when I made patch that there is broken utf8 char so I > wanted first fix that because it raised some warning in my editor and > did not want to "break" patch 2/3. So patch 1/3 address that. I did > try to apply this and it seem to work without issues. So this mostly looks sensible, but I still haven't actually seen the codebase this applies to posted anywhere as far as I can tell.