Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com;
Envelope-to: git@xilinx.com,
 saikrishna12468@gmail.com,
 linux-gpio@vger.kernel.org,
 linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 linus.walleij@linaro.org
Subject: Re: [PATCH] pinctrl: pinctrl-zynq: Add warning for not to use
 'io-standard'
To:     Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        Michal Simek <michal.simek@xilinx.com>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <git@xilinx.com>, <saikrishna12468@gmail.com>
References: <1629265999-33358-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com>
From:   Michal Simek <michal.simek@xilinx.com>
Message-ID: <447d7205-f562-72c2-8317-031cd733d60c@xilinx.com>
Date:   Wed, 18 Aug 2021 08:00:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <1629265999-33358-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2021 06:00:11.7954
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 550fe484-61ba-4546-4072-08d9620d70f5
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT025.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6936
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/18/21 7:53 AM, Sai Krishna Potthuri wrote:
> This patch add warning message saying 'io-standard' property is deprecated
> and instead use 'power-source' property for configuring power supplies.
> This gives an indication for Zynq pinctrl users to migrate to use
> 'power-source' property.
> 
> Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
> ---
>  drivers/pinctrl/pinctrl-zynq.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
> index a96af8a..5b269b6 100644
> --- a/drivers/pinctrl/pinctrl-zynq.c
> +++ b/drivers/pinctrl/pinctrl-zynq.c
> @@ -1028,6 +1028,8 @@ static int zynq_pinconf_cfg_get(struct pinctrl_dev *pctldev,
>  		break;
>  	}
>  	case PIN_CONFIG_IOSTANDARD:
> +		dev_warn(pctldev->dev, "io-standard is deprecated, please use power-source");
> +		fallthrough;
>  	case PIN_CONFIG_POWER_SOURCE:
>  		arg = zynq_pinconf_iostd_get(reg);
>  		break;
> @@ -1079,6 +1081,8 @@ static int zynq_pinconf_cfg_set(struct pinctrl_dev *pctldev,
>  
>  			break;
>  		case PIN_CONFIG_IOSTANDARD:
> +			dev_warn(pctldev->dev, "io-standard is deprecated, please use power-source");
> +			fallthrough;
>  		case PIN_CONFIG_POWER_SOURCE:
>  			if (arg <= zynq_iostd_min || arg >= zynq_iostd_max) {
>  				dev_warn(pctldev->dev,
> 


Acked-by: Michal Simek <michal.simek@xilinx.com>

Linus: would be good to know how long we should keep the support for
this deprecated dt property.

Thanks,
Michal