Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Yang Yingliang <yangyingliang@huawei.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
CC:     "broonie@kernel.org" <broonie@kernel.org>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>
Subject: RE: [PATCH -next] ASoC: sh: rz-ssi: Fix return value check in
 rz_ssi_dma_request()
Thread-Topic: [PATCH -next] ASoC: sh: rz-ssi: Fix return value check in
 rz_ssi_dma_request()
Thread-Index: AQHXkxM86qyxelIXFUSoh7N/p/Brr6t3O6JQgAGTTaA=
Date:   Wed, 18 Aug 2021 06:43:35 +0000
Message-ID: <OS0PR01MB59222F36C578A214E3DEE41286FF9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <20210817030027.1462671-1-yangyingliang@huawei.com>
 <OS0PR01MB59229720A7C243A47E7A1F1D86FE9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
In-Reply-To: <OS0PR01MB59229720A7C243A47E7A1F1D86FE9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pa3PzaOU0W99OcqqYsnBQ9ZG0BYkkxMDcyqeDLwCMpM0PU9MLJvyWrOTMHOh?=
 =?us-ascii?Q?nN7Hp97DwT1Koofz9B004eIdPAFpS7LdXZ/zFqCapfeu3/Dp7S0WsW9417ct?=
 =?us-ascii?Q?oSjc56p6A6cva+0Yc+oZLYBAeFvX2rXdHY5DorG0t8GtMBObVeOJF51ewtOi?=
 =?us-ascii?Q?/i1gKq1NRoa+PA5BZurtX6VakNWLLBtDUMtbKKaNXKUGP18XiMmFlLheKbYO?=
 =?us-ascii?Q?QqNvqkzV5X/j6b+pz3AwclzKs55x2PYfJ6DRPhBh9dNcMicaYLpQh7BFGJN/?=
 =?us-ascii?Q?KGnea+OpgQDD0wb+/CamF+qDo3DZnZMbTvyrExyEJQSqFHqNep7M9oqpAnbV?=
 =?us-ascii?Q?vW1IFBXU32/jIF/dCDtOrS4FbpIumqwQ6ob8dUMHse7xyz61e3u19eeyz0ws?=
 =?us-ascii?Q?IW5YqbAWqa4N4Gg0pjKz4J7KYNjhCiY3PVmiYZbV+TEFOfxAnoVvhxGFAfyq?=
 =?us-ascii?Q?+vZIVG3N76fy31keb6/tx+BTl+92fczgKI3jTIscswPinaCqQR4E5NbQAu1U?=
 =?us-ascii?Q?uxldJ1ibIEDO1tYxupeXRmLWDblTkKmF9IUZ1jW/3+wJOkb2z1VUYtlJY4Xd?=
 =?us-ascii?Q?aVkjDaFKOuc6aMvfE+tKok7hJ1VREBrsw8SO104FduU49laDsi58hwGe4D/I?=
 =?us-ascii?Q?eZKX/OKVD9wOMo3SHd44VnpVblOIoI4EMWksBLwPPCTKMgT8Hb67Qluou6Ky?=
 =?us-ascii?Q?kI9KGtx9MBJLMnp968VtQ5ZmDC3OmeAypSNx325HnxTduDrb4CAzv8zWHkQe?=
 =?us-ascii?Q?hs8bkXYHGg6SMsWKgU6wXXkUVJuN+X9GUVOppNSHNX+9KTtlTDubZjLnfwdq?=
 =?us-ascii?Q?5Pt40Nj527A7jIYNZtv8JRwTtHvpvvMimWAwWrfUrA1cjDiU2HP7+dfaOibj?=
 =?us-ascii?Q?qChxxtbuS/91Wgi1m4bd8wsobXj1wRszmohEyBjIO0zFP6beoe9CHNJJ9dRP?=
 =?us-ascii?Q?hooGrn83MbWRvF3O8WbRNSpyeN3+nYp4xqufMVhvIWmRrV/wwNvr63gBTIGT?=
 =?us-ascii?Q?akwk111Brs1eEui74/X2RcERyCwKFuCcGBLzaflGKNQBiJc8HvHh6upoGyNR?=
 =?us-ascii?Q?IxtN6MKGivclfOsqCtbs0KYG8+fvwpRLOpu2SPejCxtyqDaN0EeFNsM2DLhe?=
 =?us-ascii?Q?HO3Dn1woKdK8foBXe9lob0twj8xvud8qhs/dd5xDIc8RJ/H9RAbZIONgumqc?=
 =?us-ascii?Q?0c0j0APpSKRenhIo2n+t0hobx1Yw2Vyok0A+NkndAStpixrMqRUGPaefxZBg?=
 =?us-ascii?Q?QA/BLrNxA0+SyNRT/vjagCxfYruoyJYyIe11JovBDG8m+lanFKKBE5HgiiQn?=
 =?us-ascii?Q?bHEWSQpITNRDAkC5UfiQ9Lkz?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fd1f804-fa5e-4d71-a48e-08d962138122
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2021 06:43:35.8499
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9Q67rCHAlBQp/iP54gNQLaZ40S884yQA0/Y8rtx+9BOO8oSmlTeQnBMwOpptYICGmt4LW8pDMlvSUM+2R6tUsDOfCg/l+6Sxh+isGPSZ7EY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB2936
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Yang Yingliang,

Still some improvements to be done on this patch.
If one of the dma channel is failed, we should fallback that channel to PIO=
.

Something like below. I will post a new patch after testing this.

ssi->playback.transfer =3D rz_ssi_pio_send;
ssi->capture.transfer =3D rz_ssi_pio_recv;

/* Detect DMA support */
ret =3D rz_ssi_dma_request(ssi, &pdev->dev);
if (ret < 0) {
	dev_warn(&pdev->dev, "DMA not available, using PIO\n");
} else {
	dev_info(&pdev->dev, "DMA enabled");
	if (ssi->playback.dma_ch)
		ssi->playback.transfer =3D rz_ssi_dma_transfer;
	if (ssi->capture.dma_ch)
		ssi->capture.transfer =3D rz_ssi_dma_transfer;
}

Regards,
Biju


> Subject: RE: [PATCH -next] ASoC: sh: rz-ssi: Fix return value check in
> rz_ssi_dma_request()
>=20
> Hi Yang Yingliang,
>=20
> Thanks for your patch.
>=20
> Already I have posted a patch for fixing it.
>=20
> https://patchwork.kernel.org/project/alsa-
> devel/patch/20210814180120.18082-1-biju.das.jz@bp.renesas.com/
>=20
> Since you posted a similar patch as Reported-by: Hulk Robot
> <hulkci@huawei.com>, I am adding my Rb tag for this patch.
>=20
> Regards,
> Biju
>=20
>=20
> > -----Original Message-----
> > From: Yang Yingliang <yangyingliang@huawei.com>
> > Sent: 17 August 2021 04:00
> > To: linux-kernel@vger.kernel.org; alsa-devel@alsa-project.org
> > Cc: broonie@kernel.org; Biju Das <biju.das.jz@bp.renesas.com>;
> > Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>;
> > lgirdwood@gmail.com
> > Subject: [PATCH -next] ASoC: sh: rz-ssi: Fix return value check in
> > rz_ssi_dma_request()
> >
> > In case of error, the function dma_request_chan() returns ERR_PTR()
> > and never returns NULL. Set 'dma_ch' to NULL, if dma_request_chan()
> > returns error, so the code using 'dma_ch' can work correctly.
> >
> > Fixes: 26ac471c5354 ("ASoC: sh: rz-ssi: Add SSI DMAC support")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>=20
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
>=20
> > ---
> >  sound/soc/sh/rz-ssi.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/sh/rz-ssi.c b/sound/soc/sh/rz-ssi.c index
> > ea8d33ede5d2..5ec78fd94d94 100644
> > --- a/sound/soc/sh/rz-ssi.c
> > +++ b/sound/soc/sh/rz-ssi.c
> > @@ -676,11 +676,17 @@ static void rz_ssi_release_dma_channels(struct
> > rz_ssi_priv *ssi)  static int rz_ssi_dma_request(struct rz_ssi_priv
> > *ssi, struct device *dev)  {
> >  	ssi->playback.dma_ch =3D dma_request_chan(dev, "tx");
> > +	if (IS_ERR(ssi->playback.dma_ch))
> > +		ssi->playback.dma_ch =3D NULL;
> >  	ssi->capture.dma_ch =3D dma_request_chan(dev, "rx");
> > +	if (IS_ERR(ssi->capture.dma_ch))
> > +		ssi->capture.dma_ch =3D NULL;
> >  	if (!ssi->playback.dma_ch && !ssi->capture.dma_ch) {
> >  		ssi->playback.dma_ch =3D dma_request_chan(dev, "rt");
> > -		if (!ssi->playback.dma_ch)
> > +		if (IS_ERR(ssi->playback.dma_ch)) {
> > +			ssi->playback.dma_ch =3D NULL;
> >  			goto no_dma;
> > +		}
> >
> >  		ssi->dma_rt =3D true;
> >  	}
> > --
> > 2.25.1