Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp203065pxb; Tue, 17 Aug 2021 23:46:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1lXOijlk0Ic/qyISvdDP/26Evn/n5nQlp/lVdi+cUlE917ME8yq2yUD8YZIP1JYJcPBxm X-Received: by 2002:a17:906:8493:: with SMTP id m19mr8186571ejx.103.1629269164353; Tue, 17 Aug 2021 23:46:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629269164; cv=none; d=google.com; s=arc-20160816; b=u/v9QRBecdQUqd3LY2OsAGuMKL2bqers4f8fdvdgvpBRh20cdeRzqq9N3yxehkN8iV hTyVjybnPmqCbi/bS8Bvq7iHAwgUp8aBDr+ei3TnMicoSAg7Hy7U9B0yPgH3kzK7suq7 alZyDPtH3qCzEV7MifMmyaj++C4kWGmqVmj8pBsM3TpdOI37JDzgsi3o7PKGQOOztShV zWs0S86YHLiG023rvnmptygwqyv4AzHxLeodt1PDsiDr3uxo/fMSE7x2xUbki8g6Dp0k VwM5N9ijJzlSM6ggcOD8f1d2V2dWWsvfqEfxQz4wYz8CxjY0YMX1Fxlmtb+bpt9czuCR 5j5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=zzoOCl2YreUt7MfN2Ool90MUXMUXImkpZjNooyEe0Ac=; b=S12Vtw3siLnbUsGtGvKSROvW5zoIrdIPdLl/hg/WT5osvOjnUTnB7BDs4Y/CY1203Y Td4aJRRi+cwhWqcVvq2CZIOBNXRu65TbFJYLwEkeJDsfFRTmBp2bZugJ4ee46cLpmScE nJQCpuQgkIpBdUuTnmW+9Ner33JgilNraqWk3V2s1TQY5CU3d2vpbA3/T6OKvb5N+bXz Wnf0BvfvI8TPX3CGFwkoVaupjKi+T1FO+h/NyL3nJ1m7hAk98ieurHz6qUavcPYhHAxz SCUjasqX+vd9JHQtQ5fEzqNnavnb4qgvu2hwh2wdnCN7jJqDcfrbOjrg30Sgn4Rnk7K9 3oKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kroah.com header.s=fm1 header.b="qGyZU/e5"; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=rPRElJXU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id aq7si5315491ejc.175.2021.08.17.23.45.41; Tue, 17 Aug 2021 23:46:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kroah.com header.s=fm1 header.b="qGyZU/e5"; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=rPRElJXU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238444AbhHRGoi (ORCPT + 99 others); Wed, 18 Aug 2021 02:44:38 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33447 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238280AbhHRGoh (ORCPT ); Wed, 18 Aug 2021 02:44:37 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id EA5175C0259; Wed, 18 Aug 2021 02:44:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 18 Aug 2021 02:44:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=zzoOCl2YreUt7MfN2Ool90MUXMU XImkpZjNooyEe0Ac=; b=qGyZU/e5mtYaTVwX0UHaEohjjaNINhPX+/hEggeB4Ed 6t9xQ0PVlusJV2vv/yQXEAFBLFt8EOutsCmZo+4dPyOB2mA5uTho0w9KqlNc7E3b xUbukQFxgv+ETvU+XhqYsXWcun5+obn7tixApT3CqWT8yINgxTEjrxWuT5Qzl5Im ZTEwwIqaLVszK3b5ZEEK3J3XVXfJoDI081YA48xqhXlSGLkJjAja3wR/1KoPmlwI Jr4EkAb1sV847nRFhYofNoxEJlVxnQ6rI7AJlb+Av6ysLkNJXv+Ix0+IT6Ysr5sV 7s5vSPqMiM2/1v9nd4BufHkFmImLxx1IIXzX39v0MbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=zzoOCl 2YreUt7MfN2Ool90MUXMUXImkpZjNooyEe0Ac=; b=rPRElJXU3AILQ5wm18OW7G 9phavvnnMqDtV/bKmofjzcay6EJkxWt80+jBwEPS6CpyN+CcEvXb5Niy4hGbGY07 lMZwlnv+b3v80adhb/LhIBi0h9L8KbaDJpIXP8b0PN889ZoAmdOXN6Ffp1izApmj yxHgOX0K+X6aQ6Mf5Y15rLofTMjwCUz5nJVPYQxh4Ajogm1Fb6epwfkbQC6h1jA3 cdntNYeAV3DmNzByZ3A6zYywKXMnS1cIdGkmweVdkJiRG4p4KjJHTbDB7pscGFG8 2/zspNHd+ihkuLSJCp7FGzaKK6SJZTB3OpOskj6OFq6qFnfPcsHmEg5cLrmuyLlg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrleeggddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeevueehje fgfffgiedvudekvdektdelleelgefhleejieeugeegveeuuddukedvteenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhh drtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Aug 2021 02:44:01 -0400 (EDT) Date: Wed, 18 Aug 2021 08:43:58 +0200 From: Greg KH To: Cai Huoqing Cc: dan.carpenter@oracle.com, yangyingliang@huawei.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: r8188eu: Remove unused including Message-ID: References: <20210818063653.2851-1-caihuoqing@baidu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210818063653.2851-1-caihuoqing@baidu.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 18, 2021 at 02:36:53PM +0800, Cai Huoqing wrote: > Remove including that don't need it > > v1->v2: remove "based on staging-next" from commit message > v2->v3: add changelog to commit message As the documentation states, these lines need to go below the --- line, right? Please fix up and send a v4. thanks, greg k-h