Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: linux-next: build warning after merge of the i2c tree
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Wolfram Sang <wsa@the-dreams.de>,
        Conghui Chen <conghui.chen@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
References: <20210818162959.4dfe60a0@canb.auug.org.au>
 <1d80c5e6-5d5e-1714-78d8-8d2b9c6f8389@intel.com>
 <20210818170418.5e03390b@canb.auug.org.au>
From:   Jie Deng <jie.deng@intel.com>
Message-ID: <eaabdd90-9838-8ff2-594c-1088bdd130a1@intel.com>
Date:   Wed, 18 Aug 2021 15:13:55 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210818170418.5e03390b@canb.auug.org.au>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 2021/8/18 15:04, Stephen Rothwell wrote:
> Hi Jie,
>
> On Wed, 18 Aug 2021 14:54:12 +0800 Jie Deng <jie.deng@intel.com> wrote:
>> On 2021/8/18 14:29, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the i2c tree, today's linux-next build (powerpc
>>> allyesconfig) produced this warning:
>>>
>>> drivers/i2c/busses/i2c-virtio.c: In function 'virtio_i2c_probe':
>>> drivers/i2c/busses/i2c-virtio.c:208:17: warning: unused variable 'pdev' [-Wunused-variable]
>>>     208 |  struct device *pdev = vdev->dev.parent;
>>>         |                 ^~~~
>>>
>>> Introduced by commit
>>>
>>>     8fb12751ac78 ("i2c: virtio: add a virtio i2c frontend driver")
>> Why we have this warning ? In commit 8fb12751ac78, the variable 'pdev' was used in line 237.
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/commit/?h=i2c/for-next&id=8fb12751ac78d0a4ba3c604496ffc8dcd1bd6c31
>>
> When CONFIG_ACPI is not set, ACPI_COMPANION{,_SET} do not use their arguments.


Thanks Stephen. I will send an additional patch to fix it.