Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
AI-Spam-Status: Not processed
Date:   Wed, 18 Aug 2021 17:27:04 +0800
From:   Icenowy Zheng <icenowy@aosc.io>
To:     Kyle Tso <kyletso@google.com>, Guenter Roeck <linux@roeck-us.net>
CC:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Badhri Jagan Sridharan <badhri@google.com>
Subject: Re: [PATCH] usb: typec: tcpm: always rediscover when swapping DR
User-Agent: K-9 Mail for Android
In-Reply-To: <CAGZ6i=1s9X58tOwoiGAxMkMVBTyGTjysOSe9bP8Q4WosmCtymw@mail.gmail.com>
References: <20210813043131.833006-1-icenowy@aosc.io> <YRuDG78N2mB5w37p@kuha.fi.intel.com> <58034df4-f18c-ab3e-1fcc-dc85fc35320f@roeck-us.net> <CAGZ6i=1s9X58tOwoiGAxMkMVBTyGTjysOSe9bP8Q4WosmCtymw@mail.gmail.com>
Message-ID: <ADFCCA37-D216-407A-BDC6-01DB7F14548B@aosc.io>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


=E4=BA=8E 2021=E5=B9=B48=E6=9C=8818=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=884=
:02:24, Kyle Tso <kyletso@google=2Ecom> =E5=86=99=E5=88=B0:
>On Tue, Aug 17, 2021 at 11:13 PM Guenter Roeck <linux@roeck-us=2Enet> wro=
te:
>>
>> On 8/17/21 2:36 AM, Heikki Krogerus wrote:
>> > On Fri, Aug 13, 2021 at 12:31:31PM +0800, Icenowy Zheng wrote:
>> >> Currently, TCPM code omits discover when swapping to gadget, and ass=
ume
>> >> that no altmodes are available when swapping from gadget=2E However,=
 we do
>> >> send discover when we get attached as gadget -- this leads to modes =
to be
>> >> discovered twice when attached as gadget and then swap to host=2E
>> >>
>> >> Always re-send discover when swapping DR, regardless of what change =
is
>> >> being made; and because of this, the assumption that no altmodes are
>> >> registered with gadget role is broken, and altmodes de-registeration=
 is
>> >> always needed now=2E
>> >>
>> >> Signed-off-by: Icenowy Zheng <icenowy@aosc=2Eio>
>> >> ---
>> >>   drivers/usb/typec/tcpm/tcpm=2Ec | 9 ++++-----
>> >>   1 file changed, 4 insertions(+), 5 deletions(-)
>> >>
>> >> diff --git a/drivers/usb/typec/tcpm/tcpm=2Ec b/drivers/usb/typec/tcp=
m/tcpm=2Ec
>> >> index b9bb63d749ec=2E=2Eab6d0d51ee1c 100644
>> >> --- a/drivers/usb/typec/tcpm/tcpm=2Ec
>> >> +++ b/drivers/usb/typec/tcpm/tcpm=2Ec
>> >> @@ -4495,15 +4495,14 @@ static void run_state_machine(struct tcpm_po=
rt *port)
>> >>              tcpm_set_state(port, ready_state(port), 0);
>> >>              break;
>> >>      case DR_SWAP_CHANGE_DR:
>> >> -            if (port->data_role =3D=3D TYPEC_HOST) {
>> >> -                    tcpm_unregister_altmodes(port);
>> >> +            tcpm_unregister_altmodes(port);
>> >> +            if (port->data_role =3D=3D TYPEC_HOST)
>> >>                      tcpm_set_roles(port, true, port->pwr_role,
>> >>                                     TYPEC_DEVICE);
>> >> -            } else {
>> >> +            else
>> >>                      tcpm_set_roles(port, true, port->pwr_role,
>> >>                                     TYPEC_HOST);
>> >> -                    port->send_discover =3D true;
>> >> -            }
>> >> +            port->send_discover =3D true;
>> >>              tcpm_ams_finish(port);
>> >>              tcpm_set_state(port, ready_state(port), 0);
>> >>              break;
>> >
>> > Why is it necessary to do discovery with data role swap in general?
>> >
>> > thanks,
>> >
>>
>> Additional question: There are two patches pending related to DR_SWAP
>> and discovery=2E Are they both needed, or do they both solve the same
>> problem ?
>>
>> Thanks,
>> Guenter
>
>Hi, I just noticed this patch=2E
>
>Part of this patch and part of my patch
>https://lore=2Ekernel=2Eorg/r/20210816075449=2E2236547-1-kyletso@google=
=2Ecom
>are to solve the same problem that Discover_Identity is not sent in a
>case where the port becomes UFP after DR_SWAP while in PD3=2E
>
>The difference (for the DR_SWAP part) is that my patch does not set
>the flag "send_discover" if the port becomes UFP after PD2 DR_SWAP=2E
>That is because in PD2 Spec, UFP is not allowed to be the SVDM
>Initiator=2E
>
>This patch indeed solves another problem where
>tcpm_unregister_altmodes should be called during PD3 DR_SWAP because
>the port partner may return mode data in the latest Discover_Mode=2E For
>the PD2 case, I don't think it needs to be called because PD2 DFP will
>always return NAK for Discover_Mode=2E However it is fine because it is

It sounds like my dock is doing something against the specification=2E=2E=
=2E

It sends altmodes rather than NAK when my board gets attached as
UFP and send bogus discovers (because of bugs of current TCPM
code)=2E These altmodes are then registered in TCPM and never get
cleaned up within it, which leads to conflict when the dock is
removed and then re-inserted=2E

(BTW is it neceesary for data role and power role to be the same
when attaching? My board now gets attached as UFP to drain
power, and then do DR_SWAP to become USB host=2E)

>safe to call tcpm_unregister_altmodes even if there is no mode data=2E
>
>In fact, when I was tracing the code I found another bug=2E PD2 UFP is
>not allowed to send Discover_Identity and Discover_Mode=2E I can send
>another patch to address this problem=2E
>
>thanks,
>Kyle