Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4] staging: r8188eu: Remove unused including
 <linux/version.h>
To:     Cai Huoqing <caihuoqing@baidu.com>, dan.carpenter@oracle.com,
        greg@kroah.com, yangyingliang@huawei.com
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20210818095331.3422-1-caihuoqing@baidu.com>
From:   Michael Straube <straube.linux@gmail.com>
Message-ID: <b66cf51b-b363-53d7-48be-dec524f3c8ac@gmail.com>
Date:   Wed, 18 Aug 2021 11:57:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210818095331.3422-1-caihuoqing@baidu.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/18/21 11:53 AM, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> v1->v2: remove "based on staging-next" from commit message
> v2->v3: add changelog to commit message
> v3->v4: move the modified change under the --- line
> 
>   drivers/staging/r8188eu/core/rtw_mlme.c      | 1 -
>   drivers/staging/r8188eu/os_dep/os_intfs.c    | 1 -
>   drivers/staging/r8188eu/os_dep/rtw_android.c | 1 -
>   drivers/staging/r8188eu/os_dep/xmit_linux.c  | 1 -
>   4 files changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
> index d5ef5783f4ad..82b74ebdaabd 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme.c
> @@ -3,7 +3,6 @@
>   
>   #define _RTW_MLME_C_
>   
> -#include <linux/version.h>
>   #include "../include/osdep_service.h"
>   #include "../include/drv_types.h"
>   #include "../include/recv_osdep.h"
> diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c
> index f4bf4732578a..aef978eef4d7 100644
> --- a/drivers/staging/r8188eu/os_dep/os_intfs.c
> +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c
> @@ -12,7 +12,6 @@
>   
>   #include "../include/usb_osintf.h"
>   #include "../include/rtw_br_ext.h"
> -#include <linux/version.h>
>   
>   MODULE_LICENSE("GPL");
>   MODULE_DESCRIPTION("Realtek Wireless Lan Driver");
> diff --git a/drivers/staging/r8188eu/os_dep/rtw_android.c b/drivers/staging/r8188eu/os_dep/rtw_android.c
> index bdd381606ba6..af0072e2cb5f 100644
> --- a/drivers/staging/r8188eu/os_dep/rtw_android.c
> +++ b/drivers/staging/r8188eu/os_dep/rtw_android.c
> @@ -3,7 +3,6 @@
>   
>   #include <linux/module.h>
>   #include <linux/netdevice.h>
> -#include <linux/version.h>
>   #include "../include/rtw_android.h"
>   #include "../include/osdep_service.h"
>   #include "../include/rtw_debug.h"
> diff --git a/drivers/staging/r8188eu/os_dep/xmit_linux.c b/drivers/staging/r8188eu/os_dep/xmit_linux.c
> index 4f1ce346b3a5..69966c696130 100644
> --- a/drivers/staging/r8188eu/os_dep/xmit_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/xmit_linux.c
> @@ -3,7 +3,6 @@
>   
>   #define _XMIT_OSDEP_C_
>   
> -#include <linux/version.h>
>   #include "../include/osdep_service.h"
>   #include "../include/drv_types.h"
>   #include "../include/if_ether.h"
> 

Looks good to me now.

Acked-by: Michael Straube <straube.linux@gmail.com>


Thanks,

Michael