Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
References: <CAKXUXMwgWfX8+OvY0aCwRNukencwJERAZzU7p4eOLXQ2zv6rAg@mail.gmail.com>
User-agent: mu4e 1.6.3; emacs 27.2
From:   Felipe Balbi <balbi@kernel.org>
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     Manish Narani <manish.narani@xilinx.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Dependency of USB_DWC3_XILINX on ARCH_VERSAL
Date:   Wed, 18 Aug 2021 13:02:19 +0300
In-reply-to: <CAKXUXMwgWfX8+OvY0aCwRNukencwJERAZzU7p4eOLXQ2zv6rAg@mail.gmail.com>
Message-ID: <87pmubf4rh.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Hi Lukas,

Lukas Bulwahn <lukas.bulwahn@gmail.com> writes:
> Commit 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms")
> adds the config USB_DWC3_XILINX, which depends on the config
> ARCH_VERSAL. However, the config ARCH_VERSAL is not defined in the
> current mainline kernel repository.
>
> Will a definition of ARCH_VERSAL follow eventually (soon?) for
> mainline, is there just a further out-of-tree development for which
> the dependency is useful or is this just a mistake and can be
> corrected?

IMHO, we should have COMPILE_TEST added. Something like this:

modified   drivers/usb/dwc3/Kconfig
@@ -151,7 +151,7 @@ config USB_DWC3_IMX8MP
 
 config USB_DWC3_XILINX
 	tristate "Xilinx Platforms"
-	depends on (ARCH_ZYNQMP || ARCH_VERSAL) && OF
+	depends on (ARCH_ZYNQMP || ARCH_VERSAL || COMPILE_TEST) && OF
 	default USB_DWC3
 	help
 	  Support Xilinx SoCs with DesignWare Core USB3 IP.

Care to test, please

-- 
balbi