Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935706AbWLCKke (ORCPT ); Sun, 3 Dec 2006 05:40:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935736AbWLCKke (ORCPT ); Sun, 3 Dec 2006 05:40:34 -0500 Received: from astra.telenet-ops.be ([195.130.132.58]:32727 "EHLO astra.telenet-ops.be") by vger.kernel.org with ESMTP id S935706AbWLCKkd (ORCPT ); Sun, 3 Dec 2006 05:40:33 -0500 Date: Sun, 3 Dec 2006 11:40:27 +0100 (CET) From: Geert Uytterhoeven To: Yan Burman Cc: Linux Kernel Development , Roman Zippel , Geert Uytterhoeven , trivial@kernel.org Subject: Re: [PATCH 2.6.19] m68k: replace kmalloc+memset with kzalloc In-Reply-To: <1165058964.4523.30.camel@localhost> Message-ID: References: <1165058964.4523.30.camel@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2220 Lines: 57 On Sat, 2 Dec 2006, Yan Burman wrote: > Replace kmalloc+memset with kzalloc > > Signed-off-by: Yan Burman Acked-by: Geert Uytterhoeven > diff -rubp linux-2.6.19-rc5_orig/arch/m68k/amiga/chipram.c linux-2.6.19-rc5_kzalloc/arch/m68k/amiga/chipram.c > --- linux-2.6.19-rc5_orig/arch/m68k/amiga/chipram.c 2006-11-09 12:16:21.000000000 +0200 > +++ linux-2.6.19-rc5_kzalloc/arch/m68k/amiga/chipram.c 2006-11-11 22:44:04.000000000 +0200 > @@ -52,10 +52,9 @@ void *amiga_chip_alloc(unsigned long siz > #ifdef DEBUG > printk("amiga_chip_alloc: allocate %ld bytes\n", size); > #endif > - res = kmalloc(sizeof(struct resource), GFP_KERNEL); > + res = kzalloc(sizeof(struct resource), GFP_KERNEL); > if (!res) > return NULL; > - memset(res, 0, sizeof(struct resource)); > res->name = name; > > if (allocate_resource(&chipram_res, res, size, 0, UINT_MAX, PAGE_SIZE, NULL, NULL) < 0) { > > diff -rubp linux-2.6.19-rc5_orig/arch/m68k/atari/hades-pci.c linux-2.6.19-rc5_kzalloc/arch/m68k/atari/hades-pci.c > --- linux-2.6.19-rc5_orig/arch/m68k/atari/hades-pci.c 2006-11-09 12:16:21.000000000 +0200 > +++ linux-2.6.19-rc5_kzalloc/arch/m68k/atari/hades-pci.c 2006-11-11 22:44:04.000000000 +0200 > @@ -375,10 +375,9 @@ struct pci_bus_info * __init init_hades_ > * Allocate memory for bus info structure. > */ > > - bus = kmalloc(sizeof(struct pci_bus_info), GFP_KERNEL); > + bus = kzalloc(sizeof(struct pci_bus_info), GFP_KERNEL); > if (!bus) > return NULL; > - memset(bus, 0, sizeof(struct pci_bus_info)); > > /* > * Claim resources. The m68k has no separate I/O space, both > > > Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/