Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] net/mlx4: Use ARRAY_SIZE to get an array's size
To:     Joe Perches <joe@perches.com>, Jason Wang <wangborong@cdjrlc.com>,
        kuba@kernel.org
Cc:     davem@davemloft.net, tariqt@nvidia.com, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210817121106.44189-1-wangborong@cdjrlc.com>
 <d96db1d04062a2a88eb51f319c2aef0a440755c3.camel@perches.com>
From:   Tariq Toukan <ttoukan.linux@gmail.com>
Message-ID: <5612b0fa-5623-f7d9-6dbe-e2f7165611a6@gmail.com>
Date:   Wed, 18 Aug 2021 15:28:19 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <d96db1d04062a2a88eb51f319c2aef0a440755c3.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 8/18/2021 3:39 AM, Joe Perches wrote:
> On Tue, 2021-08-17 at 20:11 +0800, Jason Wang wrote:
>> The ARRAY_SIZE macro is defined to get an array's size which is
>> more compact and more formal in linux source. Thus, we can replace
>> the long sizeof(arr)/sizeof(arr[0]) with the compact ARRAY_SIZE.
> []
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/qp.c b/drivers/net/ethernet/mellanox/mlx4/qp.c
> []
>> @@ -739,7 +739,7 @@ static void mlx4_cleanup_qp_zones(struct mlx4_dev *dev)
>>   		int i;
>>   
>>
>>   		for (i = 0;
>> -		     i < sizeof(qp_table->zones_uids)/sizeof(qp_table->zones_uids[0]);
>> +		     i < ARRAY_SIZE(qp_table->zones_uids);
>>   		     i++) {
> 
> trivia:  could now be a single line
> 
> 		for (i = 0; i < ARRAY_SIZE(qp_table->zones_uids); i++) {
> 
> 

I'm fine with both suggestions.
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>

Thanks for your patch.
Tariq