Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
References: <20210818130135.575-1-lutovinova@ispras.ru>
User-agent: mu4e 1.6.3; emacs 27.2
From:   Felipe Balbi <balbi@kernel.org>
To:     Nadezda Lutovinova <lutovinova@ispras.ru>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johan Hovold <johan@kernel.org>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] usb: gadget: mv_u3d: Change functon call in mv_u3d_probe()
Date:   Wed, 18 Aug 2021 16:10:55 +0300
In-reply-to: <20210818130135.575-1-lutovinova@ispras.ru>
Message-ID: <87mtpegak8.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Hi,

(first of all, your subject could be a little more descriptive,
something like:

	usb: gadget: mv_u3d: request_irq() after initializing UDC

as that would better detail what you're doing)

Nadezda Lutovinova <lutovinova@ispras.ru> writes:

> If IRQ occurs between calling  request_irq() and  mv_u3d_eps_init(),
> then null pointer dereference occurs since u3d->eps[] wasn't
> initialized yet but used in mv_u3d_nuke().
>
> The patch puts registration of the interrupt handler after
> initializing of neccesery data.
>
> Found by Linux Driver Verification project (linuxtesting.org).

this looks like an important bug fix, it probably deserves a stable tag
here. Which commit introduce this problem? Otherr than that, commits
looks good.

-- 
balbi