Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "allan.nielsen@microchip.com" <allan.nielsen@microchip.com>,
        "joergen.andreasen@microchip.com" <joergen.andreasen@microchip.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "vinicius.gomes@intel.com" <vinicius.gomes@intel.com>,
        "michael.chan@broadcom.com" <michael.chan@broadcom.com>,
        "vishal@chelsio.com" <vishal@chelsio.com>,
        "saeedm@mellanox.com" <saeedm@mellanox.com>,
        "jiri@mellanox.com" <jiri@mellanox.com>,
        "idosch@mellanox.com" <idosch@mellanox.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "kuba@kernel.org" <kuba@kernel.org>, Po Liu <po.liu@nxp.com>,
        Leo Li <leoyang.li@nxp.com>
Subject: Re: [RFC v2 net-next 1/8] net: mscc: ocelot: add MAC table write and
 lookup operations
Thread-Topic: [RFC v2 net-next 1/8] net: mscc: ocelot: add MAC table write and
 lookup operations
Thread-Index: AQHXk/d6/YQinAuyVUGo8AzjgjyFvKt5TDcA
Date:   Wed, 18 Aug 2021 14:05:19 +0000
Message-ID: <20210818140518.5y3pbpy342oeyxac@skbuf>
References: <20210818061922.12625-1-xiaoliang.yang_1@nxp.com>
 <20210818061922.12625-2-xiaoliang.yang_1@nxp.com>
In-Reply-To: <20210818061922.12625-2-xiaoliang.yang_1@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uXolSSHSmfpup0LT/y9PeCDQGTJBnfrtGmO99RE3FjeAnPMgCJG0R5+ADYcZ?=
 =?us-ascii?Q?HYKxAhl7WkM/fgBtAHl3HBrCegycIZXQ+wTUmQYrCWFIuFjl7cGBT6z2Lee7?=
 =?us-ascii?Q?vIZp8D/avHLAde8ESwgkrdeWOVcEkvggpj/O0PjJMP/QBq/FnSrx8IarYtWx?=
 =?us-ascii?Q?HBS4KO9nT/fmxmiQc2F6nc6WX5QYdFZ0mIIp0NvrKMKQ6yq9pHNrSzTmUMgi?=
 =?us-ascii?Q?e202lQcHtl6i3WnGu7yKssjEgPS3O2WE2hO8lPailJPy4TCjUktXbZAaN42f?=
 =?us-ascii?Q?IAohUU8ciX4KvI3fMUFDBHC8auMl7YrUckwgCWUAA2ODtX7Df2NGNd4z3z8T?=
 =?us-ascii?Q?xVELEN4sf/6BPuN5jXAGc/vwtVaw9R5OudBMWHFlw+6hkUkWIA18zbX9eFo5?=
 =?us-ascii?Q?kFb9uN3fgLC5NT3Kg9yS2sviVwG0fOkLOoYEl4Ourh9C/dzFDCNJ/cNwmXSY?=
 =?us-ascii?Q?S9tDPSSOA6FYcqHWmkYP6lf3JSJFr9/IbqiwxHLcYl0H4n4Mvxv1PY1lPTT1?=
 =?us-ascii?Q?JLWxQxrwVb4evJw+qnr/q0DsOOXfHivGPBJCCtqiBUufr98ySqc/CL/brDiB?=
 =?us-ascii?Q?yWzpT8RrgXmEO/Wpb0mNujsrJIfOcPAf/Y/wDIoNfIQOG/2pO91/cV6e+NSV?=
 =?us-ascii?Q?o/w7yRQ+4ZahsHgJjV1UzSKi+/Vcf9nHl8w3hCpFnfoez1eIRPdGRU4cAhz3?=
 =?us-ascii?Q?cAgIDA7+OYpeJtwlX1bbYAFpTciixlGZkOAE/lOi08R9DAC+mNImfStK7oLL?=
 =?us-ascii?Q?mjtbN+2auIc/eh8Io+eE5jRL1KWMcLxnTf0t4A/lh8zK6HKobzRtm8Rh2uMZ?=
 =?us-ascii?Q?gnJiQCvGx1+XL3hzBlwJPOJwrzFvdcU0bl9I+59Qq7CRe/Tvf92NO3o/qhKn?=
 =?us-ascii?Q?Ec4r6JSlIdH/rzr6YYaV+WbrhSUsCPaZ8KDZB+6sexm51o1jRFOrqLckglnp?=
 =?us-ascii?Q?MW5/n+JagwFKCufi4ju6ZNlrJNtBEzt9pRIEA/DxRrHSY+blQcXuFwDndbiD?=
 =?us-ascii?Q?V/oS9lSIukiu/IRWXiET93bXTbZ3rHLQFfjHPBdovvFsUYJI3vVl8creRQzO?=
 =?us-ascii?Q?0rdPUYGCkXultMSRRtILiSuoK1/fMA3UR9KdSPnNDw3TrPDnHYn43IQfUTri?=
 =?us-ascii?Q?tVHl0WsaTk/XL5hD33Z9lOugJHYT19I1F7wr1EhQWOVDAxDqFW0xro/d/a/E?=
 =?us-ascii?Q?bcch81oD2HJC2T/dO0zM1FvCeNScbt8Kr+K6R1q0D1ILaQEd6gqQBhU1hJX9?=
 =?us-ascii?Q?TxRrySYpQPZ+m9sYvEgzRiMT1UUrBIaaGS69qOUsXqvCacwPZW8wS1u4dI8/?=
 =?us-ascii?Q?c+4quAlcCRv9MJbQ79KdIRc6?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E2DF6FE6CECFCA4AB29049C24EC8C8AE@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72393115-a217-4268-9b92-08d962513648
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2021 14:05:19.1447
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jHn3w2zWuC9eocdAuMim94pfzsy1nlQmhkPFmjejcj4OSs+CU47f396A8xhouc1oIXnjWnWpsfh6/ldSakTtmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7470
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 18, 2021 at 02:19:15PM +0800, Xiaoliang Yang wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>=20
> ocelot_mact_write() can be used for directly modifying an FDB entry
> situated at a given row and column, as opposed to the current
> ocelot_mact_learn() which calculates the row and column indices
> automatically (based on a 11-bit hash derived from the {DMAC, VID} key).
>=20
> ocelot_mact_lookup() can be used to retrieve the row and column at which
> an FDB entry with the given {DMAC, VID} key is found.
>=20
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---

This patch needs your Signed-off-by tag too.
And I think the functions need their prototype defined in a header too,
otherwise the compiler will complain that they are unused and that they
are non-static but also no previous prototype.=