Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp517859pxb; Wed, 18 Aug 2021 07:38:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwCb0dlnD/88HwsNDtDsmUWoFsQURLGq+pBD72wFVFuy8fB6H6f9kIigVF2rqytHyNw3Kdh X-Received: by 2002:a05:6e02:e51:: with SMTP id l17mr6411334ilk.73.1629297520792; Wed, 18 Aug 2021 07:38:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629297520; cv=none; d=google.com; s=arc-20160816; b=NzIouhYmeQR1iGfQCu2CzqQpArxR52k842UIM8SFYwnXgigAmbBVdqhqT6XhsZVtwN MmjpWRdDQNpAm1LePulLknVelhCWK0slcTE8evx7iHPHmbYwEwqvRWD0ZPio4r77BV8c 3uQTVffpV0djdFiOhQdjXNSRyehx+YjuqXE4/GIo0UhVKvjWaBy35gcQDyfYdnOhTYDr eySBhkQB8gnvDpA4SUEFgz4ukdeyU2TMLpljy9zBCUa8YIX4qrCJ8f8z1vBjLHgJ2ECK bC0y+p6Ng5dDHIimVspQcKlU5Wj12NuBeqIHg57KDSJzF/6AYAzz3KqagEI3n6t+qILl +FpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=DdKLdhAacd6jEcx4/uoOMXDlLQ6GRmYS28Jj+6JTvrA=; b=b9Wq32zLQLSxtNFGEgIsuMZjVheyT+JIZBcT8p+oT4++QYmyoT98nrgTsMv1QB0s3P 3VL+3y2HuMQDn18A4zOs2KTP0AA0/qq1jHeflNTfbAr1UCnWXb3/XYDLUIPL/pcQAgv7 0TcyRAp3ai52oeYSurflLX6gIMjIeU+ZTVXEFUX2aPUqRfH2JModqqP6pyd1Na9iVhV4 JbGQ4J/9rRwelkNM16iOa82v7JQlaBWvOLM9uGH/4c0NtK4QWOCc339IRqF/eYcA046p XD8NdUKMmtbkPE/48KwUJh9iIBRX2QiAliWK7QElFDxspTIZqjjKKq44cfhetjWgj9su 4G2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Jk+AIBzh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 11si1190ilq.55.2021.08.18.07.38.28; Wed, 18 Aug 2021 07:38:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Jk+AIBzh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238662AbhHROh5 (ORCPT + 99 others); Wed, 18 Aug 2021 10:37:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:41250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237927AbhHROhz (ORCPT ); Wed, 18 Aug 2021 10:37:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 42E4B610CB; Wed, 18 Aug 2021 14:37:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1629297440; bh=sq3THO01fYmhpHJuXoAHw1MIoL0xlYlPOhjB/eQF+2c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jk+AIBzhfhB9WC4Pk0esN1ayqon6I6ue7BZk4o0gJAc0M3kp/fkCm/r90zLYu+O+Y iNpbMra5xHKVzc5pg8ivqjm9zy8DPFCA7JGWZ2t6HKYkWSP49Xx1W/fwlCR8J0C0bj Xkl7YTct2H+p4m662kKbemb24XJi88ivpOYRyA6w= Date: Wed, 18 Aug 2021 16:37:18 +0200 From: Greg KH To: sidraya.bj@pathpartnertech.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, prashanth.ka@pathpartnertech.com, praneeth@ti.com, mchehab@kernel.org, linux-media@vger.kernel.org, praveen.ap@pathpartnertech.com Subject: Re: [PATCH 02/30] v4l: vxd-dec: Create mmu programming helper library Message-ID: References: <20210818141037.19990-1-sidraya.bj@pathpartnertech.com> <20210818141037.19990-3-sidraya.bj@pathpartnertech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210818141037.19990-3-sidraya.bj@pathpartnertech.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 18, 2021 at 07:40:09PM +0530, sidraya.bj@pathpartnertech.com wrote: > From: Sidraya > > The IMG D5520 has an MMU which needs to be programmed with all > memory which it needs access to. This includes input buffers, > output buffers and parameter buffers for each decode instance, > as well as common buffers for firmware, etc. > > Functions are provided for creating MMU directories (each stream > will have it's own MMU context), retrieving the directory page, > and mapping/unmapping a buffer into the MMU for a specific MMU context. > > Also helper(s) are provided for querying the capabilities of the MMU. > > Signed-off-by: Buddy Liong > Signed-off-by: Angela Stegmaier > Signed-off-by: Sidraya > --- > MAINTAINERS | 2 + > drivers/staging/media/vxd/common/imgmmu.c | 782 ++++++++++++++++++++++ > drivers/staging/media/vxd/common/imgmmu.h | 180 +++++ Why are you adding new stuff to staging? Why can it not just go to the "real" part of the kernel? If it is to go into staging, we need a TODO file that lists what needs to be done to get it out of staging. thanks, greg k-h