Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 18 Aug 2021 16:40:03 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Icenowy Zheng <icenowy@aosc.io>
Cc:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Guenter Roeck <linux@roeck-us.net>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tcpm: always rediscover when swapping DR
Message-ID: <YR0bw+k0S94cmeDS@kroah.com>
References: <20210813043131.833006-1-icenowy@aosc.io>
 <YRuDG78N2mB5w37p@kuha.fi.intel.com>
 <E91C97D0-7DB9-4455-AED2-4C25B7D2D22D@aosc.io>
 <YRuW0fENBEcIVkZb@kuha.fi.intel.com>
 <YR0Rlj+jk9dnoG6N@kroah.com>
 <E1804EE0-CBA1-4BE8-875B-57E82EDECDBE@aosc.io>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <E1804EE0-CBA1-4BE8-875B-57E82EDECDBE@aosc.io>
Precedence: bulk

On Wed, Aug 18, 2021 at 10:02:24PM +0800, Icenowy Zheng wrote:
> 
> 
> 于 2021年8月18日 GMT+08:00 下午9:56:38, Greg Kroah-Hartman <gregkh@linuxfoundation.org> 写到:
> >On Tue, Aug 17, 2021 at 02:00:33PM +0300, Heikki Krogerus wrote:
> >> > >Why is it necessary to do discovery with data role swap in general?
> >> > 
> >> > I think it could be possible for devices to expose different altmode
> >> > with different role.
> >> 
> >> OK. FWIW:
> >> 
> >> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >
> >Is this conflicting with https://lore.kernel.org/r/20210816075449.2236547-1-kyletso@google.com ?
> >
> >Which of these two should I take, both?  Neither?
> 
> Don't take this, it's against spec.

Ok, now dropped.  What about the linked patch above?  Does that work for
you instead?

thanks,

greg k-h