Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "allan.nielsen@microchip.com" <allan.nielsen@microchip.com>,
        "joergen.andreasen@microchip.com" <joergen.andreasen@microchip.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "vinicius.gomes@intel.com" <vinicius.gomes@intel.com>,
        "michael.chan@broadcom.com" <michael.chan@broadcom.com>,
        "vishal@chelsio.com" <vishal@chelsio.com>,
        "saeedm@mellanox.com" <saeedm@mellanox.com>,
        "jiri@mellanox.com" <jiri@mellanox.com>,
        "idosch@mellanox.com" <idosch@mellanox.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "kuba@kernel.org" <kuba@kernel.org>, Po Liu <po.liu@nxp.com>,
        Leo Li <leoyang.li@nxp.com>
Subject: Re: [RFC v2 net-next 3/8] net: mscc: ocelot: set vcap IS2 chain to
 goto PSFP chain
Thread-Topic: [RFC v2 net-next 3/8] net: mscc: ocelot: set vcap IS2 chain to
 goto PSFP chain
Thread-Index: AQHXk/d8w12R5e6WKU6VaUMTnYcT/6t5WfyA
Date:   Wed, 18 Aug 2021 14:54:35 +0000
Message-ID: <20210818145435.bsbxuq7bbjr4fkel@skbuf>
References: <20210818061922.12625-1-xiaoliang.yang_1@nxp.com>
 <20210818061922.12625-4-xiaoliang.yang_1@nxp.com>
In-Reply-To: <20210818061922.12625-4-xiaoliang.yang_1@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?e15FeqcUmItcu1luLbk8iqzA1qUzNxA9t5v2yGWLM24bartU6Gzok5JEyX1a?=
 =?us-ascii?Q?vz8hYfws4lHfnZ7+wVSkUa1YmUriO2Bd30CrIDPaAcEkMSbL3tumFccU3dJk?=
 =?us-ascii?Q?nKHYGd2CT4od+jzMPSPZxVuISPVlXfgbGIMQO2yMwlH6I+HsjOMp/zDrnde9?=
 =?us-ascii?Q?eLJKHsxvB0iM4e5lHYbjyRggcx8dfcaDNEhinfgQY4gTg0lNFstABQFm6awu?=
 =?us-ascii?Q?coz7j2oC/RhFLYz6hxOqsXa5DthIEZM1GL5fRDZeep38Fwi8tZizTkw4VYpK?=
 =?us-ascii?Q?FU7em3ohTuXC2Yd69pK9SvEY/G6vVKsFgpqM0Ckgc366ksr7DzvAbZMQH7RQ?=
 =?us-ascii?Q?4SaqKj2mScEEmXFPZF0KUkabdmls8GMm0Dlvh3drDQXmRitqoDrJLnqxM+GV?=
 =?us-ascii?Q?s1CHowHGpv0p/CTFUKFDQXEOlt1m82lSaf6OoaQs04n7rynqtAl81E4TJYtG?=
 =?us-ascii?Q?80dBiK3A6DC1AGRHx5dl410jqTat42+JEXvonu/oClFoy1WcFV1j+m3KdTOO?=
 =?us-ascii?Q?fjRxgQd0lEBqTGuaINxLi6ZGNZ+sm3gPVWNr8oJD3lf+d6AfyoXNV9Xk6Msp?=
 =?us-ascii?Q?HVmJHTG07vx9tguzro+hzYJfxPuOsxEEbBiX+4KzomJWkcGvvevEEAK4v97j?=
 =?us-ascii?Q?wkdG9T3TSmJw224k0ed0rXnssM8HvaiqjDZUSQNDwa2zHjKaZbk84OzaWEW9?=
 =?us-ascii?Q?C5cyT1jfLx1yx/TCOHK1BVKCodteCAbmUh3vanGlZX0irFRwAbKgC+w49JAo?=
 =?us-ascii?Q?V9k/n3bZ5FS8Za6+GdmxK2R57AbkKC85g1b5CCBS4jbZGQbb6DTYKK0Ua7mw?=
 =?us-ascii?Q?HQrn2hPx5osxAHJwazZUkonnge0ixLzaXocf4peh4otpfI7gVMmWhqd9k2Wk?=
 =?us-ascii?Q?CeYVZ/rvYSODuI7fmgzvycPMyFsVcCZ7bY7rTiQ8YcPT7Y22c3iQV+HXvh4n?=
 =?us-ascii?Q?7JOt2nP5CjABax6Sk8Ekd8KsD1baroJNgpSXMawnV6hjRYxjUKJdXLxbXXeh?=
 =?us-ascii?Q?SgxABHf+sX8bRFrCYzJJi7R7b1FDt39FM9Xfs5hihRpcyXcezcxyAk0FB1m3?=
 =?us-ascii?Q?h9dGAS94/KdZAv0fCLxfIOJCoczeIahfzq5LOO7T6jks+QIvbtVvuCQXuF5A?=
 =?us-ascii?Q?sALlf0MgrS6PEfq/vpl3Q88wIlCPezrPawuXOZXFauuUahaewNHNOL0sLGOF?=
 =?us-ascii?Q?Hnz9bSootYZYxhRtR892xRfzgLuN5rFY5qaWl57FBO1I9NDQ7gMiG/zWvNu1?=
 =?us-ascii?Q?eggZ7bVHxupRd7NjrDh7Uk1EFHkAeopfXRNcuZbimtVtFaCBcRHA6v32e79w?=
 =?us-ascii?Q?AsMMVBw11DSHIGTSpLSvhz0I?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <827A99EB718D2E46812A01C820EC38CA@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5a833db-7ef2-4732-61fb-08d9625818aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2021 14:54:35.9139
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uNrWU/NrD5fsMw6rxWu7tubthq4TnstV/qiPijFIS1y+b8ob0Ol25bnPr6n0BO/pCpX8pe/Ilpv9euUMiCfjjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3200
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 18, 2021 at 02:19:17PM +0800, Xiaoliang Yang wrote:
> @@ -353,7 +364,7 @@ static int ocelot_flower_parse_action(struct ocelot *=
ocelot, int port,
> =20
>  	if (filter->goto_target =3D=3D -1) {
>  		if ((filter->block_id =3D=3D VCAP_IS2 && filter->lookup =3D=3D 1) ||
> -		    chain =3D=3D 0) {
> +		    chain =3D=3D 0 || filter->block_id =3D=3D PSFP_BLOCK_ID) {
>  			allow_missing_goto_target =3D true;

I would like to not allow missing "goto" targets for new filter chains.

Due to legacy support we must keep support for VCAP IS2 on chain 0, but
ever since we added the ability to offload multiple chains corresponding
to multiple hardware blocks, we should really use that precise chain ID,
and chain 0 should just goto the first used chain in the pipeline.

Makes sense?

>  		} else {
>  			NL_SET_ERR_MSG_MOD(extack, "Missing GOTO action");
> --=20
> 2.17.1
>=20