Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "allan.nielsen@microchip.com" <allan.nielsen@microchip.com>,
        "joergen.andreasen@microchip.com" <joergen.andreasen@microchip.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "vinicius.gomes@intel.com" <vinicius.gomes@intel.com>,
        "michael.chan@broadcom.com" <michael.chan@broadcom.com>,
        "vishal@chelsio.com" <vishal@chelsio.com>,
        "saeedm@mellanox.com" <saeedm@mellanox.com>,
        "jiri@mellanox.com" <jiri@mellanox.com>,
        "idosch@mellanox.com" <idosch@mellanox.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "kuba@kernel.org" <kuba@kernel.org>, Po Liu <po.liu@nxp.com>,
        Leo Li <leoyang.li@nxp.com>
Subject: Re: [RFC v2 net-next 4/8] net: mscc: ocelot: add gate and police
 action offload to PSFP
Thread-Topic: [RFC v2 net-next 4/8] net: mscc: ocelot: add gate and police
 action offload to PSFP
Thread-Index: AQHXk/d9N+Eb4ZR7QkSKrssyK5QJaKt5W76A
Date:   Wed, 18 Aug 2021 15:00:54 +0000
Message-ID: <20210818150053.numtnvntscxcm6r4@skbuf>
References: <20210818061922.12625-1-xiaoliang.yang_1@nxp.com>
 <20210818061922.12625-5-xiaoliang.yang_1@nxp.com>
In-Reply-To: <20210818061922.12625-5-xiaoliang.yang_1@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dCxwsfWIB7Aha/AyLWkRDnRcX5GPncGRbY37/hyBxOl5CUrp8XM2YP48RH3J?=
 =?us-ascii?Q?/BiArM/06xFs96vOtHELZLCanYufD7N6Kxtwjw5ssQXXcaoP1uZoSEP1jqo5?=
 =?us-ascii?Q?+GftwSe/slNReMICa3LuZHVSZsIHZ5/HF4LlETI2GRReP77QSva55txGHWXC?=
 =?us-ascii?Q?aP4TggH2EE3urrfP9IZhd1RdP1aSzWIyqvzjs/0p7L/XlkpciW/l+GJM46P6?=
 =?us-ascii?Q?oPcP5sIkibby92Tzqd8ZaKsLmUQLqiTmCrzVBPvlW4rAG9cSpggLK2q1LUsp?=
 =?us-ascii?Q?pXCk6a+OiUn0sJk7DRBjagPLO6boZYJBvaMeEk7zp7XO1mfWYgiHzuMlcj8f?=
 =?us-ascii?Q?1p/YwdgUXzmR0TUG/XVFatFTrIqa7ToWsNcRJovLji4y1j6xiClNHc8DbefG?=
 =?us-ascii?Q?gbAe2OVh/1W5RvzeFkUh3Kr3XvGHEY2PrbNMPpQFZEWlXEqIZvxtfgdV02W6?=
 =?us-ascii?Q?uLqKmXMIYIvTzeNFSNqu50DbfM4/ddOoAFPpEaxRy4DhqbcspC/uce8d5rEp?=
 =?us-ascii?Q?5Q1gXUlTo9fi79ZB0Zlsxcxh7yraQ7IhxL7laP7NymaeOn3WmuEfsj9tPG6/?=
 =?us-ascii?Q?BsapqlKApaa8VkZWZIgbOhSL4UkkR6HdQ7yYlivm4sP49zglbgDQdc/shmOp?=
 =?us-ascii?Q?FjpW/LgL8SAMRhbGU1Bg/rj+opYrRbtpPqZtvURVKDs849lfFiJ3jx7BoMw7?=
 =?us-ascii?Q?lkRcp3XHze1aOgOND3XRoy3s3LRD50+SkY70DxKBUPQIMksgGlKaWReWrZIG?=
 =?us-ascii?Q?m7RTv+DLeYCzHJsbovTi/WFB3KW/9aFFYKMTazhX9CH2hSxvUWvzSB2g2cXG?=
 =?us-ascii?Q?G9VodObL7hvHienFtu3TGZqpG92hfwtnfQoUNxtoSXnUgU6fP5FRAdEi2wzT?=
 =?us-ascii?Q?xhwemHE81uH0LzTAt1eJFaDCyRwbvzo/PVXf8YFBQnxWrm5frO3eOZ1M36xb?=
 =?us-ascii?Q?/mmSbvG0LttBT7/ybAoSKbGO9yWOeLD3oYD9L8YJPVX3BEmfQnhJM4qp8sRm?=
 =?us-ascii?Q?mPt7w0wJjHh7MMccbztYo3XpcAoG3iXcrAN45QsWsX2zDr6gvlNqncsL0ima?=
 =?us-ascii?Q?6w7li3GYnrAkvNhCHrRN1RGYVJmdfPLKihR5FL7hnPZ+IdK77LlQ76KXd+TL?=
 =?us-ascii?Q?sD9fRbYvtMwXOQLwv6B068jw6ydr5x5OgMFsL47OsRtNX2N/ocEad4qtCiiy?=
 =?us-ascii?Q?t1b6kG5wj5rXHv+D5RwWxC2SMqcXCOchPWq13eNaSPjlxk4CgEGqnjd43tg2?=
 =?us-ascii?Q?g7JhW6GzTrIouuqOXUcBBq8xC+f99nrMSt41PT3aCZyc6JiOoUInHCouJ5QE?=
 =?us-ascii?Q?FyhgAz8zl4K/S6KFqPzTkJnv?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <97BCAAEBE5AA3642929D3EFB0515A8B8@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e333ef86-dc42-47f2-6d58-08d96258fa2d
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2021 15:00:54.2701
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +RDexaAnZ0Oss0FaF15LcqCuznxkF6TBwW+24kmH+vcym3Y9hk5MqrLVcMA/1PTdwfg8ifQ6wznV0K7Ppb9cMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3199
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 18, 2021 at 02:19:18PM +0800, Xiaoliang Yang wrote:
> @@ -718,6 +734,15 @@ int ocelot_cls_flower_replace(struct ocelot *ocelot,=
 int port,
>  	if (filter->type =3D=3D OCELOT_VCAP_FILTER_DUMMY)
>  		return ocelot_vcap_dummy_filter_add(ocelot, filter);
> =20
> +	if (filter->type =3D=3D OCELOT_PSFP_FILTER_OFFLOAD) {
> +		kfree(filter);
> +		if (ocelot->ops->psfp_filter_add)
> +			return ocelot->ops->psfp_filter_add(ocelot, f);
> +
> +		NL_SET_ERR_MSG_MOD(extack, "PSFP chain is not supported in HW");
> +		return -EOPNOTSUPP;
> +	}
> +
>  	return ocelot_vcap_filter_add(ocelot, filter, f->common.extack);
>  }

Hmm, I don't really like the idea of allocating an ocelot_vcap_filter
which we don't need for PSFP filters, just to kfree it later.

Is it that much more complicated to not allocate it at all in the first
place, add a bunch of "if" conditions that allocate a VCAP filter only
if we are offloading a VCAP chain?

And that means, don't create ocelot_vcap_filter::type =3D=3D OCELOT_PSFP_FI=
LTER_OFFLOAD,
because PSFP filters are not VCAP filters.=