From: Ian Campbell <ijc@hellion.org.uk>
To: John Stultz <johnstul@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-sqPSaArBnPVtZTHD/JJA"
Date: Sun, 03 Dec 2006 13:50:34 +0000
Message-Id: <1165153834.5499.40.camel@localhost.localdomain>
Mime-Version: 1.0
Subject: PMTMR running too fast
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2255
Lines: 61


--=-sqPSaArBnPVtZTHD/JJA
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

In older kernels arch/i386/kernel/timers/timer_pm.c:verify_pmtmr_rate
contained a check for sensible PMTMR rate and disabled that clocksource
if it was found to be out of spec[0]. This check seems to have been lost
in the transition to drivers/clocksource/acpi_pm.c, the removal is in
61743fe445213b87fb55a389c8d073785323ca3e "Time: i386 Conversion - part
4: Remove Old timer_opts Code"[1] and the check is not present in the
replacement 5d0cf410e94b1f1ff852c3f210d22cc6c5a27ffa "Time: i386
Clocksource Drivers"[2].

Is there a specific reason the check was removed (I couldn't see on in
the archives) or was it simply overlooked? Without it I need to pass
clocksource=3Dtsc to have 2.6.18 work correctly on an older K6 system with
an Aladdin chipset (will dig out the precise details if required). Would
a patch to reintroduce the check be acceptable or would some sort of
blacklist based solution be more acceptable?

Cheers,
Ian.

[0] "PM-Timer running at invalid rate: 200% of normal - aborting." from
http://www.kernel.org/git/?p=3Dlinux/kernel/git/tglx/history.git;a=3Dcommit=
;h=3D6d58b1286c7ac88741374c158867f564e602b288
see also http://bugme.osdl.org/show_bug.cgi?id=3D2375
[1]
http://www.kernel.org/git/?p=3Dlinux/kernel/git/torvalds/linux-2.6.git;a=3D=
commit;h=3D61743fe445213b87fb55a389c8d073785323ca3e
[2]
http://www.kernel.org/git/?p=3Dlinux/kernel/git/torvalds/linux-2.6.git;a=3D=
commit;h=3D5d0cf410e94b1f1ff852c3f210d22cc6c5a27ffa

--=20
Ian Campbell

Any time things appear to be going better, you have overlooked something.

--=-sqPSaArBnPVtZTHD/JJA
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQBFctYqM0+0qS9rzVkRAk0gAKDJB6C9GQhIvUTiUcxMAAYpgtnXogCgjr48
KlG8z8VYSLyFyOYQ8Y+I+gg=
=e9Sk
-----END PGP SIGNATURE-----

--=-sqPSaArBnPVtZTHD/JJA--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/