Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210813043131.833006-1-icenowy@aosc.io> <YRuDG78N2mB5w37p@kuha.fi.intel.com>
 <E91C97D0-7DB9-4455-AED2-4C25B7D2D22D@aosc.io> <YRuW0fENBEcIVkZb@kuha.fi.intel.com>
 <YR0Rlj+jk9dnoG6N@kroah.com> <E1804EE0-CBA1-4BE8-875B-57E82EDECDBE@aosc.io> <YR0bw+k0S94cmeDS@kroah.com>
In-Reply-To: <YR0bw+k0S94cmeDS@kroah.com>
From:   Kyle Tso <kyletso@google.com>
Date:   Thu, 19 Aug 2021 00:13:15 +0800
Message-ID: <CAGZ6i=2a6ueLghhDTPCP_gumZ=HUYWRLCKkveyVnNQLgP+zyow@mail.gmail.com>
Subject: Re: [PATCH] usb: typec: tcpm: always rediscover when swapping DR
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Icenowy Zheng <icenowy@aosc.io>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Guenter Roeck <linux@roeck-us.net>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Aug 18, 2021 at 10:40 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Aug 18, 2021 at 10:02:24PM +0800, Icenowy Zheng wrote:
> >
> >
> > =E4=BA=8E 2021=E5=B9=B48=E6=9C=8818=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=
=889:56:38, Greg Kroah-Hartman <gregkh@linuxfoundation.org> =E5=86=99=E5=88=
=B0:
> > >On Tue, Aug 17, 2021 at 02:00:33PM +0300, Heikki Krogerus wrote:
> > >> > >Why is it necessary to do discovery with data role swap in genera=
l?
> > >> >
> > >> > I think it could be possible for devices to expose different altmo=
de
> > >> > with different role.
> > >>
> > >> OK. FWIW:
> > >>
> > >> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > >
> > >Is this conflicting with https://lore.kernel.org/r/20210816075449.2236=
547-1-kyletso@google.com ?
> > >
> > >Which of these two should I take, both?  Neither?
> >
> > Don't take this, it's against spec.
>
> Ok, now dropped.  What about the linked patch above?  Does that work for
> you instead?
>
> thanks,
>
> greg k-h

Hi Icenowy,

Could you revisit the patch for the tcpm_unregister_altmodes part?
I think that is still a problem.

thanks,
Kyle