Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 18 Aug 2021 19:09:13 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Jie Luo <luoj@codeaurora.org>
Cc:     Michael Walle <michael@walle.cc>, davem@davemloft.net,
        hkallweit1@gmail.com, kuba@kernel.org,
        linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
        netdev@vger.kernel.org, sricharan@codeaurora.org
Subject: Re: [PATCH] net: phy: add qca8081 ethernet phy driver
Message-ID: <YR0+uXdKoXrFEhpZ@lunn.ch>
References: <6856a839-0fa0-1240-47cd-ae8536294bcd@codeaurora.org>
 <20210818074102.78006-1-michael@walle.cc>
 <9aa1543b-e1b8-fba2-1b93-c954dd2e3e50@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9aa1543b-e1b8-fba2-1b93-c954dd2e3e50@codeaurora.org>
Precedence: bulk

On Wed, Aug 18, 2021 at 09:34:40PM +0800, Jie Luo wrote:
> 
> On 8/18/2021 3:41 PM, Michael Walle wrote:
> > > qca8081 supports IEEE1588 feature, the IEEE1588 code may be submitted in
> > > the near future,
> > > 
> > > so it may be a good idea to keep it out from at803x code.
> > The AR8031 also supports PTP. Unfortunately, there is no public datasheet
> > for the QCA8081, so I can't have a look if both are similar.
> > 
> > See also,
> > https://lore.kernel.org/netdev/20200228180226.22986-1-michael@walle.cc/
> > 
> > -michael
> 
> Hi Michael,
> 
> Thanks for this comment. it is true that AR8031 supports basic PTP features.
> 
> please refer to the following link for the outline features of qca801.
> 
> https://www.qualcomm.com/products/qca8081

Is the PTP hardware in the qca8081 the same as the ar8031? When you
add PTP support, will it be for both PHYs?

What about the cable diagnostics? The at803x already has this
implemented. Will the same work for the qca8081?

    Andrew