Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp782242pxb; Wed, 18 Aug 2021 14:10:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGrLNOGO3JMyjigizbijQEIsIrxKMT28QM9iFvsXg4MaMivOMJAMBB7sfJXIj7gZ5b6zbo X-Received: by 2002:a6b:6319:: with SMTP id p25mr8813027iog.100.1629321029005; Wed, 18 Aug 2021 14:10:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629321028; cv=none; d=google.com; s=arc-20160816; b=Nxj7iHaXEYMgX7mmo42GepRWmTYDhBImTO5Yt1yYWYbyWC02mHqacc26XWATHufRnB fyPl07Ydh8LxixUw8v04r4UIyzMfVk1Zsc7E3rnFSiEEkK0smakyU+sYWpZF5HriXasA 3gsPSVP/Pxy38U52lXYiFMGO1THuutreVDWB4OUMQ8vApy+7klCbQwdkpSnPnmSFwalo Spr8Y0WYlXSLf5P9nkG0C+/kcPbkmIWEL0lTGKXHL1YWCpGm5C7rFPaHEMbwAiesy/Zi NPUlroqb6Y9xiwwtUVkFMCLD39YGUXSWUDY6jrzpAT4qkVpHz1sXGAlDTlcCcjMgRGRI hdUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=wwOBCn06TMZp9/KiQNhcPCCoJYBDD2eVjvlRxAvYXb4=; b=Qfc1eJ6ozSKbrhTcn0xems5g9YognsvxaECAZBFlMrNz0oUCkiOHYoBJ2g2urSVweB vLefdRxm/Vp5VVd2L/4NXARjpgu+S+jc8giS6MDtcvu+eTTGDYmGZ0j0amhkXi67cNvP y+c1JhIaHdbcf8gayznRHWRrFu11K7YGRqIKvwF3rqGxGcH26QPhNnO8UeGOe5aIK4aQ joW9/5ZyGJzYKX0O2F3u8KOFsEcTcPLIITl9S6A3oQC+Yd1IfMYpgEs25/wLp/GYQENJ Xzfp9eldpoY13TE0lYO79PpkDNivezqeZKq5pI8kQpJrvcKJBE23jxxrS/lcxaU8sahU Giug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=FHcs1Em0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si799422jat.29.2021.08.18.14.10.17; Wed, 18 Aug 2021 14:10:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=FHcs1Em0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233807AbhHRVIA (ORCPT + 99 others); Wed, 18 Aug 2021 17:08:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229965AbhHRVH6 (ORCPT ); Wed, 18 Aug 2021 17:07:58 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EE69C061764 for ; Wed, 18 Aug 2021 14:07:23 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id 18so3459653pfh.9 for ; Wed, 18 Aug 2021 14:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wwOBCn06TMZp9/KiQNhcPCCoJYBDD2eVjvlRxAvYXb4=; b=FHcs1Em0hv3sy2oL9DRDduqIWHymNzWWGDKUh1cGcBpzbwOAgQ2qV+pCau8hiiLRog ThoUyrgJMBA8bC5BP2v2Lu7MKhhJW3tNa5J2i6OTqExsFKf7jEekYrXlGi82ZeYih3mU 247c1eSFpDfFvs2hzHvF5owMPlvNNsopEXIz3w9kVz2o8c/zp3bhiuANwvAKTy1SjKbc Ji9oRIzoraO6THCTblL6xWiAvrvRpwvZ3lJShrVcEkzkA7xnJ21FHoPQkRhU87nkqHQC u1Dp1ggIcZUgKErF4/AtcHNBxhQLaPVORGDAuJd9j52MZJ3OJcKBW+7O7U77YKgaI0uz /8Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wwOBCn06TMZp9/KiQNhcPCCoJYBDD2eVjvlRxAvYXb4=; b=F8+oymdjMO31yKb0Gjp3isiWG6L+rMWQO3jiwuMAqXBleWcPRsWfwAHYX97h8C+o9Z aZ5Sxwm2A3/UOG+9hTrkI1RiRnp8q5OWLiQDgoX/unJLown6wn8Lkuu8rrkhepxdXG72 etRGP5NSfUPh/S2HDJYY+rH2LqSYmn8eYf7Bw3xvZ6OIGYwVQo4QV/nG7qx/lq+3Mqvo uK29sUyRoOANJisPXk9JeqV1GdfHxig+qC2GZQy4w4moknQWLdUV6Lbfs8ajjV1A6WL2 qDRMRBo62rvZK9MgCvk+6rd/b/zQUWPwY2kZZEAUAmWGfPD5MQVYhes8SMTDP/L6RJfD /4fg== X-Gm-Message-State: AOAM530rYPHulomegZ+LQsb+PZfCYHwi3KxQ5Bz2b05PDfLp3o02wTeM HIF/CIHrZVJIQrPXOk3GnZ9heBTJO/Fx10SJfiKu4Q== X-Received: by 2002:a63:ce57:: with SMTP id r23mr10716345pgi.271.1629320842594; Wed, 18 Aug 2021 14:07:22 -0700 (PDT) MIME-Version: 1.0 References: <1297c0dd3f1bb47a6d089f850b629c7aa0247040.1629257115.git.houwenlong93@linux.alibaba.com> In-Reply-To: <1297c0dd3f1bb47a6d089f850b629c7aa0247040.1629257115.git.houwenlong93@linux.alibaba.com> From: Jim Mattson Date: Wed, 18 Aug 2021 14:07:11 -0700 Message-ID: Subject: Re: [PATCH] kvm: fix wrong exception emulation in check_rdtsc To: Hou Wenlong Cc: kvm@vger.kernel.org, Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Avi Kivity , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 17, 2021 at 8:36 PM Hou Wenlong wrote: > > According to Intel's SDM Vol2 and AMD's APM Vol3, when > CR4.TSD is set, use rdtsc/rdtscp instruction above privilege > level 0 should trigger a #GP. > > Fixes: d7eb82030699e ("KVM: SVM: Add intercept checks for remaining group7 instructions") > Signed-off-by: Hou Wenlong Reviewed-by: Jim Mattson