Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thiago Macieira <thiago.macieira@intel.com>
To:     "Bae, Chang Seok" <chang.seok.bae@intel.com>
CC:     Borislav Petkov <bp@alien8.de>,
        "Lutomirski, Andy" <luto@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@kernel.org" <mingo@kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "Brown, Len" <len.brown@intel.com>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        "Liu, Jing2" <jing2.liu@intel.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 12/26] x86/fpu/xstate: Use feature disable (XFD) to protect dynamic user state
Date:   Wed, 18 Aug 2021 15:27:35 -0700
Message-ID: <2658618.gP76fVu5Ab@tjmaciei-mobl5>
Organization: Intel Corporation
In-Reply-To: <C3EBA85C-8708-4BAD-BB78-C975250BEFFF@intel.com>
References: <20210730145957.7927-1-chang.seok.bae@intel.com> <3399412.qF98CnctbS@tjmaciei-mobl5> <C3EBA85C-8708-4BAD-BB78-C975250BEFFF@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wednesday, 18 August 2021 14:12:06 PDT Bae, Chang Seok wrote:
> On Aug 18, 2021, at 14:04, Thiago Macieira <thiago.macieira@intel.com>
> wrote:
> > But it's not the only possible solution. A future kernel could decide to
> > leave some bits off and only enable upon request. That's how
> > macOS/Darwin does its AVX512 support.
> 
> 
> Even if XCR0 is ever switched, doesn’t XGETBV(0) return it for the
> *current*  task?

That's the point. If the kernel decides that feature bit 19 will be left off 
in XCR0, how shall userspace know the kernel supports the feature through the 
arch_prctl syscall you added?

Not that I am advising we adopt this strategy. We don't need more 
fragmentation on how we enable the features. But having this syscall gives us 
flexibility in case we do need it in the future.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel DPG Cloud Engineering