Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760029AbWLCTSR (ORCPT ); Sun, 3 Dec 2006 14:18:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760026AbWLCTSR (ORCPT ); Sun, 3 Dec 2006 14:18:17 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:34265 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1760022AbWLCTSQ (ORCPT ); Sun, 3 Dec 2006 14:18:16 -0500 Subject: Re: [RFC] rfkill - Add support for input key to control wireless radio From: Arjan van de Ven To: Ivo van Doorn Cc: Dmitry Torokhov , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, John Linville , Jiri Benc , Lennart Poettering , Johannes Berg , Larry Finger In-Reply-To: <200612031936.34343.IvDoorn@gmail.com> References: <200612031936.34343.IvDoorn@gmail.com> Content-Type: text/plain Organization: Intel International BV Date: Sun, 03 Dec 2006 20:18:02 +0100 Message-Id: <1165173482.3233.240.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1.1 (2.8.1.1-3.fc6) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 22 On Sun, 2006-12-03 at 19:36 +0100, Ivo van Doorn wrote: > + > + down(&master->key_sem); > + Hi, this one seems to be used as a mutex only, please consider using a mutex instead, as is the default for new code since 2.6.16 or so.... Greetings, Arjan van de Ven -- if you want to mail me at work (you don't), use arjan (at) linux.intel.com Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/