Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp201348pxb; Wed, 18 Aug 2021 20:04:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz139L8RWleYRGi4iUyuXcxRIc0UjwT8j0CTUYnqVHCpMHxKsWgn4aTJjy+2ZQATiLjz5Fi X-Received: by 2002:a05:6638:2384:: with SMTP id q4mr11042463jat.54.1629342250249; Wed, 18 Aug 2021 20:04:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629342250; cv=none; d=google.com; s=arc-20160816; b=lPw74paleXbUek6gyRJFCNynP1kd5kxjQWQx+65QkItD+eQ37MnKHYHAICzG64HxtM woQv/8KpRkC3MEniTTE8O03dT8Jm9CXul5nJi8cViCfUgWHvzT/SOW2Et7Wwuai7yR75 r4ZUDrS+AiDzjLa3+ajdx6O0bJ0Wt1fSfn3tnSXO3PEpjlenT3jLXPlVz6bSr5wpmOyp ecELmqenryArrzGGaPYWq5xNc9MPNvrt7WrXm5shVFXvTcj8mhKy8/chcHYYee8TbJho qR2BbxAaCU0nGJeKH++4BanvYfKfchKL/VVFI41yhDlO1lnGeVgv7cwp4zbvGNlONYrf cycw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from:dmarc-filter :sender:dkim-signature; bh=X9c47q9KsAKLzObcQi9T06HPNpn6+cA5pyUoKac/UKw=; b=ocAKWUgUsJApUXwQv0zcm5uJvHH58E4exPQyeTpdueoB7LEVBcM42qIaX+BdiuzAbi OroEYlcNJ/Le7hgVpqmuTSX2urLMyy23+iEMxVZ2bj/b34dZI3OluHy+lrKOQVy2LIW8 qF0TaRIYCQ4aW3OyQKipCIXMFaILXd/PCheGVy6Spb6S4zVS8gIleA6Xz/kg/fHpx3di /Wi5YfEmVRIxkTmmBj6/XpnTh6cYHC4CC0znaw+kGnXA10aF1aDObR7NM9C7+MEkCJmT JIC3zCuY6Npw1XByfoszbCo1BeGLofdu75xvzfathbKY+PuytASsDJRaZSQYnIk3niv4 O3Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=P1cZ55HV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z41si1741115jah.89.2021.08.18.20.03.58; Wed, 18 Aug 2021 20:04:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=P1cZ55HV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235832AbhHSDDy (ORCPT + 99 others); Wed, 18 Aug 2021 23:03:54 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:56147 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235943AbhHSDDu (ORCPT ); Wed, 18 Aug 2021 23:03:50 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1629342194; h=Message-Id: Date: Subject: Cc: To: From: Sender; bh=X9c47q9KsAKLzObcQi9T06HPNpn6+cA5pyUoKac/UKw=; b=P1cZ55HVNlmfi8arAAQjslA0AH+nNrl78HCmg1ti1JoHunN5fiB/6txrjMB3O13W8uJVPtbt A+90y2nnqRq5ttIdrp13xu2y6CR/d4AyIb3DB1/GHydaMsEwa2nguCXTR0gHXqtQjag9bEai ngUk63EcaWjU/zOMBncSKtU5a50= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 611dc9ec66ff1079042743b0 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 19 Aug 2021 03:03:08 GMT Sender: sibis=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 62906C43617; Thu, 19 Aug 2021 03:03:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from blr-ubuntu-87.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sibis) by smtp.codeaurora.org (Postfix) with ESMTPSA id E7D0FC4338F; Thu, 19 Aug 2021 03:03:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org E7D0FC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Sibi Sankar To: mka@chromium.org, swboyd@chromium.org, bjorn.andersson@linaro.org, robh+dt@kernel.org Cc: ulf.hansson@linaro.org, rjw@rjwysocki.net, agross@kernel.org, ohad@wizery.com, mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, rishabhb@codeaurora.org, sidgup@codeaurora.org, Sibi Sankar Subject: [PATCH v5 00/13] Use qmp_send to update co-processor load state Date: Thu, 19 Aug 2021 08:32:03 +0530 Message-Id: <1629342136-3667-1-git-send-email-sibis@codeaurora.org> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The power domains exposed by the AOSS QMP driver control the load state resources linked to modem, adsp, cdsp remoteprocs. These are used to notify the Always on Subsystem (AOSS) that a particular co-processor is up/down. AOSS uses this information to wait for the co-processors to suspend before starting its sleep sequence. These co-processors enter low-power modes independent to that of the application processor and the load state resources linked to them are expected to remain unaltered across system suspend/resume cycles. To achieve this behavior let's stop modeling them as power-domains and replace them with generic qmp_send interface instead. https://lore.kernel.org/lkml/20200913034603.GV3715@yoga/ Previous discussion on dropping power-domain support from AOSS QMP driver Depends on: qmp_send: https://patchwork.kernel.org/project/linux-arm-msm/cover/1629113954-14084-1-git-send-email-deesin@codeaurora.org/ V5: * Fixup power-domain count (patch 2). [Matthias] * Add WARN_ON on truncation, remove redundant initialization code, use dev_err_probe (patch 4). [Stephen] * Use devm_kstrdup, handle kstrdup failure due to no memory and set qmp to NULL when not available (patch 4). [Bjorn] V4: * Rebase patch 1 due to the aoss-qmp yaml conversion (Dropping Rb). * Commit message change and sc8180x co-processor addition to patch 2. [Rob/Bjorn] * Drop unused pdev and kfree the load state string in q6v5_deinit /probe path for patch 4. [Matthias] * Replaced "binding" with "property" across the series. [Matthias] * Commit message change and drop incorrect cleanup on cooling device probe failures. [Matthias] V3: * Misc. documentation fixes [patch 2]: - Reduce power-domain maxItems due to load_state pd removal - Combine compatibles where possible with the load_state pd removal - Fixup the qcom,qmp ref to phandle type V2: * load_state is currently broken on mainline so be safely dropped without side-effects. * Rebased on top of qmp_send v3 series. * Dropped R-b from Stephen and Rob on patch 3 due to the yaml conversion. * New patch [12] to drop unused aoss-qmp header. * Commit message update [patch 1] [Rob] * Reorder the series [Stephen] Sibi Sankar (13): dt-bindings: soc: qcom: aoss: Drop the load state power-domain dt-bindings: remoteproc: qcom: pas: Add QMP property dt-bindings: remoteproc: qcom: Add QMP property remoteproc: qcom: q6v5: Use qmp_send to update co-processor load state arm64: dts: qcom: sc7180: Use QMP property to control load state arm64: dts: qcom: sc7280: Use QMP property to control load state arm64: dts: qcom: sdm845: Use QMP property to control load state arm64: dts: qcom: sm8150: Use QMP property to control load state arm64: dts: qcom: sm8250: Use QMP property to control load state arm64: dts: qcom: sm8350: Use QMP property to control load state soc: qcom: aoss: Drop power domain support dt-bindings: msm/dp: Remove aoss-qmp header dt-bindings: soc: qcom: aoss: Delete unused power-domain definitions .../bindings/display/msm/dp-controller.yaml | 1 - .../devicetree/bindings/remoteproc/qcom,adsp.yaml | 61 ++++++------ .../devicetree/bindings/remoteproc/qcom,q6v5.txt | 7 +- .../bindings/soc/qcom/qcom,aoss-qmp.yaml | 11 +-- arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 +- arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 - arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 +- arch/arm64/boot/dts/qcom/sm8150.dtsi | 28 +++--- arch/arm64/boot/dts/qcom/sm8250.dtsi | 22 ++--- arch/arm64/boot/dts/qcom/sm8350.dtsi | 30 +++--- drivers/remoteproc/qcom_q6v5.c | 57 ++++++++++- drivers/remoteproc/qcom_q6v5.h | 7 +- drivers/remoteproc/qcom_q6v5_adsp.c | 7 +- drivers/remoteproc/qcom_q6v5_mss.c | 44 ++------- drivers/remoteproc/qcom_q6v5_pas.c | 85 ++++------------ drivers/remoteproc/qcom_q6v5_wcss.c | 4 +- drivers/soc/qcom/qcom_aoss.c | 107 --------------------- include/dt-bindings/power/qcom-aoss-qmp.h | 14 --- 18 files changed, 183 insertions(+), 321 deletions(-) delete mode 100644 include/dt-bindings/power/qcom-aoss-qmp.h -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project