Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "allan.nielsen@microchip.com" <allan.nielsen@microchip.com>,
        "joergen.andreasen@microchip.com" <joergen.andreasen@microchip.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "vinicius.gomes@intel.com" <vinicius.gomes@intel.com>,
        "michael.chan@broadcom.com" <michael.chan@broadcom.com>,
        "vishal@chelsio.com" <vishal@chelsio.com>,
        "saeedm@mellanox.com" <saeedm@mellanox.com>,
        "jiri@mellanox.com" <jiri@mellanox.com>,
        "idosch@mellanox.com" <idosch@mellanox.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "kuba@kernel.org" <kuba@kernel.org>, Po Liu <po.liu@nxp.com>,
        Leo Li <leoyang.li@nxp.com>
Subject: RE: [RFC v2 net-next 3/8] net: mscc: ocelot: set vcap IS2 chain to
 goto PSFP chain
Thread-Topic: [RFC v2 net-next 3/8] net: mscc: ocelot: set vcap IS2 chain to
 goto PSFP chain
Thread-Index: AQHXk/d8zZOvA4oEl0WuxDM4SkoD+6t5WfyAgAE7AFA=
Date:   Thu, 19 Aug 2021 09:49:54 +0000
Message-ID: <DB8PR04MB5785C58BDBD502C78ABCDB89F0C09@DB8PR04MB5785.eurprd04.prod.outlook.com>
References: <20210818061922.12625-1-xiaoliang.yang_1@nxp.com>
 <20210818061922.12625-4-xiaoliang.yang_1@nxp.com>
 <20210818145435.bsbxuq7bbjr4fkel@skbuf>
In-Reply-To: <20210818145435.bsbxuq7bbjr4fkel@skbuf>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Uu38ozAeFTExAiUmzZ48ndmkiEhJgVGm7zToo9GRaf2A230BCxRj/YA58uJZ?=
 =?us-ascii?Q?BfhBxuwEuqqr9hUwitnLIcbdjM7lEgptPDiB9HtzmH6zs/L0J5EbbEF+oLrM?=
 =?us-ascii?Q?b8bCXzzf8H5Re5+tB6zlO31f1Tio/I/GAEnoolSNb3jF09MH0IAtO+1IC3F3?=
 =?us-ascii?Q?usroeazR07Rw3omvXL+lC1M4ZpeCSmN1I+CNJHiZ+2BV/5wfvkKd5lRyNBLG?=
 =?us-ascii?Q?I5oUniKa1X81EV7ew49tG+LuDp0YD33ZJLVeteYuX0Y0XiRGJj3FKvNeliLU?=
 =?us-ascii?Q?SshL3Quvvm045Z/XQ5yrs2xSjC6JYickgEQWU5GDnFpFV+c/cDKEgobMoqZb?=
 =?us-ascii?Q?VvwA57KmkN6u3ONMN73sKoGGWzCljT37VgO9FssXbzl/XKJZaesZsEfe72h6?=
 =?us-ascii?Q?qpGYFmoX2jRfNX10onFtiU0JogaGUgImALvgiSPy+FaTfKB1SndIegXkZVqu?=
 =?us-ascii?Q?+VQwQfu6jQpAsruta7e1ItYL4jIqf6drpgsnmzekaadm0c15IJjcY0lZYg4/?=
 =?us-ascii?Q?aMVYfbJLNjLGp2W4YjlYG4S1KnkVxNqzg4YzBSM0Wwv9ikfyNC9Uz3SJMtON?=
 =?us-ascii?Q?7Q4ge/rK+zezQDNpxUjepAt4J7gclHHZ39ZZIjSVTe4K20OxN09aFXAZbLYa?=
 =?us-ascii?Q?XijEtPl/v0kuXRWxSjrKVu384mOBihqNSfS+9jewL/RVI+0v4STNX6mEq46W?=
 =?us-ascii?Q?ehpGfhkXwpa7P3MZB1urGpvBP9jV99mdEUscvZD95ApnkhJsQIKXGa3n7m/f?=
 =?us-ascii?Q?CxXZnBK//cLqrcdXJDnEqcLGNVeTSjocYeaLBaDZFDBEMArYAg7lBquvoHWs?=
 =?us-ascii?Q?Xj6Tyi1uIW1t/qVww9/yMHnK4Zm0BDn6qU03JnUqUNzWot4KQQ+3EkKdcABY?=
 =?us-ascii?Q?WyPwJudBIm9g998yrKIM1n6yK4UJrgrGFpWa6wNqadrTDZy/Eki63b6tmgFC?=
 =?us-ascii?Q?yEFlxpgZb+MuxWdJp1kqjY5cYIWctxTd0Yud0AK8T/CJr5YBFjNTcfAx3Yl8?=
 =?us-ascii?Q?+mnnhFQMMI8xMRAK9HKvGQNNWKkwVCLAnWKd/feSVs4JvE+X0yEkyDVHrDWh?=
 =?us-ascii?Q?fn4MEtJ7wQENwS18FZMbtk/CsholV44rCJujxma4/dcGejEMD7THsJheDWG/?=
 =?us-ascii?Q?g7j+8Q+Gwl7L6+fNQ87gOF633XjyXT1lF4I1QEQmX1jHLa+/8uzjJnVyNBDq?=
 =?us-ascii?Q?wF/Z6HdlYgzvjn7RXew6yKJpqTx1ImDlZUdsxWYXP0UhLWww6mHtRSX+LqBm?=
 =?us-ascii?Q?zkeM3TpwZ74YLb5tK0mIWhKuC4cvT+8kbxS5TihYsPQQH+aUb+8NTiS0Dr3c?=
 =?us-ascii?Q?0M+hZ/En/v5NaK8dr9q+BX3c?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB5785.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b5e83c6-fc18-49b9-f12e-08d962f6b28e
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Aug 2021 09:49:54.4076
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KV8eA8uikDUvAL6qTZbtbgiOdFG8OdiqMj8WLC/7OhtzdJ02sC6NARSdm+pLR+PTqlTXiwO/N9axkOAqg3hfsWqAQWQZUu6hzsNeVgYKduc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2726
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Wed, Aug 18, 2021 at 22:55:23PM +0800, Vladimir Oltean wrote:
> > @@ -353,7 +364,7 @@ static int ocelot_flower_parse_action(struct
> > ocelot *ocelot, int port,
> >
> >  	if (filter->goto_target =3D=3D -1) {
> >  		if ((filter->block_id =3D=3D VCAP_IS2 && filter->lookup =3D=3D 1) ||
> > -		    chain =3D=3D 0) {
> > +		    chain =3D=3D 0 || filter->block_id =3D=3D PSFP_BLOCK_ID) {
> >  			allow_missing_goto_target =3D true;
>=20
> I would like to not allow missing "goto" targets for new filter chains.
>=20
> Due to legacy support we must keep support for VCAP IS2 on chain 0, but e=
ver
> since we added the ability to offload multiple chains corresponding to mu=
ltiple
> hardware blocks, we should really use that precise chain ID, and chain 0 =
should
> just goto the first used chain in the pipeline.
>=20
> Makes sense?
>=20
Because the PSFP chain is the last chain now, I allow missing "goto" target=
s. Once we add a new chain like FRER, I will delete this allow missing "got=
o" for PSFP block chain.

Thanks,
Xiaoliang