Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "allan.nielsen@microchip.com" <allan.nielsen@microchip.com>,
        "joergen.andreasen@microchip.com" <joergen.andreasen@microchip.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "vinicius.gomes@intel.com" <vinicius.gomes@intel.com>,
        "michael.chan@broadcom.com" <michael.chan@broadcom.com>,
        "vishal@chelsio.com" <vishal@chelsio.com>,
        "saeedm@mellanox.com" <saeedm@mellanox.com>,
        "jiri@mellanox.com" <jiri@mellanox.com>,
        "idosch@mellanox.com" <idosch@mellanox.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "kuba@kernel.org" <kuba@kernel.org>, Po Liu <po.liu@nxp.com>,
        Leo Li <leoyang.li@nxp.com>
Subject: RE: [RFC v2 net-next 4/8] net: mscc: ocelot: add gate and police
 action offload to PSFP
Thread-Topic: [RFC v2 net-next 4/8] net: mscc: ocelot: add gate and police
 action offload to PSFP
Thread-Index: AQHXk/d9BPsg5KTR3E2gqQF4SGe+36t5W8AAgAE7puA=
Date:   Thu, 19 Aug 2021 10:00:43 +0000
Message-ID: <DB8PR04MB57852F0E658C57DD4B0B76E2F0C09@DB8PR04MB5785.eurprd04.prod.outlook.com>
References: <20210818061922.12625-1-xiaoliang.yang_1@nxp.com>
 <20210818061922.12625-5-xiaoliang.yang_1@nxp.com>
 <20210818150053.numtnvntscxcm6r4@skbuf>
In-Reply-To: <20210818150053.numtnvntscxcm6r4@skbuf>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gFAYxY8B26xRkV2gPr0fzCjq1ut/0/g3ECbxwMcq3i4KTacZuo8LpQpybo61?=
 =?us-ascii?Q?XIdkwlS9wCH23usKu+hlTSe2nHk0nUlvMmIVRMNl4CEkkJYz2j6jsF5uj5G8?=
 =?us-ascii?Q?9e56qWhrtRiFFGXbtE61WSVqWJdnesCytZ1SYeR2Lu9Y+xWtCKtVPGpRnjhO?=
 =?us-ascii?Q?7hF+5YkzYhVJ3HwU1SOnzxR2lqy1kp326PgU2PcJjfkRjtS2kZkvnIPSwSvX?=
 =?us-ascii?Q?mYZLrac7P6Baj0pRXO7sTJNxIu2fXeGRBFMvkKqWSTDqGVW66DvgyhA8aevc?=
 =?us-ascii?Q?bynhfcXp0XJuxuZvNmUO8zl6Xgmv0p2BYJ2+621CNznowLl6bMphchmCprQK?=
 =?us-ascii?Q?ZQlkdfF1sPSKy58tgCwBj4oh/6hJSIkf+UhG2/mOaFlbTS/v8NsmqdfkAodc?=
 =?us-ascii?Q?iKHBMQ+HEzySOB5V3cmc5y5mKnpOCbRM8gJvi+vt3/RpHZ7/J9rWSKC5n3Kc?=
 =?us-ascii?Q?9Sf9mZNEHzEwKzhxG6T78Ik7E+7H0pjVskiYwk42aYOnH8uYrrfg/M9JenKb?=
 =?us-ascii?Q?ZWSwwo5CREhmyYwmDlHaOxJVvg2EWpxI6uY2qoXoIo4vAMtvO270LQSavIpJ?=
 =?us-ascii?Q?cMfqPTDpSJPCVyghnHLDarhlrkd5TqBM+zpm/zR9WYwLGN2Xk8oRcBUb0u3b?=
 =?us-ascii?Q?9nghGu8T17udGjbCWCbI9XevcP7v4iRG0bYa3NYoqlpGpbcYxmZO+HR8sTv2?=
 =?us-ascii?Q?x3xtOpASpGeD7Ws8hBdb1jgFT4cmMcIwtd0smZJJakzOxdu6kjX5Zueh1WRt?=
 =?us-ascii?Q?PQ2LINiwDkjrUOhC9U+ZVxkdkAohruDcsRBuQtKRhpepA8xmmdk0XQ15oqDq?=
 =?us-ascii?Q?LpRLoV1OhD/kr4p2CpweQ9uVwURVk8MojAoXNVF3KCGn4bYUmvLk7QQLcSj/?=
 =?us-ascii?Q?fJgWmZEmVV8MpHV+nUstTo0tMeOMf8rHy5j7fubSscZOuVnezG1vYem0dnMe?=
 =?us-ascii?Q?+qGY1MBuVGxwffPF/ZaKQ8iUK7Ccrbq9jCq5iQrCxUqc30E2lw1ImzPwwckW?=
 =?us-ascii?Q?nUWSAR4X4EODyjhxx5mWg7EMBwJJOwMlldtM7q/U1GIhau0CVs3XHir30y0n?=
 =?us-ascii?Q?WCWLpzb2hllE4m7tQkLGgK53YL4kLBaakv3vdHS1VtO4VfIxa5bRSL1Bbk39?=
 =?us-ascii?Q?JQZnlLvErKDw1j0VcEEVfBeUFoJkT+DQf8fOtqLdoyt4cxmthZmQ1n+3wG7I?=
 =?us-ascii?Q?KzLW2RQvzEwnOCj8bsvFGTMui8Qy7PNOwmgshWrLv8GiCOoia9e6O5KOsw8R?=
 =?us-ascii?Q?lvsRmAz/+iuleaTm+lJsdHhToDLx9xGjKv/ba7Hf0GZFeFDLZFIgSKowI1OY?=
 =?us-ascii?Q?+9gb2aheiMf3va/5AlKbB0WV?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB5785.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: afbbdad8-30af-4109-b3bb-08d962f83595
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Aug 2021 10:00:43.8851
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7ee4tgshG8k+HI9CSKDhROmT9wvF6BOTCEWal6mMpe8u4neIrXP++GWgtFTQKM6PqW2VYLnHLtvKQ7rP5/iLZm1sSQIUXLJtEQerK3HsvJY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7480
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vladimir,

On Wed, Aug 18, 2021 at 23:01:23PM +0800, Vladimir Oltean wrote:
> > @@ -718,6 +734,15 @@ int ocelot_cls_flower_replace(struct ocelot *ocelo=
t,
> int port,
> >  	if (filter->type =3D=3D OCELOT_VCAP_FILTER_DUMMY)
> >  		return ocelot_vcap_dummy_filter_add(ocelot, filter);
> >
> > +	if (filter->type =3D=3D OCELOT_PSFP_FILTER_OFFLOAD) {
> > +		kfree(filter);
> > +		if (ocelot->ops->psfp_filter_add)
> > +			return ocelot->ops->psfp_filter_add(ocelot, f);
> > +
> > +		NL_SET_ERR_MSG_MOD(extack, "PSFP chain is not supported in
> HW");
> > +		return -EOPNOTSUPP;
> > +	}
> > +
> >  	return ocelot_vcap_filter_add(ocelot, filter, f->common.extack);  }
>=20
> Hmm, I don't really like the idea of allocating an ocelot_vcap_filter whi=
ch we
> don't need for PSFP filters, just to kfree it later.
>=20
> Is it that much more complicated to not allocate it at all in the first p=
lace, add
> a bunch of "if" conditions that allocate a VCAP filter only if we are off=
loading a
> VCAP chain?
>=20
> And that means, don't create ocelot_vcap_filter::type =3D=3D
> OCELOT_PSFP_FILTER_OFFLOAD, because PSFP filters are not VCAP filters.
The "vcap filter" variable need to be created and use ocelot_flower_parse()=
 to get the type. If the rule is checked as a OCELOT_VCAP_FILTER_DUMMY, the=
 chain 30000 dummy rule will be added in vcap_dummy_filter. And not offload=
 to PSFP filter function. So I created the "vcap filter" and free it before=
 offload to PSFP filter function.

Thanks,
xiaoliang