From: ebiederm@xmission.com (Eric W. Biederman)
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@osdl.org>,
       "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] introduce put_pid_rcu() to fix unsafe put_pid(vc->vt_pid)
References: <20061201234826.GA9511@oleg>
	<20061203130237.761bb15d.akpm@osdl.org> <20061203212926.GA428@oleg>
Date: Sun, 03 Dec 2006 16:18:24 -0700
In-Reply-To: <20061203212926.GA428@oleg> (Oleg Nesterov's message of "Mon, 4
	Dec 2006 00:29:26 +0300")
Message-ID: <m1psb0efgf.fsf@ebiederm.dsl.xmission.com>
User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1005
Lines: 27

Oleg Nesterov <oleg@tv-sign.ru> writes:

>> task_struct* or something?
>
> I don't think this is good. It was converted from task_struct* to pid*.
>
> Eric, what do you think?

I think I have a fix that uses the proper locking sitting in my queue that
I haven't pushed because I have been got to look at just about every
irq but present in 2.6.19-rcX.  Then for some reason I had this stupid
usb debug cable sitting on my desk and since I can't stand useful
things going unused I just wrote a driver for that :)

Anyway with a little luck I should be working on the pid namespace and
this stuff later today so I will try and send out the proper patch.

Not that I'm really opposed to this infrastructure but I'd like to
avoid it until we really need it.

Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/