Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210819033001.20136-1-hpa@redhat.com> <20210819033001.20136-7-hpa@redhat.com>
In-Reply-To: <20210819033001.20136-7-hpa@redhat.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 19 Aug 2021 15:08:51 +0300
Message-ID: <CAHp75VdtXa=WXEFmvDP+zjmodzvJ+FmOpVZ6dq0C=nKnK=_zXA@mail.gmail.com>
Subject: Re: [PATCH v3 06/20] platform/x86: intel_scu: Move to intel sub-directory
To:     Kate Hsuan <hpa@redhat.com>
Cc:     Alex Hung <alex.hung@canonical.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <mgross@linux.intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        AceLan Kao <acelan.kao@canonical.com>,
        Jithu Joseph <jithu.joseph@intel.com>,
        Maurice Ma <maurice.ma@intel.com>,
        Sujith Thomas <sujith.thomas@intel.com>,
        Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
        Zha Qipeng <qipeng.zha@intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        "David E . Box" <david.e.box@linux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Dell.Client.Kernel@dell.com,
        Platform Driver <platform-driver-x86@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Aug 19, 2021 at 6:33 AM Kate Hsuan <hpa@redhat.com> wrote:
>
> Move intel_scu to intel sub-directory to improve readability.

Intel SCU

...

> -obj-$(CONFIG_INTEL_SCU_IPC)            += intel_scu_ipc.o
> -obj-$(CONFIG_INTEL_SCU_PCI)            += intel_scu_pcidrv.o
> -obj-$(CONFIG_INTEL_SCU_PLATFORM)       += intel_scu_pltdrv.o
> -obj-$(CONFIG_INTEL_SCU_WDT)            += intel_scu_wdt.o
> -obj-$(CONFIG_INTEL_SCU_IPC_UTIL)       += intel_scu_ipcutil.o

> +

Stray change?

...

> +obj-$(CONFIG_INTEL_SCU_IPC)            += scu/
> +obj-$(CONFIG_INTEL_SCU_PCI)            += scu/
> +obj-$(CONFIG_INTEL_SCU_PLATFORM)       += scu/
> +obj-$(CONFIG_INTEL_SCU_WDT)            += scu/
> +obj-$(CONFIG_INTEL_SCU_IPC_UTIL)       += scu/

One entry is enough.

...

> +obj-$(CONFIG_INTEL_SCU_IPC)            += ipc.o
> +obj-$(CONFIG_INTEL_SCU_PCI)            += pcidrv.o
> +obj-$(CONFIG_INTEL_SCU_WDT)            += wdt.o

This is not an equivalent. Please, use the same approach as below.

> +intel_scu_pltdrv-y                     := pltdrv.o
> +obj-$(CONFIG_INTEL_SCU_PLATFORM)       += intel_scu_pltdrv.o
> +intel_scu_ipcutil-y                    := ipcutil.o
> +obj-$(CONFIG_INTEL_SCU_IPC_UTIL)       += intel_scu_ipcutil.o

-- 
With Best Regards,
Andy Shevchenko