Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 19 Aug 2021 15:30:08 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Mihai Carabas <mihai.carabas@oracle.com>
Cc:     arnd@arndb.de, gregkh@linuxfoundation.org,
        christophe.jaillet@wanadoo.fr, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc/pvpanic: fix set driver data
Message-ID: <YR5O0IETmMOgftVv@smile.fi.intel.com>
References: <1629301110-2714-1-git-send-email-mihai.carabas@oracle.com>
 <1629301110-2714-2-git-send-email-mihai.carabas@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1629301110-2714-2-git-send-email-mihai.carabas@oracle.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Aug 18, 2021 at 06:38:30PM +0300, Mihai Carabas wrote:

Thank you for the report and fix! My comments below.

> Add again dev_set_drvdata in order for dev_get_drvdata to not return NULL.

dev_set_drvdata()
dev_get_drvdata()

> Fixes: 394febc9d0a6 ("misc/pvpanic: Make 'pvpanic_probe()' resource managed")

> 

Shouldn't be blank line(s) in the tag block.

> Signed-off-by: Mihai Carabas <mihai.carabas@oracle.com>

...

> +	dev_set_drvdata(dev, pi);
> +
>  	return devm_pvpanic_probe(dev, pi);

I think it makes sense to have the above line as a part of pvpanic_probe().

-- 
With Best Regards,
Andy Shevchenko